Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: LiLPvJEN93fOxYAYKuC4pOodMneGufyljNSEj/q62ZPs1Olx85l40V/HhWOU/UQ5dKvYHqrcX2
 o/DGtR4SB6VxyuUOxoY8fPAwc310TwnCwKOl2Ig46lW/3vKHmYmw445LHA08Y9RhONEGvEqCPV
 70OEduIaT9sf7ACfDg/otZw3iY6rpxR1gPq5+GUrNuiT70mAxez8ZAX+VzcR6ADn7RqCBul47S
 u8VTm0jqVNvQTR0hFOZE0V9h55sNzGqe3ecdJGBenL/cEL7wDIz/0Y65N3N8D3OaiIEqo/tnMz
 wqo=
IronPort-PHdr: =?us-ascii?q?9a23=3AqGX4+BRFJJcCWF4O/linAExZRNpsv+yvbD5Q0Y?=
 =?us-ascii?q?Iujvd0So/mwa69YxGN2/xhgRfzUJnB7Loc0qyK6vqmADFdqszd+Fk5M7V0Hy?=
 =?us-ascii?q?cfjssXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aFR?=
 =?us-ascii?q?rwLxd6KfroEYDOkcu3y/qy+5rOaAlUmTaxe7x/IAiooQnLq8UbgYtvJqkvxh?=
 =?us-ascii?q?bGv3BFZ/lYyWR0KFyJgh3y/N2w/Jlt8yRRv/Iu6ctNWrjkcqo7ULJVEi0oP3?=
 =?us-ascii?q?g668P3uxbDSxCP5mYHXWUNjhVIGQnF4wrkUZr3ryD3q/By2CiePc3xULA0RT?=
 =?us-ascii?q?Gv5LplRRP0lCsKMSMy/XrJgcJskq1UvBOhpwR+w4HKZoGVKOF+db7Zcd8DWG?=
 =?us-ascii?q?ZNQtpdWylHD4ihbYUAEvABMP5XoInzpVQArRWwCwqxCu3x1jBFnWP20bEg3u?=
 =?us-ascii?q?g9DQ3KwA4tEtQTu3rUttX1M6ISXPi3w6nJzDTDb+5W2TDg44fLchAuu/CMVq?=
 =?us-ascii?q?93fMvRyEgvFxnKjlSMpYD5MT6YzfkNvHSB7+Z6S+2glnMnphh3rzOyxckskp?=
 =?us-ascii?q?HEipwJxl3A7yl0w4Y4KcelREN6Y9OoCplduzycOoBrWM0tWXtotzw/yrAevJ?=
 =?us-ascii?q?67ezUFx4o/yh7EbvyHb5CI4hX+VOaNOTt4hGxqeLa4hxuq9Eiv0Oz8Vs2t3F?=
 =?us-ascii?q?ZOoCpJj8DAtn4P2hDO8MSHRfx9/kCu2TaLyQ/f8P1LIUcxlabDKp4hxKA/lo?=
 =?us-ascii?q?YLvEjdAiP7nF/6gayWe0k+5+Sl6ubqbq/kq5OBL4N0jxvxMqUqmsyxG+Q4NQ?=
 =?us-ascii?q?0OUnCb+OW91L3s50z5TKlWgvA4iaTZrYzVJd4BqqGnHgBVz54v6wyjADe+zN?=
 =?us-ascii?q?QYgX4HIUpBeBKGiYjpJl7PLOn7DfihmVSslilkx/TdM73/DZXCMGLDnK3ifb?=
 =?us-ascii?q?lj8U5czhQ8zdRF65JTELEBL6G7ZkiklNXeFVcHPha33ufjQIF9yI4EWn+OBo?=
 =?us-ascii?q?eJK//btVvO4OZ5cMeWY4pAiTfvK+Uir8zuhH5xzU4PfaCohcNMQG2zBLJrL1?=
 =?us-ascii?q?jPMimkucsIDWpf5ll2d+ftklDXFGcLP3s=3D?=
MIME-Version: 1.0
References: <20190821210931.9621-1-yzhai003@ucr.edu> <afa0a08e-30ff-7958-fb09-3e3d58d47f0e@xs4all.nl>
In-Reply-To: <afa0a08e-30ff-7958-fb09-3e3d58d47f0e@xs4all.nl>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Mon, 26 Aug 2019 16:32:17 -0700
Message-ID: <CABvMjLT8F+a7X6e8T-UHWGT751MyiXsXn_6artQjNzhQgFCYPQ@mail.gmail.com>
Subject: Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if
 cx2341x_ctrl_query() returns error code
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     Chengyu Song <csong@cs.ucr.edu>, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Mike Isely <isely@pobox.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the correction, let me send a new patch then.

On Mon, Aug 26, 2019 at 5:09 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 8/21/19 11:09 PM, Yizhuo wrote:
> > Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
> > will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
> > However, it will be used in the later if statement, which is
> > potentially unsafe.
> >
> > Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> > ---
> >  drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> > index ad5b25b89699..1fa05971316a 100644
> > --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> > +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> > @@ -793,6 +793,7 @@ static unsigned int ctrl_cx2341x_getv4lflags(struct pvr2_ctrl *cptr)
> >       struct v4l2_queryctrl qctrl;
> >       struct pvr2_ctl_info *info;
> >       qctrl.id = cptr->info->v4l_id;
> > +     memset(&qctr, 0, sizeof(qctrl))
>
> Please compile test your patches! This doesn't compile due to a typo
> (qctr -> qctrl).
>
> Also, this would overwrite qctrl.id with 0, not what you want.
>
> Instead, just do:
>
>         struct v4l2_queryctrl qctrl = {};
>
> to initialize the struct with all 0.
>
> Regards,
>
>         Hans
>
> >       cx2341x_ctrl_query(&cptr->hdw->enc_ctl_state,&qctrl);
> >       /* Strip out the const so we can adjust a function pointer.  It's
> >          OK to do this here because we know this is a dynamically created
> >
>


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside