Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 6OEh149dR4LsnU11jRGCoPa7ews15zRkUGv+youfSN5WKqSy3t2/DzOae+BnWKsvxRyaQOoK5u
 i/XXOZj2eWQc9d1OWx8yIXPHZarDr2eu/21rSpG4tUdX2ip22q6qHxOmaDGXLm5L2x5wKh1Hgz
 kp2jQlUTDemY/dbw/fqzqBorH4yCDuns2cEddPeT4ODg0juMqGZMmsI68nBOHaxmwagDyY0Vvq
 BoJSbyCObRZD0zWKjVdjvovfCoeimhNnhXY5xheIusXEEn7fvmCHpETZjSIkOBLGA6b7n7EGfA
 Gno=
IronPort-PHdr: =?us-ascii?q?9a23=3AYi3DURGcOzTSSUSY97Iwj51GYnF86YWxBRYc79?=
 =?us-ascii?q?8ds5kLTJ78rsiwAkXT6L1XgUPTWs2DsrQY0rCQ6v29EjZfqb+681k6OKRWUB?=
 =?us-ascii?q?EEjchE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAA?=
 =?us-ascii?q?jwOhRoLerpBIHSk9631+ev8JHPfglEnjWwba5sIBmssAnctskbjYR8Jqsz1x?=
 =?us-ascii?q?DEvmZGd+NKyG1yOFmdhQz85sC+/J5i9yRfpfcs/NNeXKv5Yqo1U6VWACwpPG?=
 =?us-ascii?q?4p6sLrswLDTRaU6XsHTmoWiBtIDBPb4xz8Q5z8rzH1tut52CmdIM32UbU5Ui?=
 =?us-ascii?q?ms4qt3VBPljjoMOiUn+2/LlMN/kKNboAqgpxNhxY7UfJqVP+d6cq/EYN8WWX?=
 =?us-ascii?q?ZNUsNXWixEA4O8dJAPD+sHPeZXsoLzuUIApgawBQmtGuzvziJHjWLy0aA0z+?=
 =?us-ascii?q?gtFAfL1xEiEd0TqnTZtNX7OrkPX+67z6fGyi7OY+9K1Trn9ITFaAwtre2KUL?=
 =?us-ascii?q?ltccTR004vFwbdg1qSqIzkPjOV1vkKs2OG6OdhVeOui249pAFwvjSj2skhh5?=
 =?us-ascii?q?LUho0J0FDI7zt2z5soJdChTkNwfN2qEINIui2EK4d7RtkuTmJotSog1LEKpJ?=
 =?us-ascii?q?62cDIXxJkjxBPTc+GLfomM7x75SuqcLzd1iGh7dL++nRq/80etx+vhXceuyl?=
 =?us-ascii?q?lKtDBKktzUu3AI0Bzc99aIR+Nm/kekxTaPzwfT6vxYIUwslarUNZohwrkom5?=
 =?us-ascii?q?oWq0vDHyv2lFzujK+Za0ko4+ao5/njb7jlvJOcOIh0igbxMqQqhMOzG/g3Mg?=
 =?us-ascii?q?8LX2SD+OS80qPs/VHhTblUkvE7lrPVvZPaKMgBuKK1Hg9Y3pw+5xu7DDqqyN?=
 =?us-ascii?q?EYkmMGLFJBdhKHlY/pO1TWLfH4DPa/g06jkDZ3y/zaMLDsGYjNIWTZkLv7Y7?=
 =?us-ascii?q?ly9lNcxBIpzd9D/5JUFq0BIPXrV0/1tdzYCAI5MgOtz+bkFtp9zIUeVnyLAq?=
 =?us-ascii?q?KCLqPSvkGH5vg1L+mPeoAVojD9JOYh5/L0in85g1AdLuGHx5wSPUG5DPR7JA?=
 =?us-ascii?q?3NcGjsi9ZZSTwiowEkCuHmlQvRAnZoe3+uUvdktXkAA4W8ANKGGdig?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Mike Isely <isely@pobox.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if  cx2341x_ctrl_query() returns error code
Date:   Mon, 26 Aug 2019 16:55:28 -0700
Message-Id: <20190826235528.9923-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
However, it will be used in the later if statement, which is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index ad5b25b89699..66a34fb9e6b2 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -790,7 +790,7 @@ static int ctrl_cx2341x_set(struct pvr2_ctrl *cptr,int m,int v)
 
 static unsigned int ctrl_cx2341x_getv4lflags(struct pvr2_ctrl *cptr)
 {
-	struct v4l2_queryctrl qctrl;
+	struct v4l2_queryctrl qctrl = {};
 	struct pvr2_ctl_info *info;
 	qctrl.id = cptr->info->v4l_id;
 	cx2341x_ctrl_query(&cptr->hdw->enc_ctl_state,&qctrl);
-- 
2.17.1