Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5004705ybl; Mon, 26 Aug 2019 20:42:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwqKJxwh0B/EUGOHiCY3dLzQytw0+TiQQDmiaJWBrQQKWVb4ecDeRKe51ZjIEm0x/72d+5N X-Received: by 2002:a63:e948:: with SMTP id q8mr18765947pgj.93.1566877368497; Mon, 26 Aug 2019 20:42:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566877368; cv=none; d=google.com; s=arc-20160816; b=sJbkjmKPSLUUzIquAwsoOr65ZUVbiiEDl0sYdTZmgFw5hI+YRtrFdEwJFvfi07nL+c aA50ueaMwIcidGQJ1oaE3xM76vi6MwwX181GvYMMkTIHY+JRnY5ql7oWrkPzAUIX9805 rKrYdUaEiHn5GWfHQlX/IXPx2dcRJbXzphidftoCwQwcsSu/ZT3VdMsIa2z3qQ8Lu1Jy iBtoTjrucGmOpjnmJnIgBZxNb2h+jXcZK9qcWuy2TtEXOST593lwF3S9QZIVRoIjjEvy +sSE+iXz/imip+4jvZtRBc/P89mxbfkA0+ECzgfO8lWviM+hYAs7iIlXb2wFjx9inu6V gNLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=M7PS5ziaxYUnu7pDK8VABQe9t1jvYsJD4g/oOQm2MTo=; b=mNBwHxKYQ0AB7RPTl9gFXsmgF25DEeMnLcRa3NEScP0/XFV+bTejy0gZrF1Ws+gO3O ccGAENYPMqSVem7owwSw7sEb6+a/vynFfTuQZRjtt43Hs89KiestrmtHa1/6CfZxvuKt DoYCPnUMP4RnH+9DyPLJTRipMv0TbglucKPkAiy4f1zXbnevkLHfBrcGwL1ns9H9eAB9 vAFU+2dpdkaAmqhEsIcMJqUHWBpQyyrJ2SxidXgtW4SRSQX5RrhORCNscuoLblLQhpqA bs/ARwIJb+cLzZwtlfSbNU/afAh3Q165o5BNxhsCpv7dm2z12cYuvASOK5Vrd/Ujvap2 Z9pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y15si12262393pfb.28.2019.08.26.20.42.33; Mon, 26 Aug 2019 20:42:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729045AbfH0DlG (ORCPT + 99 others); Mon, 26 Aug 2019 23:41:06 -0400 Received: from smtprelay0147.hostedemail.com ([216.40.44.147]:35302 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728025AbfH0DlF (ORCPT ); Mon, 26 Aug 2019 23:41:05 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 0F6B31802E6D6; Tue, 27 Aug 2019 03:41:04 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:69:355:379:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3874:4321:5007:7514:7903:10004:10400:10450:10455:10848:11232:11658:11914:12043:12297:12555:12740:12760:12895:13069:13141:13230:13311:13357:13439:14181:14659:14721:14819:19904:19999:21080:21451:21627:30054:30055:30056:30070:30091,0,RBL:23.242.196.136:@perches.com:.lbl8.mailshell.net-62.14.0.180 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:34,LUA_SUMMARY:none X-HE-Tag: sofa02_2639caa3ebe21 X-Filterd-Recvd-Size: 2243 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Tue, 27 Aug 2019 03:41:02 +0000 (UTC) Message-ID: <877726fc009ee5ffde50e589d332db90c9695f06.camel@perches.com> Subject: Re: [PATCH] net: intel: Cleanup e1000 - add space between }} From: Joe Perches To: Jeff Kirsher , Forrest Fleming , Andrew Morton Cc: "David S. Miller" , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 26 Aug 2019 20:41:00 -0700 In-Reply-To: References: <20190823191421.3318-1-ffleming@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote: > > suggested by checkpatch > > > > Signed-off-by: Forrest Fleming > > --- > > .../net/ethernet/intel/e1000/e1000_param.c | 28 +++++++++---------- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > While I do not see an issue with this change, I wonder how important it is > to make such a change. Especially since most of the hardware supported by > this driver is not available for testing. In addition, this is one > suggested change by checkpatch.pl that I personally do not agree with. I think checkpatch should allow consecutive }}. Maybe: --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 287fe73688f0..ac5e0f06e1af 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4687,7 +4687,7 @@ sub process { # closing brace should have a space following it when it has anything # on the line - if ($line =~ /}(?!(?:,|;|\)))\S/) { + if ($line =~ /}(?!(?:,|;|\)|\}))\S/) { if (ERROR("SPACING", "space required after that close brace '}'\n" . $herecurr) && $fix) {