Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5014700ybl; Mon, 26 Aug 2019 20:57:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyk4syCEvb/BE8+9peOe0zZ59R+tz9K4ZmhI2FzdH+rI9tg3hmo0wyl+hK0b4bJGGbphHmw X-Received: by 2002:a17:90a:256d:: with SMTP id j100mr23079490pje.126.1566878251285; Mon, 26 Aug 2019 20:57:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566878251; cv=none; d=google.com; s=arc-20160816; b=bXECzndQVB7IoBmRxr7i3Ew24JzXGjUI8PJRRMFKeS6rmYnrXu/mmYwlr2gL56j3rv vgBp4SHF/uiNCvTHZ4Kcu8ACpIp7A7pebpnDvCbIrRXNvik39XC0xAcJIoMm13lkpYBu hrpYhQiHgn+/z6BAq4Duk144YOj0byExoL9OJr73U3+e6R0i9aNsAqeYs8WdPTJynieC cb06IMtdsqmgfahVqJczaAGhZ5eKwWGeafugytccpIMwfsLSNxvukBPH6SdOsTMz4CPn 8GlWH8dq2bXtHacLlqoE3lDjJIhAxr4gtRnmQLPL7vauS2XlLWxtSYWYfBZgs0ZE+7m5 6XZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=6EJMyarmYjBCH0JlHJ5Qkk/c97qUL5wxXTXRcjUHiBc=; b=L7lyaj54UjcoiNIKFtd1/Uq73Hg21tx3hB+2yoxOYDxHsOBCQ3oE/ATEvAR72omVGq vNi6PKJqxUidlH/qaE+lW/DUElrBJe6ZepoCBXtTvpzpGmthbk7xOVRT2BtiQeyJDorE E6bVCsPlQVFHPumeRgWeeLaP19V12L7KPgx8nQWY7qEiC2WveUkVGbB+jOm5uYUCWTP9 yecrBnJc1GrCA4twV4NCP75NkTLgzHTvSp9CtMUc/LEMbQErMciBGnY4RfCz0w6ew/El tVcmrROABpVz4yT2MEfP7HHY2s+J4Feng6qR7iTpVwFM72+ZdlxMu4Uw9Zv1PNzu+1HA b0jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m12si1351503pjq.60.2019.08.26.20.57.15; Mon, 26 Aug 2019 20:57:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729123AbfH0D43 (ORCPT + 99 others); Mon, 26 Aug 2019 23:56:29 -0400 Received: from inva020.nxp.com ([92.121.34.13]:44920 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbfH0D43 (ORCPT ); Mon, 26 Aug 2019 23:56:29 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id A8CA41A05A0; Tue, 27 Aug 2019 05:56:27 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 8DA431A009E; Tue, 27 Aug 2019 05:56:19 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 92751402A5; Tue, 27 Aug 2019 11:56:09 +0800 (SGT) From: Shengjiu Wang To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, alsa-devel@alsa-project.org, viorel.suman@nxp.com Cc: linux-imx@nxp.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] ASoC: imx-audmix: register the card on a proper dev Date: Tue, 27 Aug 2019 11:55:15 -0400 Message-Id: <1566921315-23402-1-git-send-email-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This platform device is registered from "fsl_audmix", which is its parent device. If use pdev->dev.parent for the priv->card.dev, the value set by dev_set_drvdata in parent device will be covered by the value in child device. Fixes: b86ef5367761 ("ASoC: fsl: Add Audio Mixer machine driver") Signed-off-by: Viorel Suman Signed-off-by: Shengjiu Wang --- sound/soc/fsl/imx-audmix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c index 9e1cb18859ce..71590ca6394b 100644 --- a/sound/soc/fsl/imx-audmix.c +++ b/sound/soc/fsl/imx-audmix.c @@ -325,14 +325,14 @@ static int imx_audmix_probe(struct platform_device *pdev) priv->card.num_configs = priv->num_dai_conf; priv->card.dapm_routes = priv->dapm_routes; priv->card.num_dapm_routes = priv->num_dapm_routes; - priv->card.dev = pdev->dev.parent; + priv->card.dev = &pdev->dev; priv->card.owner = THIS_MODULE; priv->card.name = "imx-audmix"; platform_set_drvdata(pdev, &priv->card); snd_soc_card_set_drvdata(&priv->card, priv); - ret = devm_snd_soc_register_card(pdev->dev.parent, &priv->card); + ret = devm_snd_soc_register_card(&pdev->dev, &priv->card); if (ret) { dev_err(&pdev->dev, "snd_soc_register_card failed\n"); return ret; -- 2.21.0