Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5133155ybl; Mon, 26 Aug 2019 23:20:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoVi0xyYZy2ySruwlTF5D86ANWMr9CBBt6S1KwwCZeBEJOOWjd/g/qcRbFCWXIrMC0kDwf X-Received: by 2002:a17:902:b715:: with SMTP id d21mr21907596pls.50.1566886856408; Mon, 26 Aug 2019 23:20:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566886856; cv=none; d=google.com; s=arc-20160816; b=i8Qix6Uu/hoT0Owe0RqOJAGQctsq3X+9+JYYoHoQi09Aq5t8p9c01SQ34It/w1sNoI HhERD/W1ow5tOREeLAk4bYNoxS0T5N7gSiI60no3LT1Un0PDU+65AvU2FUifv8jnjHfg cVFTo7rTFnjVJdSPx9UwWZpZxxQkDZqMvt/5xD64efEela80jTmim7LMWntmZQQ2yuri ewT3mAT+6k0Fh8ey6arLezuOenAOGwKIX6cD6H/y9zdMVtAugK6/GYwerrpW8ya1kMIt Lc12VM1AJy3N0ZCibMFAPZWtiCCyVO/KR2upzgB1ydz8QMT420GERJ0wSYSvDYRT8JLp qLNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=53aHtNCHp8SvMn2NcDcBHRRILS8Due8j2LJ/vkjPHGM=; b=YpiKyXZSBmEsSMFFTSc6RiTCUdoKShMluGplFmES0ZaDRsvMRefxdkUvkpWvA7INL7 sTqkwAnSfwhuRIxqHtpIGGhwsCbeaPZ73b2bcQznOJ7fCsxso7WDhfxiq/zvuRnSD6pn buf/u7CDBYu9JSs+UpIbp9S1rWfloLJRJjZOcdLkaYvK+SaiR1VKdDgtxOchCVrMTGCV +IUypjeFjDePVaMnKvn+6d/QUzNe6/z8ExqxNl0L25IpfUkwBpM8AVklHSB46ZTbUdQy tnhW9cs7FRg213P2RqgJ3PvmgphP7xaFFpH1uwt5Q78Jp1tFN4AQz2zfkrfFw9TO6TYN OuLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jR85DFUH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v31si11952487plg.339.2019.08.26.23.20.40; Mon, 26 Aug 2019 23:20:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jR85DFUH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfH0GTg (ORCPT + 99 others); Tue, 27 Aug 2019 02:19:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:39406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbfH0GTf (ORCPT ); Tue, 27 Aug 2019 02:19:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF3DD206BB; Tue, 27 Aug 2019 06:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566886775; bh=gcxXUgEVmD3tszbvz3/XBtWwmU2RW47+E5iLJXT9x6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jR85DFUH7lu3yeWJekLjv4K1HEeClksUtBYq4aFtdESGepJ3YYC5/T7Fc0tNR9NPG x9zoQbynhMYyM8ImlzqKZrrg4lv4Diw0TSTuUQdntzN8PkHfx9nTwVxtox6O/KEwL8 pYxcJBdbgNUYp3pLq+uNPOnrRwvOuQ5eAVIKN7ao= Date: Tue, 27 Aug 2019 08:19:33 +0200 From: Greg Kroah-Hartman To: Alastair D'Silva Cc: alastair@d-silva.org, stable@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Allison Randal , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB Message-ID: <20190827061933.GA29250@kroah.com> References: <20190821001929.4253-1-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821001929.4253-1-alastair@au1.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 21, 2019 at 10:19:27AM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > The upstream commit: > 22e9c88d486a ("powerpc/64: reuse PPC32 static inline flush_dcache_range()") > has a similar effect, but since it is a rewrite of the assembler to C, is > too invasive for stable. This patch is a minimal fix to address the issue in > assembler. > > This patch applies cleanly to v5.2, v4.19 & v4.14. > > When calling flush_(inval_)dcache_range with a size >4GB, we were masking > off the upper 32 bits, so we would incorrectly flush a range smaller > than intended. > > This patch replaces the 32 bit shifts with 64 bit ones, so that > the full size is accounted for. > > Changelog: > v2 > - Add related upstream commit Now applied, thanks. greg k-h