Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5224020ybl; Tue, 27 Aug 2019 01:05:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrhofNRrSf8Ht58656WII5TM4VQL7msf603wpgvV01FfIHK734zI216nKjZEu6Kch5m06+ X-Received: by 2002:aa7:9a52:: with SMTP id x18mr25346326pfj.8.1566893102751; Tue, 27 Aug 2019 01:05:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566893102; cv=none; d=google.com; s=arc-20160816; b=kUO1SQSRWdePAlvE+wqMjq5aF94RMnnFeBmKBtKUem1yRzvy31CamOeVuPkCQALLh/ MWRSDUwSUaBvrYalBEraTcHel1Q/sAaoKMrilY2/zXtpsIkkAW55rxtsoSDaqmHQXjKb PwGpBbjRt7n1HeTj6cFmjEUpP1EPpVw/Ok/IT/mJXvOvlA32J+enrMlnNbIZYi6/grc/ qrbQvb1ULGSnYlNMEm54whh/U+94RyQIOLLNwKnvU5h8DUSLWFIY6wwU0dLbku1LxnRC Jg6YiOuaK9lYNq9eAs3PBoWZA4mawWvk1TEytVSrBHFsTQKHbVeXSdlXeyp2wcmijvhd UQAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xQ7dY+PGssJisDlfR4hRaJd0dkftJNeZKh8zilXqMfM=; b=RZyY/6tBJnAjl/kvQKJ5Fz3A0zyaI7i5z0r7e0geRsz0PhcO9KevHZU4JsrhO1GRHK n1oZ/B1qIQqHFRe62jCapB+3qAJeeyX0XO0uwKFJrmsLPk5VlBYWA6tN220W8jq875tr to2YudPqaqXp1wUo5duGIslxOLCiMfJuxWnYY9oHV16xFeTjBsZWw00iso0BVNMghJEq qjCVKpmTxxSsjQ5uKvJ92VfXErcDJrpr0cq4/Uq9/G4PeNDBQXGM9V26SmZaJWWi5fRM SQ3i83UJlyGVnnv3u6MkDnFtzZRJqk47aUU5JMmdewiUX1B60tjHcK3Np1u3b2nUsiVW QaBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hB2s1o6C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e33si11874676pld.436.2019.08.27.01.04.48; Tue, 27 Aug 2019 01:05:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hB2s1o6C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731405AbfH0IDl (ORCPT + 99 others); Tue, 27 Aug 2019 04:03:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:32864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730492AbfH0IDj (ORCPT ); Tue, 27 Aug 2019 04:03:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31477206BA; Tue, 27 Aug 2019 08:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566893018; bh=WNAYaTCm/DuIV/YTw8PphHpZoUionmMISLX3azyMnY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hB2s1o6CldP7yDIIp80VbAjiUqwJDSqqg+3hCo1fC3soXzxqNFN6iPOTlJ3+ULGk6 zwREovTXK0n6j+9INB9iqu6B9rRFE1/0QAaFvXe7fh/VXjBy0HF44nlE2/9EwClON/ pODvRFTpfMGP767lIFlWfrBaiDV7EiPexpJnYwkM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jose Abreu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.2 091/162] net: stmmac: tc: Do not return a fragment entry Date: Tue, 27 Aug 2019 09:50:19 +0200 Message-Id: <20190827072741.339002943@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072738.093683223@linuxfoundation.org> References: <20190827072738.093683223@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 4a6a1385a4db5f42258a40fcd497cbfd22075968 ] Do not try to return a fragment entry from TC list. Otherwise we may not clean properly allocated entries. Signed-off-by: Jose Abreu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index 58ea18af9813a..37c0bc699cd9c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -37,7 +37,7 @@ static struct stmmac_tc_entry *tc_find_entry(struct stmmac_priv *priv, entry = &priv->tc_entries[i]; if (!entry->in_use && !first && free) first = entry; - if (entry->handle == loc && !free) + if ((entry->handle == loc) && !free && !entry->is_frag) dup = entry; } -- 2.20.1