Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5226063ybl; Tue, 27 Aug 2019 01:06:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxZs3BKaLGMg4bfhCt7H7/sibhP67T0H/7hD5JwWdiG3RQcwOpdUidIZaS43yLHw5gVTLK1 X-Received: by 2002:a62:e910:: with SMTP id j16mr25425142pfh.123.1566893218524; Tue, 27 Aug 2019 01:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566893218; cv=none; d=google.com; s=arc-20160816; b=ZhT9Qn0ffzSZGFIVHC3k1/XorxTfsRWs4hzHTv1XhrJGnJzXjxLtgC6jwnhZKFvlAW j3eznPw3Bhq1u0VQugAk1GoBD1Z/nhFMBQ0nmW3j8L0MbzUV3CVo9KIz+u9VhxvCdKeo Of/SWwIXVM+igwpfoZMtrMyPIpPdcZvVcrpnq2XL/sLYOw6PACWTzRmBD/c2xQXSifFo wXamid4UDgWzy5U9+44s6FKg5pRjdNQWBdIsqrF/ij38OrEJ8mnbnw7kQ3gLDz+e4ry3 tq5EYiaQETe16Hdw3P23oQYZE8IjboAsscmypWllx+nY5w+lEZ6zv9lvO1aqU1BEwyse fX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FBwdOwjvOdjIhB2PSECBW1aFYTe7c4DsOp91oSE+OAw=; b=TXHYub3c8dcVV8uypHog70/0T3wFkXhrSnwjzjffBBPwonrwoXcm4vXOgfk9qtlaOV xzK15WMBG0CMvIcTfPlsHX/kqyGQBIRgP7hgGqwZrRMZNykOE22yCQenbrsZ/PW9CyVQ 7+2AQcvsEpfWbgtWtu6BVEHGPLuNNlMK6coLWiXVwFvaImmD8cKzIqvWZOs3WPnlS4iG GXauGN8kAfCgpHrlR9ICK5Df9PGh2Q1bLMV8nocjyXxoG2Rf/mgX4r6v06pHlufUAJWf BwRQagRQmGSl+PpmHahVrhTiUPB9ojehWYduQ6gtdfky3hZOqK47mYOeg/nz7xWDAocc GUgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="q/cgbezf"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si13288110pfb.230.2019.08.27.01.06.43; Tue, 27 Aug 2019 01:06:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="q/cgbezf"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732098AbfH0IEd (ORCPT + 99 others); Tue, 27 Aug 2019 04:04:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732582AbfH0IEa (ORCPT ); Tue, 27 Aug 2019 04:04:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E67F2173E; Tue, 27 Aug 2019 08:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566893069; bh=Rgc5XPUCe4JhID3HgAk8xc7xcB0L9xatm15Iygzvwq4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q/cgbezfDJyMOygshJS4ScdIanIJV2ZiylRJFMv1vu9YcgB9hNFZx81p1F19dBbdR flYAmmU9NnsKPc8vZtrPO9/OnMYZoCoSXcMpTwvgATITGYRdg2r7M4rskeq26Ip7kx sgJwT8alD/6JUeshYGSM5kIzVDpBXZh27wVhylO8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shahar S Matityahu , Luca Coelho , Johannes Berg , Sasha Levin Subject: [PATCH 5.2 058/162] iwlwifi: dbg_ini: move iwl_dbg_tlv_free outside of debugfs ifdef Date: Tue, 27 Aug 2019 09:49:46 +0200 Message-Id: <20190827072740.204400175@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072738.093683223@linuxfoundation.org> References: <20190827072738.093683223@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit abcbef5977df1fb61026ba429964cd6b9a085699 ] The driver should call iwl_dbg_tlv_free even if debugfs is not defined since ini mode does not depend on debugfs ifdef. Signed-off-by: Shahar S Matityahu Fixes: 68f6f492c4fa ("iwlwifi: trans: support loading ini TLVs from external file") Signed-off-by: Luca Coelho Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index efd4bf04d0162..fa81ad67539f3 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -1649,8 +1649,8 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans) err_fw: #ifdef CONFIG_IWLWIFI_DEBUGFS debugfs_remove_recursive(drv->dbgfs_drv); - iwl_fw_dbg_free(drv->trans); #endif + iwl_fw_dbg_free(drv->trans); kfree(drv); err: return ERR_PTR(ret); -- 2.20.1