Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: okybydZ720+8OTwnjqV7ZPqywGZbnhKb8NRjL2NRQMPXdMcSBwJyoLUqB8v5ZMm4sxpVvvlpFx
 hOfUACiyFH6O8EAks9bxBSd72rCqjZODFF3YyLrDtzw8xpU6sK0/ddpK0tVouK1qzwK+wUFswv
 WREYy70Tr7Zje/3PAirQo+ORfuq9/3sdwKmPQnDL827V2U2PKdGccPFHljqaNYJQ3/KJLfHNne
 VecGmHAFdce0jaVJgYrohFH6mGfaFeQ/MvvJmpf4N+hNp9bzPO+u/pLYrUfouBhpWUGb5kn1E7
 acs=
Subject: Re: [v4] rtc: pcf85363/pcf85263: fix error that failed to run hwclock
 -w
To:     Biwen Li <biwen.li@nxp.com>, a.zummo@towertech.it,
        alexandre.belloni@bootlin.com, leoyang.li@nxp.com,
        broonie@kernel.org
Cc:     linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190827043735.31231-1-biwen.li@nxp.com>
From:   Nandor Han <nandor.han@vaisala.com>
Message-ID: <2b49e282-fc03-ee59-2719-5a3c1ce573ce@vaisala.com>
Date:   Tue, 27 Aug 2019 11:07:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190827043735.31231-1-biwen.li@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/27/19 7:37 AM, Biwen Li wrote:
>   - In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS
>        is 0, max_regiter is 0x2f, then reg will be equal to 0x30,
>        '0x30 < 0x2f' is false,so regmap_writeable will return false.
> 
>      - The pcf85363/pcf85263 has the capability of address wrapping
>        which means if you access a continuous address range across a
>        certain boundary(max_register of struct regmap_config) the
>        hardware actually wraps the access to a lower address. But the
>        address violation check of regmap rejects such access.

nitpick: This 2 paragraphs could be combined to clear up the issue:

`
The pcf85363/pcf85263 has the capability of address wrapping
which means if you access an address outside the allowed range 
(0x00-0x2f) the hardware actually wraps the access to a lower address. 
The rtc-pf85363 driver will use this feature to configure the time and 
execute 2 actions in the same i2c write operation (stopping the clock 
and configure the time). However the driver has also configured the 
`regmap maxregister` protection mechanism that will block accessing 
addresses outside valid range (0x00-0x2f).
`

nitpick: I would also use separate buffers for this actions. Up to you :)

Otherwise LGTM +1

Nandor