Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5288316ybl; Tue, 27 Aug 2019 02:16:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqz80lSxQBldhmIx/ZdUfHk/0365V1HQSEpFrNMokx/KOG6gD+ka+bPX1psv/cw1R3emN0Pw X-Received: by 2002:a62:ce0e:: with SMTP id y14mr25215250pfg.73.1566897412906; Tue, 27 Aug 2019 02:16:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566897412; cv=none; d=google.com; s=arc-20160816; b=doaVz5tcDO2gEEK9aAmAkI5U0z8cYI36Hw8mNU/IV0DS0q4CQrpA0MeKhIBYEz8tOl l4LiVOHOj+RFueV8OcJIAC/pZ/katWMhEUADd39S3CIq0DXcAd10mI3GQuR8FNU5k2V2 7AWSTe3CrX2WA1Bm7giB+ivcNouw3uJ9EWN0/tRoEJ+bCrhDOqVvH7k0M83GUqzN+kS2 P3qG+2OPIAskSgmH2SnrLtK+jXTJ3aoF0TiNYb1a/CHgJgoHJYNsy+TG04UfiNBcmqBB /t92JogyLXbbkzbZOAjWdw1Eta0oY7hcE2ad/TrzW6lxLIhK+PA9traCA3gcJQkON/4W 0A+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=6XDQ+UwoYvg45NX+nRAidCQFHs6FRcprAKeGyuUDVYE=; b=nDQrB3U7+scEH+m3Dy8QllP3T8x6CqaU//QAYl3rsIDSgDhYzmL1hWYrRk8Lum+xaE LVWmpWigcZjedsP4jnzDlt6qz393J0Sj65ZEMKq0k7XJ3qeaC6xVlN7RyWtCJfIisKjA b0AE8F0pzWMT+bu4VgM8YJFz8iIgB4IKhDs+D0hJUoRiJxe4tMA0UOePbZPFMwE2kxzN L2sP4lKGZFyYx05F3grSBiAyQLk56K4LQUctQim4U5aErwUhoGgCijojUlRnEQ2dfRSi OeUssB2Sa8gOu3MP5v/Fkw+0nFQRoov8E1UspNf31Uez9VmN8gpLlmu1Rq59xNXni0nb K7Yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12si2029903pjr.58.2019.08.27.02.16.37; Tue, 27 Aug 2019 02:16:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729220AbfH0JOQ (ORCPT + 99 others); Tue, 27 Aug 2019 05:14:16 -0400 Received: from mga17.intel.com ([192.55.52.151]:32104 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbfH0JOQ (ORCPT ); Tue, 27 Aug 2019 05:14:16 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 02:14:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,436,1559545200"; d="scan'208";a="380850102" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 27 Aug 2019 02:14:15 -0700 Received: from [10.226.39.22] (ekotax-mobl.gar.corp.intel.com [10.226.39.22]) by linux.intel.com (Postfix) with ESMTP id 121F7580444; Tue, 27 Aug 2019 02:14:12 -0700 (PDT) Subject: Re: [PATCH v2 3/3] dwc: PCI: intel: Intel PCIe RC controller driver To: Martin Blumenstingl Cc: "Chuan Hua, Lei" , andriy.shevchenko@intel.com, cheol.yong.kim@intel.com, devicetree@vger.kernel.org, gustavo.pimentel@synopsys.com, hch@infradead.org, jingoohan1@gmail.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, qi-ming.wu@intel.com References: <9bd455a628d4699684c0f9d439b64af1535cccc6.1566208109.git.eswara.kota@linux.intel.com> <20190824210302.3187-1-martin.blumenstingl@googlemail.com> <2c71003f-06d1-9fe2-2176-94ac816b40e3@linux.intel.com> From: Dilip Kota Message-ID: Date: Tue, 27 Aug 2019 17:14:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/27/2019 4:14 AM, Martin Blumenstingl wrote: > second example: pcie-tegra194 (only in -next, will be part of v5.4) > struct tegra_pcie_dw { > ... > struct dw_pcie pci; > ... > }; > > so some drivers store a pointer pointer to the dw_pcie struct vs. > embedding the dw_pcie struct directly. > as far as I know the result will be equal, except that you don't have > to use a second devm_kzalloc for struct dw_pcie (and thus reducing > memory fragmentation). Okay, i will change it to "struct dw_pcie pci;" Thanks for the feedback. Regards, Dilip