Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     James Morse <james.morse@arm.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        Jason Baron <jbaron@akamai.com>,
        Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
        Tero Kristo <t-kristo@ti.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 06/24] EDAC: Kill EDAC_DIMM_PTR() macro
Thread-Topic: [PATCH v2 06/24] EDAC: Kill EDAC_DIMM_PTR() macro
Thread-Index: AQHVXNHCQNXmlYryY0S3iWFUnya/Og==
Date:   Tue, 27 Aug 2019 12:20:05 +0000
Message-ID: <20190827121956.6kitf62spfbi7pdk@rric.localdomain>
References: <20190624150758.6695-1-rrichter@marvell.com>
 <20190624150758.6695-7-rrichter@marvell.com> <20190813145947.GE16770@zn.tnic>
In-Reply-To: <20190813145947.GE16770@zn.tnic>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4e82e0ad-3873-42c0-2b62-08d72ae8e457
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2990;
x-ms-traffictypediagnostic: MN2PR18MB2990:
x-microsoft-antispam-prvs: <MN2PR18MB29908055C73840BF9BD14205D9A00@MN2PR18MB2990.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0142F22657
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(189003)(199004)(54906003)(1076003)(305945005)(476003)(6436002)(486006)(53546011)(316002)(5660300002)(66066001)(3846002)(26005)(386003)(4744005)(7736002)(14454004)(53936002)(6486002)(186003)(11346002)(446003)(52116002)(76176011)(102836004)(6116002)(9686003)(25786009)(86362001)(6512007)(478600001)(8936002)(256004)(71200400001)(8676002)(6246003)(81166006)(66556008)(2906002)(64756008)(66446008)(81156014)(229853002)(66946007)(66476007)(71190400001)(6506007)(4326008)(99286004)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2990;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: cgypWYzqBZBjsujBn5onJxXd4DAeFCa60PB6F2TDW4nakzw8SfEZbMa4ETxMFKD1kCHAhvw2EkrntoBdfKb0mNH66ajq0oQjSSXlfHls+R8zqLEopMyK+t7AsX/MahduGiDCYHsUK+bnD+J0cP+nYu1eeSZgSr4tqLQW1IdCLyH07ULDVgahOi3SRJXx5Yz6QtM+we0ojz6w5eWIhUG0gG/JpSCms5mtbVLz7nqyPiNi5mq20BB9fivLVGrYE6JfPt5EeeY1ZDD8Xf1ZqncaQ1jAAabfIY6tjtOUWGgO3PUpNfIDce8OQkXhPrFINZpIrMe9DLebvrF7oU+gPsupsXxrVd4gTHEGixdknq9NPXtTiLhv6np7prvBYeIf8Bu84jbSvMUNU1pURC3UMcUR5s71chJVBSiEfmsvOob9IuU=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D66A4FE408AD8348AE47360DB7CAB60D@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e82e0ad-3873-42c0-2b62-08d72ae8e457
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2019 12:20:05.2279
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GCHFqDYJfDrSLJ5FWo9IuZ2aCqF8GrZrTaAnZbBPJJS58ejTu5os633GzXzK+cXS3HtGFhPZz6PEVgBub8xwUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2990
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8
 definitions=2019-08-27_02:2019-08-27,2019-08-27 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13.08.19 16:59:47, Borislav Petkov wrote:
> > + *
> > + * For 2 layers, this macro is similar to allocate a bi-dimensional ar=
ray
> > + * and to return "dimms[layer0][layer1]";
> > + *
> > + * For 3 layers, this macro is similar to allocate a tri-dimensional a=
rray
> > + * and to return "dimms[layer0][layer1][layer2]";
> > + */
> > +static inline struct dimm_info *
> > +edac_get_dimm(struct mem_ctl_info *mci, int layer0, int layer1, int la=
yer2)
> > +{
> > +	int index =3D layer0;
> > +
> > +	if (index >=3D 0 && mci->n_layers > 1)
>=20
> Can layer0 be negative here to warrant that check?

Yes, if a mem controller can not determine a dimm's position, this
function can be called with layers set to -1.

I have reworked the patch according to all of your comments.

Thanks for review,

-Robert