Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Geert Uytterhoeven <geert@linux-m68k.org>
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <CAMuHMdUk9G22rDfUrX3CZ=st3_bSehyaW_URtCk0ZfJqFTmLuQ@mail.gmail.com>
Cc:     DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
References: <CAMuHMdUk9G22rDfUrX3CZ=st3_bSehyaW_URtCk0ZfJqFTmLuQ@mail.gmail.com>
Message-ID: <156690938679.15406.15977840485564172260@skylake-alporthouse-com>
User-Agent: alot/0.6
Subject: Re: dma-buf: Add selftests for dma-fence
Date:   Tue, 27 Aug 2019 13:36:26 +0100
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Geert Uytterhoeven (2019-08-27 13:30:04)
> Hi Chris,
> 
> When running the new dmabuf-selftests on two different systems, I get:
> 
>     dma-buf: Running sanitycheck
>     dma-buf: Running dma_fence
>     sizeof(dma_fence)=48
>     dma-buf: Running dma_fence/sanitycheck
>     dma-buf: Running dma_fence/test_signaling
>     dma-buf: Running dma_fence/test_add_callback
>     dma-buf: Running dma_fence/test_late_add_callback
>     dma-buf: Running dma_fence/test_rm_callback
>     dma-buf: Running dma_fence/test_late_rm_callback
>     dma-buf: Running dma_fence/test_status
>     dma-buf: Running dma_fence/test_error
>     dma-buf: Running dma_fence/test_wait
>     dma-buf: Running dma_fence/test_wait_timeout
>     dma-buf: Running dma_fence/test_stub
>     dma-buf: Running dma_fence/race_signal_callback
>     thread_signal_callback[0] completed 28855 passes, 3929 misses
>     thread_signal_callback[1] completed 28846 passes, 3918 misses
>     thread_signal_callback[0] completed 37179 passes, 37179 misses
>     thread_signal_callback[1] completed 37184 passes, 37183 misses
> 
> and
> 
>     dma-buf: Running sanitycheck
>     dma-buf: Running dma_fence
>     sizeof(dma_fence)=64
>     dma-buf: Running dma_fence/sanitycheck
>     dma-buf: Running dma_fence/test_signaling
>     dma-buf: Running dma_fence/test_add_callback
>     dma-buf: Running dma_fence/test_late_add_callback
>     dma-buf: Running dma_fence/test_rm_callback
>     dma-buf: Running dma_fence/test_late_rm_callback
>     dma-buf: Running dma_fence/test_status
>     dma-buf: Running dma_fence/test_error
>     dma-buf: Running dma_fence/test_wait
>     dma-buf: Running dma_fence/test_wait_timeout
>     dma-buf: Running dma_fence/test_stub
>     dma-buf: Running dma_fence/race_signal_callback
>     thread_signal_callback[0] completed 3423 passes, 2148 misses
>     thread_signal_callback[1] completed 2360 passes, 9 misses
>     thread_signal_callback[0] completed 4028 passes, 4028 misses
>     thread_signal_callback[1] completed 8080 passes, 8079 misses
> 
> Unfortunately it is not clear to me if this is good or bad?
> Perhaps the test output can be improved, e.g. with a clear PASS/FAIL output?

It's communicated via the error code, along with failure messages. For
more complex persistent selftest modules, we use an modparam to report
the error code.

See igt/dmabuf for the test runner.
-Chris