Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5517680ybl; Tue, 27 Aug 2019 06:01:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyD0qrMUBmiggJ9ABvRyuqxkyVp/f9w4KHaNZ3mpS3A85me8J3csADFOrBj98NEubGh7U0 X-Received: by 2002:a17:902:6f10:: with SMTP id w16mr22924222plk.143.1566910912330; Tue, 27 Aug 2019 06:01:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566910912; cv=none; d=google.com; s=arc-20160816; b=j4oUmaieqISFkj0vQu5xHBCvm8KlJ3+I3yoRpEiv++qhTftwnnUX8nJJ2R3cFyNzzj JwKxVhn5q+Gh6aH//GHLYJg3NP3eOyEZG6YwNx1aYdjvQF/YJsKdaFMvUJ14UYnR2Y+k QX0qDHOgg0stoiPjARb/AtpL2k/CvbiGorawsNxPerpIBZqI8kQFuapUvDAoqs5ilRQg N/ryLfqRpUbDaR2qHt2amMKFaZT0widKIncKL8Ii6JVbv/cJUJPoN54MaXbU2E9tJFk3 KLnx5U3seDR8cjnq6ydNyZnnZhBtVhEDc7zOMGCguOC2vXON3ax5LZ2SA4EwzHIySV05 kojA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id:date :subject:cc:to:from; bh=onqJZT6OsW2t9t5Ssloo6tMZqeB5ldKUqUbNc+5faHY=; b=KsjxGbyO4Cw2jLGWLZbI3o+2VkMTND6ntaLcvsAqrA/j3ojWEEc8wjHdmZatAsYvA6 hhnPkJbu/9JOx7UbMU2SpRXJM80iBOHmDjyPbgl9ZwdbDXj82EhBgg/CbC+J5oorvxY/ 8iicAmPw266rzrfvSyEYqrQbuTkCOn1+rlm219nI74X8KJH+BC3Pcxd+NHPgz5Fso7MV qXEaS+q8Ius3zefk9S+imZ3wAxuZz2IVhgE4FjCsWaIGWx3NxyxMYUi6R+3P6zXmXrhg bLpgWYLheOya+bn0FitjXgkWNPeXFsJEAn4OkZaKYlzHZTwX8fdb3/3eubU3Dc8Wni1b hkwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19si2657246pju.92.2019.08.27.06.01.35; Tue, 27 Aug 2019 06:01:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbfH0NAg (ORCPT + 99 others); Tue, 27 Aug 2019 09:00:36 -0400 Received: from mail.thorsis.com ([92.198.35.195]:43523 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfH0NAg (ORCPT ); Tue, 27 Aug 2019 09:00:36 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 558434ECF; Tue, 27 Aug 2019 15:01:41 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CrP9xAz6rOr8; Tue, 27 Aug 2019 15:01:41 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id B2509F0F; Tue, 27 Aug 2019 15:01:38 +0200 (CEST) X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from adahl by ada.ifak-system.com with local (Exim 4.89) (envelope-from ) id 1i2b5H-0007YO-6f; Tue, 27 Aug 2019 15:00:27 +0200 From: Alexander Dahl To: linux-leds@vger.kernel.org Cc: Jacek Anaszewski , Pavel Machek , Dan Murphy , linux-kernel@vger.kernel.org Subject: [PATCH] leds: syscon: Use resource managed variant of device register Date: Tue, 27 Aug 2019 15:00:27 +0200 Message-Id: <20190827130027.28998-1-ada@thorsis.com> Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We have a MFD driver compiled as module instantiating this driver. When unloading that module, those LED devices are not removed, which produces conflicts, when that module is inserted again. Signed-off-by: Alexander Dahl --- drivers/leds/leds-syscon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c index e35dff0050f0..b58f3cafe16f 100644 --- a/drivers/leds/leds-syscon.c +++ b/drivers/leds/leds-syscon.c @@ -115,7 +115,7 @@ static int syscon_led_probe(struct platform_device *pdev) } sled->cdev.brightness_set = syscon_led_set; - ret = led_classdev_register(dev, &sled->cdev); + ret = devm_led_classdev_register(dev, &sled->cdev); if (ret < 0) return ret; -- 2.20.1