Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5530722ybl; Tue, 27 Aug 2019 06:10:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzSBd/HMfxj2ZJoqMP1Y/tDIcXvjtWhou3ttqaiqpP6UCJUYeyuIdaCTclDRZdCoN/6924a X-Received: by 2002:a17:90a:a610:: with SMTP id c16mr24379148pjq.54.1566911453724; Tue, 27 Aug 2019 06:10:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566911453; cv=none; d=google.com; s=arc-20160816; b=IgViW6gT4qUfFV+pKEo4jHSL/SnzSvv77gTS9irFEWyWpJWLEZgbOtvI+TbO5C9sbz yaA3IuD+O/dKPjFrsGyCLuI3oBs9WOnhMyM6tKoN19Oj6RR+n5899+pEQwQAVl87FQIb 8g6z731zMIDnsNujQsQE0nErpug2zjXo7P92s1hnK2yry0Jx3thJLStYtX6KJkut6Fcy EF6jRfjoG4ZOknp1DEx7h2xRFDJvCk+SKZflX0L2Z9q41Q1s669vWmMTuSREwVkwACb4 uB5Hcj/sYur12J+otc1vgff3lRlEnWQ1NX/OxiVJGCzD4+iQBkNRGuCn5VZrOpxu0age HoBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=K8gVDlF2LI1nPXdpuNMID15knx51RKPP8sJqZbrsR+s=; b=XA+CrWoW5w2WuNY3Kn2E9GOsXHQ00ITFT02pz+7YbwwcBLHCuK3q4EGbtCyU29sjN0 cVS60czxxboxFJqfAW+lkt6+uihPO7RUx7c6EQrPOJTd7Z+McEqm4tTZrZdoPxCFodbH zguP4pQMFeRXKjBMoBI/15PJoMGhGCGlCQTIatRRM5lFjDmDXtQ87E/Gg0HXwGelRs7m fWQHnhWGBGGXjCvCETNXio/ekO02wTWLiQrmY02n3356FhPXcwkB94lq3GUZgbw9+HPd ggi1A8XTFznGEEvdr6q3wkLkHib4aOkJoa3rV8JHNgaVBsjBWSH/8eCNqSg8ULLDjT2g SNsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CVsC+VDz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p8si13574927pff.37.2019.08.27.06.10.38; Tue, 27 Aug 2019 06:10:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CVsC+VDz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729166AbfH0NIo (ORCPT + 99 others); Tue, 27 Aug 2019 09:08:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:39176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbfH0NIo (ORCPT ); Tue, 27 Aug 2019 09:08:44 -0400 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0E162077B; Tue, 27 Aug 2019 13:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566911322; bh=AX+JitzJv+K315th2SOy3YtH0VY/SuXeid3kXFuhBUE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CVsC+VDz2ihD4Mm+zIR+ySHxwO7R1ZjnAzMQBd0WbP8AxoP3TW692VdRMOtny23nQ i1IG4nuhZKuFC2N0Yzym8iHftvKzrHoYTuO/7QSdEcngeW+eCrW9qVfLHhEeritQHM 7AEWsOIy+0N/pS+Xu4XcFCkCig/nUYCXppx0/CfA= Received: by mail-qt1-f176.google.com with SMTP id v38so21203993qtb.0; Tue, 27 Aug 2019 06:08:42 -0700 (PDT) X-Gm-Message-State: APjAAAX5OSsNMdf6xww7g8TCrm+aF8ZUgNgNLKeo9N1sUzxwf1Mvs3DQ db+UJaFtptexgVQQN08a4YigpqhbCHa2XNg60g== X-Received: by 2002:ad4:4050:: with SMTP id r16mr20016450qvp.200.1566911321782; Tue, 27 Aug 2019 06:08:41 -0700 (PDT) MIME-Version: 1.0 References: <20190827085302.5197-1-jiaxun.yang@flygoat.com> <20190827085302.5197-6-jiaxun.yang@flygoat.com> In-Reply-To: <20190827085302.5197-6-jiaxun.yang@flygoat.com> From: Rob Herring Date: Tue, 27 Aug 2019 08:08:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/13] dt-bindings: interrupt-controller: Add Loongson-3 IOINTC To: Jiaxun Yang Cc: "open list:MIPS" , Huacai Chen , Paul Burton , Thomas Gleixner , Jason Cooper , Marc Zyngier , "linux-kernel@vger.kernel.org" , Mark Rutland , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 27, 2019 at 4:00 AM Jiaxun Yang wrote: > > Document Loongson-3 I/O Interrupt controller. > > Signed-off-by: Jiaxun Yang > --- > .../loongson,ls3-iointc.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-iointc.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-iointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-iointc.yaml > new file mode 100644 > index 000000000000..cc6ac8b2cd7c > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls3-iointc.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license please. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/interrupt-controller/loongson,ls3-iointc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Loongson-3 I/O Interrupt Controller > + > +maintainers: > + - Jiaxun Yang > + > +description: | > + This interrupt controller is found in the Loongson-3 family of chips as the primary > + package interrupt source which can route interrupt to interrupt line of cores. > + > +properties: > + compatible: > + items: > + - enum: > + - loongson,ls3-iointc Same comment here. > + > + reg: > + maxItems: 1 > + > + 'loongson,map-ip': > + description: > + The interrupt line it's going to map to. I don't understand. Needs a better description. > + allOf: You need to define the type here with a $ref. > + - maximum: 5 > + minimum: 0 > + > + 'loongson,map-core': > + description: > + The core it's going to map to. There's 1 interrupt ctrlr per core or what? > + allOf: > + - maximum: 5 > + minimum: 0 > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 2 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - '#interrupt-cells' Add a: additionalProperties: false > + > +examples: > + - | > + iointc: interrupt-controller@3ff01400 { > + compatible = "loongson,ls3-io-intc"; > + reg = <0x3ff01400 0x60>; > + interrupts = <2>; > + loongson,map-ip = <0>; > + loongson,map-core = <0>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > -- > 2.22.0 >