Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Parav Pandit <parav@mellanox.com>
To:     Parav Pandit <parav@mellanox.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        Jiri Pirko <jiri@mellanox.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH 0/4] Introduce variable length mdev alias
Thread-Topic: [PATCH 0/4] Introduce variable length mdev alias
Thread-Index: AQHVXE6oE0YRBz0PMky+S05YIDBwe6cO90Uw
Date:   Tue, 27 Aug 2019 13:11:17 +0000
Message-ID: <AM0PR05MB4866A24FF3D283F0F3CB3CDAD1A00@AM0PR05MB4866.eurprd05.prod.outlook.com>
References: <20190826204119.54386-1-parav@mellanox.com>
In-Reply-To: <20190826204119.54386-1-parav@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 46f87e37-894b-4515-4a6f-08d72af00c39
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2019 13:11:18.0793
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UW3nCzZU47FGjF3tDJ3S9ZfAUDKZshc9sz6bx+QM4SuVvsfUQumUsMDr39c/qx0URtgLO5NMXmBZZFfpMVgkrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alex, Cornelia,

> -----Original Message-----
> From: kvm-owner@vger.kernel.org <kvm-owner@vger.kernel.org> On Behalf
> Of Parav Pandit
> Sent: Tuesday, August 27, 2019 2:11 AM
> To: alex.williamson@redhat.com; Jiri Pirko <jiri@mellanox.com>;
> kwankhede@nvidia.com; cohuck@redhat.com; davem@davemloft.net
> Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; Parav Pandit <parav@mellanox.com>
> Subject: [PATCH 0/4] Introduce variable length mdev alias
>=20
> To have consistent naming for the netdevice of a mdev and to have consist=
ent
> naming of the devlink port [1] of a mdev, which is formed using
> phys_port_name of the devlink port, current UUID is not usable because UU=
ID
> is too long.
>=20
> UUID in string format is 36-characters long and in binary 128-bit.
> Both formats are not able to fit within 15 characters limit of netdev nam=
e.
>=20
> It is desired to have mdev device naming consistent using UUID.
> So that widely used user space framework such as ovs [2] can make use of
> mdev representor in similar way as PCIe SR-IOV VF and PF representors.
>=20
> Hence,
> (a) mdev alias is created which is derived using sha1 from the mdev name.
> (b) Vendor driver describes how long an alias should be for the child mde=
v
> created for a given parent.
> (c) Mdev aliases are unique at system level.
> (d) alias is created optionally whenever parent requested.
> This ensures that non networking mdev parents can function without alias
> creation overhead.
>=20
> This design is discussed at [3].
>=20
> An example systemd/udev extension will have,
>=20
> 1. netdev name created using mdev alias available in sysfs.
>=20
> mdev UUID=3D83b8f4f2-509f-382f-3c1e-e6bfe0fa1001
> mdev 12 character alias=3Dcd5b146a80a5
>=20
> netdev name of this mdev =3D enmcd5b146a80a5 Here en =3D Ethernet link m =
=3D
> mediated device
>=20
> 2. devlink port phys_port_name created using mdev alias.
> devlink phys_port_name=3Dpcd5b146a80a5
>=20
> This patchset enables mdev core to maintain unique alias for a mdev.
>=20
> Patch-1 Introduces mdev alias using sha1.
> Patch-2 Ensures that mdev alias is unique in a system.
> Patch-3 Exposes mdev alias in a sysfs hirerchy.
> Patch-4 Extends mtty driver to optionally provide alias generation.
> This also enables to test UUID based sha1 collision and trigger error han=
dling
> for duplicate sha1 results.
>=20
> In future when networking driver wants to use mdev alias, mdev_alias() AP=
I will
> be added to derive devlink port name.
>=20
Now that majority of above patches looks in shape and I addressed all comme=
nts,
In next v1 post, I was considering to include mdev_alias() and have example=
 use in mtty driver.

This way, subsequent series of mlx5_core who intents to use mdev_alias() AP=
I makes it easy to review and merge through Dave M, netdev tree.
Is that ok with you?