Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5629760ybl; Tue, 27 Aug 2019 07:31:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkOHKZgMkjjdqb9cpmnIXcpUpFudNv9druFMr43d/KQIy6X/ZwzmCXvQtJ1k/BzDfjyihv X-Received: by 2002:a17:90a:d149:: with SMTP id t9mr24713573pjw.58.1566916285772; Tue, 27 Aug 2019 07:31:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566916285; cv=none; d=google.com; s=arc-20160816; b=d8Ne9rgxu4LyjZwLd5vcF+97d/nOPaR+NpTclRzB9+0JzDehfVcTuWLsQWjYjmwF5z 4A7CtSr70iUWfZq+jsQo0RP6bpX+K3mVjdBAg9kV3rRpl6ALt0i911BBTVZ15Y+a/UMD e8VnOgLhxKhyeGyuKSJ/x7nfTX8jJ/DRW3W09Rcf+003oI93fYPAMJi1R9xQuxIVMV3w ZbEqWVZgFDQwzs907nitSugxM/SdxluKjlvxrHdVg4qmQ/P2Rxv2vaXGkJh/X7228u1E YMefOqTSVJ9ea83G6ggDzCKjdQKUVR/A6ebydFlls5jUy8TzX2Tk/lXeemm9kA6Bn7uk gqaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=fAszt+5YNKmhYycXT+sErnPlRq2TY2WUgQeqOG+UPow=; b=D9dN6jQyMN67bdZAJFY3kmY2S9eePFpjM5wqhTxHL1rfU6/luOg6EYNTBW4IpIpKxn aXDZ//LpnhMRFNO5zVmVw/Bv5tIV0tvAYNreq3mJRJ6YbuXAU8SsvSl1LE6Reo/2obNF +xiQJCrA4Qfr3BQWMqGeLLi0CqoRsBa+SInNvF+30wTP2+DMFQzIO3CjQuJRroV6nctl WJRu+IXHowN+6n3/SlcdjXZf5nGGxQVG6aTk8zbJjsD5L6UUn4LpSbKoalOcCg7s9xBK 2kcSnaJBs/O9ROz/Wpxd7zTeQJ18r1j5jC6feLpsTbUvsTWXD+FN4BYio+qh6oSOpcGf K6Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o191si13774430pfg.155.2019.08.27.07.31.08; Tue, 27 Aug 2019 07:31:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729512AbfH0O2j (ORCPT + 99 others); Tue, 27 Aug 2019 10:28:39 -0400 Received: from gloria.sntech.de ([185.11.138.130]:35112 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbfH0O2j (ORCPT ); Tue, 27 Aug 2019 10:28:39 -0400 Received: from c-73-71-116-68.hsd1.ca.comcast.net ([73.71.116.68] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2cSP-0002Ds-GB; Tue, 27 Aug 2019 16:28:25 +0200 From: Heiko Stuebner To: Elon Zhang Cc: mark.rutland@arm.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v1 1/1] ARM: dts: rockchip: set crypto default disabled on rk3288 Date: Tue, 27 Aug 2019 16:28:21 +0200 Message-ID: <4806912.UyKsYhR33o@phil> In-Reply-To: <20190827071439.14767-1-zhangzj@rock-chips.com> References: <20190827071439.14767-1-zhangzj@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Dienstag, 27. August 2019, 09:14:39 CEST schrieb Elon Zhang: > Not every board needs to enable crypto node, so the node should > be set default disabled in rk3288.dtsi and enabled in specific > board dts file. Can you give a bit more rationale here? There would need to be a very specific reason because of the following: The crypto module is not wired to some board-specific components, so its usability does not depend on the specific board at all. Instead every board can just use it out of the box and the devicetree is supposed to describe the hardware and is _not_ meant as a space for user configuration. So in fact the status property should probably go away completely from the crypto node, as it's usable out of the box in all cases. Heiko > Signed-off-by: Elon Zhang > --- > arch/arm/boot/dts/rk3288.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index cc893e154fe5..d509aa24177c 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -984,7 +984,7 @@ > clock-names = "aclk", "hclk", "sclk", "apb_pclk"; > resets = <&cru SRST_CRYPTO>; > reset-names = "crypto-rst"; > - status = "okay"; > + status = "disabled"; > }; > > iep_mmu: iommu@ff900800 { >