Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5781722ybl; Tue, 27 Aug 2019 09:33:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfr9QI8EyrSlbTdOG2NJA71ZmJFpmbOQwMxQnrT7iAJWNjZiAp4/9tr/fB7VBtY7aoHPqb X-Received: by 2002:aa7:8085:: with SMTP id v5mr25916443pff.165.1566923624727; Tue, 27 Aug 2019 09:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566923624; cv=none; d=google.com; s=arc-20160816; b=x/nOjcS+rZI3yk6NU30naEFpowzY79E6lmlj75qxbXChAItX5xFaP/gCmwhPjiU/mi EBmtK8jWW6G6RfPReAyl5V1FWOTRdbNjD/tGREMT85rSJlwD8wFnKYKDQzYXBGuEwxE0 BaxZUWlXzSvySLEz88EESry45lVzskTBQkVcNfUCZVgygZfbKEp+sChVwZKp3Bbbmq7k PZYaPX+maRU0eF3eo/QQeYGDJy004P0tyimiABC2ioSbN9PEpABltxJEdj2GrWJZGqMx TydOD/Xqi1U6KIvgi2hgKHD6xEbc/7PHH5utG5vct+uOPVD0vgDy2wYlnCBAxr/hFA8I hpSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=6mKapXsSsQuqXm7LiXF/fVsxdkZ84NHANg8ukku4bVs=; b=LGvcm53tWqK0oTdGBk++E1Vmkpe7F13gugxxpaLHVsFqIZFrlqpORz8oWvODCXgkBl Bj8CHbQ27a3lhdAAC8s16jm4j4DI/135IiUvU7g5z+gx+b7gA26zGJ0wyvAXlN1mrQPb pvSyxwT+QD2zNV6Rnnbc9th7dhuv9YpIhd2S80DXBJs53zpD9213Lh3eygVxYxA5iS39 OpzM1tPfE2K1UMF0YU8LHaLPC3GCHGCdkx7Fgg0cKa5JGR9tF2wvHYdTaeJj2mr/Q2z8 RvFwpqnr1rjTpPRjkqOQ6o0KeHIFujpyia0w2MoMMgOwS6acoeycNPIKZAWMhOxl2EUp gnjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ds19si3014546pjb.81.2019.08.27.09.33.28; Tue, 27 Aug 2019 09:33:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730302AbfH0Qcb (ORCPT + 99 others); Tue, 27 Aug 2019 12:32:31 -0400 Received: from foss.arm.com ([217.140.110.172]:47544 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727138AbfH0Qcb (ORCPT ); Tue, 27 Aug 2019 12:32:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CE42337; Tue, 27 Aug 2019 09:32:30 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 51CAB3F59C; Tue, 27 Aug 2019 09:32:29 -0700 (PDT) From: Will Deacon To: linux-kernel@vger.kernel.org Cc: Will Deacon , Kees Cook , Ingo Molnar , Elena Reshetova , Peter Zijlstra , Ard Biesheuvel , Hanjun Guo , Jan Glauber Subject: [PATCH v2 0/6] Rework REFCOUNT_FULL using atomic_fetch_* operations Date: Tue, 27 Aug 2019 17:31:58 +0100 Message-Id: <20190827163204.29903-1-will@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, This is version two of the patches I previously posted here: https://lkml.kernel.org/r/20190802101000.12958-1-will@kernel.org Changes since v1 include: * Avoid duplicate WARNs when incrementing from zero * Some crude lktdm perf results to motivate the change: # perf stat -r 3 -B -- echo {ATOMIC,REFCOUNT}_TIMING >/sys/kernel/debug/provoke-crash/DIRECT # arm64 ATOMIC_TIMING: 46.50451 +- 0.00134 seconds time elapsed ( +- 0.00% ) REFCOUNT_TIMING (REFCOUNT_FULL, mainline): 77.57522 +- 0.00982 seconds time elapsed ( +- 0.01% ) REFCOUNT_TIMING (REFCOUNT_FULL, this series): 48.7181 +- 0.0256 seconds time elapsed ( +- 0.05% ) # x86 ATOMIC_TIMING: 31.6225 +- 0.0776 seconds time elapsed ( +- 0.25% ) REFCOUNT_TIMING (!REFCOUNT_FULL, mainline/x86 asm): 31.6689 +- 0.0901 seconds time elapsed ( +- 0.28% ) REFCOUNT_TIMING (REFCOUNT_FULL, mainline): 53.203 +- 0.138 seconds time elapsed ( +- 0.26% ) REFCOUNT_TIMING (REFCOUNT_FULL, this series): 31.7408 +- 0.0486 seconds time elapsed ( +- 0.15% ) Cheers, Will Cc: Kees Cook Cc: Ingo Molnar Cc: Elena Reshetova Cc: Peter Zijlstra Cc: Ard Biesheuvel Cc: Hanjun Guo Cc: Jan Glauber --->8 Will Deacon (6): lib/refcount: Define constants for saturation and max refcount values lib/refcount: Ensure integer operands are treated as signed lib/refcount: Remove unused refcount_*_checked() variants lib/refcount: Move bulk of REFCOUNT_FULL implementation into header lib/refcount: Improve performance of generic REFCOUNT_FULL code lib/refcount: Consolidate REFCOUNT_{MAX,SATURATED} definitions drivers/misc/lkdtm/refcount.c | 8 -- include/linux/refcount.h | 236 +++++++++++++++++++++++++++++++++++++---- lib/refcount.c | 237 +----------------------------------------- 3 files changed, 218 insertions(+), 263 deletions(-) -- 2.11.0