Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5783506ybl; Tue, 27 Aug 2019 09:35:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJ/4Pde9lLT5xONpv2KByYIjMdTXAncfTx020Q3B7e+a6pjJF8Pn2fSIENYO/G9pv+5rso X-Received: by 2002:aa7:9a86:: with SMTP id w6mr13913553pfi.60.1566923704576; Tue, 27 Aug 2019 09:35:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566923704; cv=none; d=google.com; s=arc-20160816; b=XmCks6GaRaSguGm6Wlk9y++n8kB2HJSUjL0niRbYJZTFouJhabIAZ4Odlq+X2mGB3F XqDG1UcSusHftbhIk6STr88H/jsA1nlr0WArGd9jtbyzBnMtMIscV8qGt1mecjdDFCKZ sG3cOc5YE8428FLW0hyb/q+25yUXzCi7mPIxE4+KObCnppwdPVWItg7SFydUT8zvCCsu ca0P3+IYlyb1ajSoNL85aihlWcOpuCPbw0OAReOA7XmMgwdpeLjNEPubljgr1Bq2FJ9B jVyEx4FOVtKfQ99KSgSynx3sToSA0YTIoim02mMx2Lq3cDjYt/UmW1Qpq07MsuoYvsae 7uRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=/zg0bV3qxRrrZ8M4aU2pwZR/A1NqBI7vpxBYLuL1/5c=; b=eeBluuXBAlRJW7gy1THsqvX7dxRcU6G5btI8Jp4/XThYIRK6UxwDDMdWcvLNXhQaNG 4o0DBDVmN2v3q16WKBoy2JQ5Fc1Xkz93lX3QUv9IZQNgfN0WlFsFyGDPpF4sIB8COHnH M+Zfs7m5AqNqCuILw6R/Ui0mcMtMPjGF4Qa4io/LNTFyvEAuOg1MbxTfeIvHndcfKWK+ saFsR7l0uSdBIeHlu5ft6zsApIxTxQja39KCBD1GhnlVrIGH5kNdef9fvvNKcvSueinC oAXoregnLYAjdazkRiYAVSsw+p7hLGE3T53/YLzXk1/63422hwN4OXzubXbzuFfTP3/l FlkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k3si12764898pgs.223.2019.08.27.09.34.49; Tue, 27 Aug 2019 09:35:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730486AbfH0QdU (ORCPT + 99 others); Tue, 27 Aug 2019 12:33:20 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:43584 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730456AbfH0QdT (ORCPT ); Tue, 27 Aug 2019 12:33:19 -0400 Received: by mail-qk1-f194.google.com with SMTP id m2so17499736qkd.10; Tue, 27 Aug 2019 09:33:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/zg0bV3qxRrrZ8M4aU2pwZR/A1NqBI7vpxBYLuL1/5c=; b=j3Jiius+Z8WuK32G/Nqm5EWD7Hu04KbAui3teuc2W9F3B33LNQ3x0Qyq2DY4/aAxJz Rb8KSp090PhHShKf9HUSSgqHF8cQhqrKNcxhJhkicAWAvTn4CGUTHd/SDyCvu3PP27k4 m5kz6L0SbhFspLVvpbxjPU3hlesg67K4+c/az440bca6KKR1SI/e8Bw0Srt0CnNP8hn8 s5SjsSt+DFuP3fKKBiWejb+JQ08Sl9xtJUPkwcB33FN5zxHc1DcRwBQqGA5MVGg9K4ji OViPaEA5rlXsEo6qz8GdIBqHFwYnxJj3B+ZL6m6YVz5aOGunDS/5K7tpu3vdrLUzPtyl dX9g== X-Gm-Message-State: APjAAAWxCWbCu4BMq6/ZeT4KRa86f0V9+RyTA59el84cAJKtI+lM0A+W aHq507TKYmzcNN6ZKiAEn/a1+0dcKWPQnolv4Pw= X-Received: by 2002:a37:4b0d:: with SMTP id y13mr22291349qka.3.1566923597978; Tue, 27 Aug 2019 09:33:17 -0700 (PDT) MIME-Version: 1.0 References: <20190808212234.2213262-1-arnd@arndb.de> <20190808212234.2213262-15-arnd@arndb.de> <20190813103605.GL52127@atomide.com> <20190813181158.GA26798@darkstar.musicnaut.iki.fi> <20190814074918.GA52127@atomide.com> <20190816083403.GB1952@darkstar.musicnaut.iki.fi> In-Reply-To: <20190816083403.GB1952@darkstar.musicnaut.iki.fi> From: Arnd Bergmann Date: Tue, 27 Aug 2019 18:33:01 +0200 Message-ID: Subject: Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf To: Aaro Koskinen Cc: Tony Lindgren , Dominik Brodowski , linux-omap , Linux ARM , Greg Kroah-Hartman , Linus Walleij , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen wrote: > On Wed, Aug 14, 2019 at 12:36:40PM +0200, Arnd Bergmann wrote: > > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > > * Arnd Bergmann [190813 19:34]: > > > > -#define OMAP1_IO_OFFSET 0x01000000 /* Virtual IO > > > > = 0xfefb0000 */ > > > > +#define OMAP1_IO_OFFSET 0x00fb0000 /* Virtual IO > > > > = 0xff000000 */ > > > > #define OMAP1_IO_ADDRESS(pa) IOMEM((pa) - OMAP1_IO_OFFSET) > > > > > > Oh OK yeah sounds like that's the issue. > > > > > > > There may be additional locations that hardcode the virtual address. > > > > > > Those should be in mach-omap1/io.c, and I recall innovator had some > > > hardcoded fpga address that should also be checked. > > > > I see four boards with hardcoded I/O addresses, but they are all below > > the PCI I/O virtual address range, and are not affected by that change. > > > > For the innovator FPGA access, this was ok, it uses the correct address > > in the OMAP1_IO_OFFSET range. > > I tried testing this on OSK board. If I boot with earlyprintk disabled, > it boots OK and everything works (also CF card) with your playground > commit 5723b6686943. > > However with earlyprintk it seems to hang as soon as kernel tries to print > something. So something goes wrong with early DEBUG_LL mapping code when > CONFIG_DEBUG_UART_VIRT=0xff000000 is used? I just redid the calculation and came out with the same address, so I don't think I put the wrong one there. The address also does not conflict with the PCI mapping, and the address is the same one that is installed later, so that should also be fine. Are you sure you used the correct address in the .config file? If you ran 'make oldconfig', the virtual address would not be changed here as I just modify the default for a fresh 'make omap1_defconfig' run or similar. Arnd