Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5836822ybl; Tue, 27 Aug 2019 10:18:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZTfS8XQHDxxVSHnbWVOTjQjsTCY2cI7Ei56z/5mzXCUlq9ql6Pk5oG8OoI1XeoYpIG4QK X-Received: by 2002:aa7:8814:: with SMTP id c20mr27018954pfo.87.1566926291740; Tue, 27 Aug 2019 10:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566926291; cv=none; d=google.com; s=arc-20160816; b=QrC2/a6uDn5fSV9p0915HoQ4zi7B8dTJCk0I8hZGb0l9YAZILSm8l2TQ61tgLANfaB rNI9mZhg9ZP3TepMfFzincHVzaxCfKg0dWRhLtWUEIRyhz1NeeducSfqL7tmzDGIiE7l c5odlHLTH7qZ22lsjwVYpY18M1yaAwYEfDgv9dZS0AQCDogOy9lPadF0jg5rACgzBQUN uZS+4is6TwlSKiwWSOeGi61Sa/Mhhh6ciijkqTps23Rf3OH7bYlMkFVoRLjSuA1CX3jc I5RFY1uRCPI9/smkZUGqDoRliJONZrS+5LDt63nIEbZKDrUbFlaraq+mlQGknmnSV7os EWKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=vs/mNcRca3PPTydJTcBfDVCQEYs6M9UpUfQM0k+vOnM=; b=u+xAUBZwihbvtnc8Ax3n1pcAmvJqKu3GSOAE86svTsGyfwPKET7lUdDRHCiMdRdEQh frmR7xAXuk63Kt4jFDv2R5BghhSqcH81+nFo8G/oppXALaAVVW7hqxrhzHsqixIdoxKs FRhzagGzKMkr6zSlY6n/+jKJbPtUDZ1gT9d0F/ene/Ca/rCTDeIymMppDtJLvmRt6x42 smpArjLpBnMjM+z5ghWnhRh9sgb0BvgVoKphcnv2osFEQyDcTNKla1/7YjSsyJ8nWfvf lwEJ7AGRUuDSIkUt8WMCBk4Um3slfyoPSo5ZVys9QNkfcRElBcjJtnxcOyuGtuR8Mk9C ZSiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si7175814pfn.178.2019.08.27.10.17.55; Tue, 27 Aug 2019 10:18:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728711AbfH0RQz (ORCPT + 99 others); Tue, 27 Aug 2019 13:16:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:43168 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726871AbfH0RQz (ORCPT ); Tue, 27 Aug 2019 13:16:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9D6C2B0E5; Tue, 27 Aug 2019 17:16:53 +0000 (UTC) Subject: Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression To: "Chen, Rong A" , Feng Tang Cc: Stephen Rothwell , michel@daenzer.net, lkp@01.org, linux-kernel@vger.kernel.org, dri-devel References: <14fdaaed-51c8-b270-b46b-cba7b5c4ba52@suse.de> <20190805070200.GA91650@shbuild999.sh.intel.com> <045a23ab-78f7-f363-4a2e-bf24a7a2f79e@suse.de> <37ae41e4-455d-c18d-5c93-7df854abfef9@intel.com> <370747ca-4dc9-917b-096c-891dcc2aedf0@suse.de> <20190812072545.GA63191@shbuild999.sh.intel.com> <20190813093616.GA65475@shbuild999.sh.intel.com> <64d41701-55a4-e526-17ae-8936de4bc1ef@suse.de> <20190824051605.GA63850@shbuild999.sh.intel.com> <1b897bfe-fd40-3ae3-d867-424d1fc08c44@suse.de> From: Thomas Zimmermann Openpgp: preference=signencrypt Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNKFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmNvbT7CwJQEEwEIAD4W IQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznTtgIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRBoDcEdUwt6I7D7CACBK42XW+7mCiK8ioXMEy1NzGbXC51RzGea8N83oEJS 1KVUtQxrkDxgrW/WLSl/TfqHFsJpdEFOv1XubWbleun3uKPy0e5vZCd5UjZPkeNjnqfCYTDy hVVsdOuFbtWDppJyJrThLqr9AgSFmoCNNUt1SVpYEEOLNE6C32BhlnSq21VLC+YXTgO/ZHTa YXkq54hHj63jwrcjkBSCkXLh37kHeqnl++GHpN+3R+o3w2OpwHAlvVjdKPT27v1tVkiydsFG 65Vd0n3m/ft+IOrGgxQM1C20uqKvsZGB4r3OGR50ekAybO7sjEJJ1Obl4ge/6RRqcvKz4LMb tGs85D6tPIeFzsBNBFs50uABCADGJj+DP1fk+UWOWrf4O61HTbC4Vr9QD2K4fUUHnzg2B6zU R1BPXqLGG0+lzK8kfYU/F5RjmEcClsIkAaFkg4kzKP14tvY1J5+AV3yNqcdg018HNtiyrSwI E0Yz/qm1Ot2NMZ0DdvVBg22IMsiudQ1tx9CH9mtyTbIXgACvl3PW2o9CxiHPE/bohFhwZwh/ kXYYAE51lhinQ3oFEeQZA3w4OTvxSEspiQR8dg8qJJb+YOAc5IKk6sJmmM7JfFMWSr22satM 23oQ3WvJb4RV6HTRTAIEyyZS7g2DhiytgMG60t0qdABG5KXSQW+OKlZRpuWwKWaLh3if/p/u 69dvpanbABEBAAHCwHwEGAEIACYWIQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznS4AIbDAUJ A8JnAAAKCRBoDcEdUwt6I6X3CACJ8D+TpXBCqJE5xwog08+Dp8uBpx0T9n1wE0GQisZruACW NofYn8PTX9k4wmegDLwt7YQDdKxQ4+eTfZeLNQqWg6OCftH5Kx7sjWnJ09tOgniVdROzWJ7c VJ/i0okazncsJ+nq48UYvRGE1Swh3A4QRIyphWX4OADOBmTFl9ZYNPnh23eaC9WrNvFr7yP7 iGjMlfEW8l6Lda//EC5VpXVNza0xeae0zFNst2R9pn+bLkihwDLWxOIyifGRxTqNxoS4I1aw VhxPSVztPMSpIA/sOr/N/p6JrBLn+gui2K6mP7bGb8hF+szfArYqz3T1rv1VzUWAJf5Wre5U iNx9uqqx Message-ID: <44029e80-ba00-8246-dec0-fda122d53f5e@suse.de> Date: Tue, 27 Aug 2019 19:16:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PiZqvaSsIGil8LH5XMa8iEIZzqRe4iQ9m" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PiZqvaSsIGil8LH5XMa8iEIZzqRe4iQ9m Content-Type: multipart/mixed; boundary="7q5QRpbk3EyNCKh2h7zGunliu0JqIsLR3"; protected-headers="v1" From: Thomas Zimmermann To: "Chen, Rong A" , Feng Tang Cc: Stephen Rothwell , michel@daenzer.net, lkp@01.org, linux-kernel@vger.kernel.org, dri-devel Message-ID: <44029e80-ba00-8246-dec0-fda122d53f5e@suse.de> Subject: Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression References: <14fdaaed-51c8-b270-b46b-cba7b5c4ba52@suse.de> <20190805070200.GA91650@shbuild999.sh.intel.com> <045a23ab-78f7-f363-4a2e-bf24a7a2f79e@suse.de> <37ae41e4-455d-c18d-5c93-7df854abfef9@intel.com> <370747ca-4dc9-917b-096c-891dcc2aedf0@suse.de> <20190812072545.GA63191@shbuild999.sh.intel.com> <20190813093616.GA65475@shbuild999.sh.intel.com> <64d41701-55a4-e526-17ae-8936de4bc1ef@suse.de> <20190824051605.GA63850@shbuild999.sh.intel.com> <1b897bfe-fd40-3ae3-d867-424d1fc08c44@suse.de> In-Reply-To: --7q5QRpbk3EyNCKh2h7zGunliu0JqIsLR3 Content-Type: multipart/mixed; boundary="------------AFADC8A0B8B2B3C988012C4F" Content-Language: en-US This is a multi-part message in MIME format. --------------AFADC8A0B8B2B3C988012C4F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Am 27.08.19 um 14:33 schrieb Chen, Rong A: >=20 > Both patches have little impact on the performance from our side. Thanks for testing. Too bad they doesn't solve the issue. There's another patch attached. Could you please tests this as well? Thanks a lot! The patch comes from Daniel Vetter after discussing the problem on IRC. The idea of the patch is that the old mgag200 code might display much less frames that the generic code, because mgag200 only prints from non-atomic context. If we simulate this with the generic code, we should see roughly the original performance. Best regards Thomas >=20 > prefetch.patch: > commit: > =C2=A0 f1f8555dfb9 drm/bochs: Use shadow buffer for bochs framebuffer c= onsole > =C2=A0 90f479ae51a drm/mgag200: Replace struct mga_fbdev with generic > framebuffer emulation > =C2=A0 77459f56994 prefetch shadow buffer two lines ahead of blit offse= t >=20 > f1f8555dfb9a70a2=C2=A0 90f479ae51afa45efab97afdde 77459f56994ab87ee5459= 920b3=C2=A0 > testcase/testparams/testbox > ----------------=C2=A0 -------------------------- ---------------------= -----=C2=A0 > --------------------------- > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 %stddev=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 change=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 %s= tddev=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 change %stddev > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= \=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= \=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | \ > =C2=A0=C2=A0=C2=A0=C2=A0 42912=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -15%=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 36517=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -17= % 35515 > vm-scalability/performance-300s-8T-anon-cow-seq-hugetlb/lkp-knm01 > =C2=A0=C2=A0=C2=A0=C2=A0 42912=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -15%=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 36517=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -17= % 35515=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > GEO-MEAN vm-scalability.median >=20 > schedule.patch: > commit: > =C2=A0 f1f8555dfb9 drm/bochs: Use shadow buffer for bochs framebuffer c= onsole > =C2=A0 90f479ae51a drm/mgag200: Replace struct mga_fbdev with generic > framebuffer emulation > =C2=A0 ccc5f095c61 schedule dirty worker on local core >=20 > f1f8555dfb9a70a2=C2=A0 90f479ae51afa45efab97afdde ccc5f095c61ff6eded0f0= ab1b7=C2=A0 > testcase/testparams/testbox > ----------------=C2=A0 -------------------------- ---------------------= -----=C2=A0 > --------------------------- > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 %stddev=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 change=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 %s= tddev=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 change %stddev > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= \=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= \=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | \ > =C2=A0=C2=A0=C2=A0=C2=A0 42912=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -15%=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 36517=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -15= %=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 36556 =C2=B1=C2=A0 4% > vm-scalability/performance-300s-8T-anon-cow-seq-hugetlb/lkp-knm01 > =C2=A0=C2=A0=C2=A0=C2=A0 42912=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -15%=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 36517=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -15= % 36556=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > GEO-MEAN vm-scalability.median >=20 > Best Regards, > Rong Chen > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --------------AFADC8A0B8B2B3C988012C4F Content-Type: text/x-patch; name="usecansleep.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="usecansleep.patch" =46rom e6e72031e85e1ad4cbd38fb47f899bab54bf6bdc Mon Sep 17 00:00:00 2001 From: Thomas Zimmermann Date: Tue, 27 Aug 2019 19:00:41 +0200 Subject: only schedule worker from non-atomic context --- drivers/gpu/drm/drm_fb_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_hel= per.c index a7ba5b4902d6..3a3e4784eb28 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -642,7 +642,8 @@ static void drm_fb_helper_dirty(struct fb_info *info,= u32 x, u32 y, clip->y2 =3D max_t(u32, clip->y2, y + height); spin_unlock_irqrestore(&helper->dirty_lock, flags); =20 - schedule_work(&helper->dirty_work); + if (drm_can_sleep()) + schedule_work(&helper->dirty_work); } =20 /** --=20 2.22.0 --------------AFADC8A0B8B2B3C988012C4F-- --7q5QRpbk3EyNCKh2h7zGunliu0JqIsLR3-- --PiZqvaSsIGil8LH5XMa8iEIZzqRe4iQ9m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl1lZYMACgkQaA3BHVML eiNuiwgAq02jYOw13kGlCdrppugX43S5PhKzhckx0lBwzqFYUncqRp1Pw6BG7S+G SQ9ZEWXpxR3uW3uuEzLaVTj9SPO556VYlUz6qentuOnFzt//VSLnz2pcOqv59s5H sZ7hyNsKGWgrxFShIH5rhPazerYh5m9RgHgFTeQrC4VckO7xtoDJx/lkPG8LWDeK nhlKiWO71I6+FAFZ3x1CsB2IBqtsCfd0rLWTt+srIBIUbF0ZdiZM6brn6ex9TeTX ECqMnrnSwgnzXWgDCn6UkjjBEXYITv3mqTTUokKKm8M7hB1icHH6aYyQYAuJqdXt b0eigF+kRXxhIf7dgNvEh/TCRYcAdg== =Yj8f -----END PGP SIGNATURE----- --PiZqvaSsIGil8LH5XMa8iEIZzqRe4iQ9m--