Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <77c43754ff72e9a2e8048ccd032351cf0186080a.camel@linux.ibm.com>
Subject: Re: [PATCH v2 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if
 IPv6 is disabled on boot
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Pablo Neira Ayuso <pablo@netfilter.org>
Cc:     netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Date:   Tue, 27 Aug 2019 14:34:14 -0300
In-Reply-To: <20190827103541.vzwqwg4jlbuzajxu@salvia>
References: <20190821141505.2394-1-leonardo@linux.ibm.com>
         <20190827103541.vzwqwg4jlbuzajxu@salvia>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-cNCIg1ywiNXBjGc4Cw+F"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-cNCIg1ywiNXBjGc4Cw+F
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2019-08-27 at 12:35 +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 21, 2019 at 11:15:06AM -0300, Leonardo Bras wrote:
> > If IPv6 is disabled on boot (ipv6.disable=3D1), but nft_fib_inet ends u=
p
> > dealing with a IPv6 package, it causes a kernel panic in
> > fib6_node_lookup_1(), crashing in bad_page_fault.
>=20
> Q: How do you get to see IPv6 packets if IPv6 module is disable?
I could reproduce this bug on a host ('ipv6.disable=3D1') starting a
guest with a virtio-net interface with 'filterref' over a virtual
bridge. It crashes the host during guest boot (just before login).

By that I could understand that a guest IPv6 network traffic (viavirtio-net=
) may cause this kernel panic.=20

>=20
> > The panic is caused by trying to deference a very low address (0x38
> > in ppc64le), due to ipv6.fib6_main_tbl =3D NULL.
> > BUG: Kernel NULL pointer dereference at 0x00000038
> >=20
> > Fix this behavior by dropping IPv6 packages if !ipv6_mod_enabled().
>=20
> I'd suggest: s/package/packet/
Sure, I will make sure to put it on v3.
(Sorry, I am not very used to net subsystem.)
>=20
> [...]
> > diff --git a/net/ipv6/netfilter/nft_fib_ipv6.c b/net/ipv6/netfilter/nft=
_fib_ipv6.c
> > index 7ece86afd079..75acc417e2ff 100644
> > --- a/net/ipv6/netfilter/nft_fib_ipv6.c
> > +++ b/net/ipv6/netfilter/nft_fib_ipv6.c
> > @@ -125,6 +125,11 @@ void nft_fib6_eval_type(const struct nft_expr *exp=
r, struct nft_regs *regs,
> >  	u32 *dest =3D &regs->data[priv->dreg];
> >  	struct ipv6hdr *iph, _iph;
> > =20
> > +	if (!ipv6_mod_enabled()) {
> > +		regs->verdict.code =3D NF_DROP;
>=20
> NFT_BREAK instead to stop evaluating this rule, this results in a
> mismatch, so you let the user decide what to do with packets that do
> not match your policy.
Ok, I will replace for v3.

>=20
> The drop case at the bottom of the fib eval function never actually
> never happens.
Which one do you mean?


--=-cNCIg1ywiNXBjGc4Cw+F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl1laZYACgkQlQYWtz9S
ttQGCRAAhnjh/QWbYyASq5WgwLCyx11sioZdz7iKVUMRTLuMWnyyZbPBOdc7kAw+
TMDxCvi/O+caKgzOoW2ya3bqtHyI8lSEdbjrxfNBn6+AoxhXKBHBdHKrR6zUYE8J
+rM5AHcg2WZU58uyln0XdiXEmEeZEEq80AhKyYtZRpg8mGoMMo3fMo6zNGVfloBH
FmGGaohtVXS7BBuTTWZwXIR8fuYtAZKlSyxHrazZksz4PkZAsZWckpfTluy55vzS
kJBqfG91rkAkaUpuyrVv0hRYQNqWrFP441yutxOX6eWLYusxwHLzZWq1hlVYluiB
1UCUhIw1WWGP583Iz8YHJ993QRtbwJVDibmXUM39Cg3+kfh9h+vY8sGi96bGRn0h
NQDxUIXkGXBrAJQPON75Z0igM16rivks3AhHkL8M1HKMWDYJpEHaornjSLYpt0l5
Yngy+xTXDUdWH0dgoTweWkHIGL+mJ1g5FrJoSFP0pA/kZ17b/X7cRrnUV6E6jUnj
t6bKHLzY6JvCsiQLo/i9QNp6Eg4Y/cLk5AwRCotJcTupTL65Tp34r6fK0vBDVVoR
OTqV3jNinxK7BmHW8jGkXxdYJg0T3HcWg6FCqaTnmD9eruGTReSPxUF02QAe+3gk
iY67EsxcWu6ThPhqePMtyssRz8YOQeXBe0kUjRNKw0pCCFdomlQ=
=26Ah
-----END PGP SIGNATURE-----

--=-cNCIg1ywiNXBjGc4Cw+F--