Date: Mon, 19 Dec 2005 17:43:19 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
       Andrew Morton <akpm@osdl.org>, Arjan van de Ven <arjanv@infradead.org>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Christoph Hellwig <hch@infradead.org>, Andi Kleen <ak@suse.de>,
       David Howells <dhowells@redhat.com>,
       Alexander Viro <viro@ftp.linux.org.uk>, Oleg Nesterov <oleg@tv-sign.ru>,
       Paul Jackson <pj@sgi.com>
Subject: Re: [patch 05/15] Generic Mutex Subsystem, mutex-core.patch
Message-ID: <20051219164319.GH8160@elte.hu>
References: <20051219013718.GA28038@elte.hu> <1134969166.13138.240.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1134969166.13138.240.camel@localhost.localdomain>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 688
Lines: 23


* Steven Rostedt <rostedt@goodmis.org> wrote:

> The unlikely below is only for the non MUTEX_LOCKLESS_FASTPATH case.
> Maybe have a define for the unlikely?
> 
> #ifdef MUTEX_LOCKLESS_FASTPATH
> #  define UNLIKELY_SLOW(x) x
> #else
> #  define UNLIKELY_SLOW(x) unlikely(x)
> #endif

> > +       if (unlikely(!list_empty(&lock->wait_list)))
> > +               __mutex_wakeup_waiter(lock __IP__);

i'll rather eliminate the unlikely().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/