Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5901270ybl; Tue, 27 Aug 2019 11:16:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHbIuQRkr9QneogNKHoZkbnx8hcoU1W3Bf+LhiAhCxWIRByS01/msMX0QCfQ/zgFrpNV9O X-Received: by 2002:a63:9245:: with SMTP id s5mr22922597pgn.123.1566929779914; Tue, 27 Aug 2019 11:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566929779; cv=none; d=google.com; s=arc-20160816; b=oEVwpB/0xjXDGHkV8WoGhlu4kBdGPtepl1fxbelzR7WVzMmhGO7ZW+7DDAulXoJLkw LQ222vYjkxUtX+gKdjtTG8DXwqjPTX3qUBLrGsxvh/JrZBeW99IxnoTR6rTX+P5H94kq qn2inq+Ac9uWewrZy2gBFGo30fTArjIQhREKjyNCER+tRtXqPeUVz0Xn8ckYhyaAn6iw F0LVELwzNIoxF3ssknPnHwUWEwDAdpdBPg1OQfR8RFHkWPuH1ixMJi95nvBWWoxSqEUF +XJ089emIju98Y7UVpQLExfc+vhiZcBRNMN7T6+0H9c8PFP/Z6u0n5VskcPpXfeiFAXr WZ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2y3PI94wDTvqtkNgCzb6417/6RplmfaORLvY3696Obk=; b=UGiD4KD7SIShgGS3Dxd7jH39cy43X1PdXaegVmpnA04/2PPRNspIQ7lCc02+eTDq4v MUeQu93T0rKt9QD0mweAyB9aHu6/Uz78D8Ksdd1y9c3aCXa64Q4IKY/c/yu7LPsnKeku ZPXphMq/MM59XGnIUoDmwzsRhRf1Vxea0IA3EJT8je1gigjSVwpEZQhkpDYzelHB0JAe g+pBkTHJzWtLPNzt+pxXZJd8cB4/CbRBJcUgSQv2bEWKtB/vtkWaUZehCpGs3mtu6V3z wlRd+zu7yXHj143loOlOJ1Hg/71yyjwhksZCCJu8tRBQ9DAe9dC/BBgccGqwtSEuAxSD N3iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si66595pjs.72.2019.08.27.11.16.02; Tue, 27 Aug 2019 11:16:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730376AbfH0SPD (ORCPT + 99 others); Tue, 27 Aug 2019 14:15:03 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:39296 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727893AbfH0SPD (ORCPT ); Tue, 27 Aug 2019 14:15:03 -0400 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23992798AbfH0SPAV-MII (ORCPT + 2 others); Tue, 27 Aug 2019 20:15:00 +0200 Date: Tue, 27 Aug 2019 20:14:57 +0200 From: Ladislav Michl To: Tony Lindgren Cc: Markus Elfring , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kishore Kadiyala , Russell King , LKML , kernel-janitors@vger.kernel.org, Balaji T K , Benoit Cousson , Paul Walmsley , Nikolaus Schaller Subject: Re: [PATCH] ARM: OMAP2+: Delete an unnecessary kfree() call in omap_hsmmc_pdata_init() Message-ID: <20190827181457.GA16333@lenoch> References: <69025c8c-8d84-6686-138b-cde59467b802@web.de> <20190826162050.GX52127@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190826162050.GX52127@atomide.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 26, 2019 at 09:20:50AM -0700, Tony Lindgren wrote: > * Markus Elfring [190826 06:31]: > > From: Markus Elfring > > Date: Mon, 26 Aug 2019 15:05:31 +0200 > > > > A null pointer would be passed to a call of the function "kfree" directly > > after a call of the function "kzalloc" failed at one place. > > Remove this superfluous function call. > > > > This issue was detected by using the Coccinelle software. > > Applying into omap-for-v5.4/soc thanks. Is it really wise touching almost dead code? Last user is pandora board, so +Cc: Nikolaus Schaller