Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp6008433ybl; Tue, 27 Aug 2019 13:01:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqygXDs6RQwAZw4XhVd5XMvGkCvq5UNmoz3B3/X8eCWVUYTLte6LWB6AvvELy+biO5vylBtY X-Received: by 2002:a17:902:e493:: with SMTP id cj19mr617760plb.292.1566936081395; Tue, 27 Aug 2019 13:01:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566936081; cv=none; d=google.com; s=arc-20160816; b=hK6mIuRboa2D8xnQiB9zVX8/uQVVQDEt2XuD5+qsyR+uBdSC38Y8VHV2MYbpJFIG8R 9MdvU2yfOYrvHPd7/KUb8TtOUGArzFfuXnFnbCtD+3ety5ZXKi+/iiEztnwrgOvAL9WQ hdFvtXW7nPydNPuvp4JItuT/K372yYcdOQDeUMFlu0XkFwoGVSaf1lWGC2k6Fm3wB7hV aAXmIeQn+Nbr6+kwlrpckHUHDJOoQgJif+YB+QPs2JHYokP/GhPy9ZXbnsIG6X9fxnyw iWe+yIJtsn993WaKZGyDMHTUploJLG/NRAyuIsc35X2WFtsJlYoNXpXwHiqpEymFadKS X8Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=/qq4Y8bgfDjBd2xqdj5sv4QiznVJqZN+/Lozc9RwR5E=; b=YNQcqyZk8Du2S7Ix4NoQWKULb2BcT+0sutW07paijU/kd6vkmxqO+H2cmGfJQ0JJrn pyN46nRip1iBPrG34I5B0x+XEe1m9hpa743uuwBtmdwaXw9GyVxOktLbf36BiS2ecPSZ 9uGSoqqNy6KcXR4H5B31u6SiY9fdRsJHWS2FbU4neySoyQINU/iBM2G+EvdVHtNAnFyd vYHL5ziG+GCu98ZcVF1fHKMVWNkwDLdbgOSn0s/us8Jm5hCmjW2Ak9hEbWQaGSV6QsI/ OGJhF6vyf+uzfnfJnoRFxxUZqgY75psuaou0gEO3tThvnmGI47p5PAScFBwqmOaYGlmb oLhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Gi5oISGC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c73si150848pfc.228.2019.08.27.13.01.04; Tue, 27 Aug 2019 13:01:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Gi5oISGC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731341AbfH0T61 (ORCPT + 99 others); Tue, 27 Aug 2019 15:58:27 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48464 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729626AbfH0T61 (ORCPT ); Tue, 27 Aug 2019 15:58:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=/qq4Y8bgfDjBd2xqdj5sv4QiznVJqZN+/Lozc9RwR5E=; b=Gi5oISGCh/oI GprUbjlaXZCFLLFg3JuKxdywxtf2lz0E+PAPGdj5+XYYsGcpby6yklfPwo+7FTKup4v5Frq+F3amv NvaHu33EeoBiAqGJ8GJabWTQ9GReaFRnEArhUucuNK687AWeHqjjAjwbzOmWMex6I2nOgoLYDxOHn QJnoY=; Received: from 188.28.18.107.threembb.co.uk ([188.28.18.107] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i2hbY-0001CW-U0; Tue, 27 Aug 2019 19:58:13 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 6AED8D02CEA; Tue, 27 Aug 2019 20:58:10 +0100 (BST) From: Mark Brown To: Wei Yongjun Cc: alsa-devel@alsa-project.org, Daniel Baluta , Jaroslav Kysela , kernel-janitors@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Brown , Pengutronix@sirena.org.uk, Sascha Hauer , Shawn Guo , Takashi Iwai Subject: Applied "ASoC: SOF: imx8: Fix return value check in imx8_probe()" to the asoc tree In-Reply-To: <20190826120003.183279-1-weiyongjun1@huawei.com> X-Patchwork-Hint: ignore Message-Id: <20190827195810.6AED8D02CEA@fitzroy.sirena.org.uk> Date: Tue, 27 Aug 2019 20:58:10 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: SOF: imx8: Fix return value check in imx8_probe() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 393151c211006cc5ac6af26ecd9982dd916a8104 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Mon, 26 Aug 2019 12:00:03 +0000 Subject: [PATCH] ASoC: SOF: imx8: Fix return value check in imx8_probe() In case of error, the function devm_ioremap_wc() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support") Signed-off-by: Wei Yongjun Reviewed-by: Daniel Baluta Link: https://lore.kernel.org/r/20190826120003.183279-1-weiyongjun1@huawei.com Signed-off-by: Mark Brown --- sound/soc/sof/imx/imx8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c index 640472491037..c9d849ced54a 100644 --- a/sound/soc/sof/imx/imx8.c +++ b/sound/soc/sof/imx/imx8.c @@ -296,10 +296,10 @@ static int imx8_probe(struct snd_sof_dev *sdev) sdev->bar[SOF_FW_BLK_TYPE_SRAM] = devm_ioremap_wc(sdev->dev, res.start, res.end - res.start + 1); - if (IS_ERR(sdev->bar[SOF_FW_BLK_TYPE_SRAM])) { + if (!sdev->bar[SOF_FW_BLK_TYPE_SRAM]) { dev_err(sdev->dev, "failed to ioremap mem 0x%x size 0x%x\n", base, size); - ret = PTR_ERR(sdev->bar[SOF_FW_BLK_TYPE_SRAM]); + ret = -ENOMEM; goto exit_pdev_unregister; } sdev->mailbox_bar = SOF_FW_BLK_TYPE_SRAM; -- 2.20.1