Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa2.microchip.iphmx.com: domain of
  Tristram.Ha@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com;
  envelope-from="Tristram.Ha@microchip.com";
  x-sender="Tristram.Ha@microchip.com"; x-conformance=spf_only;
  x-record-type="v=spf1"; x-record-text="v=spf1 mx
  a:ushub1.microchip.com a:smtpout.microchip.com
  a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com
  include:servers.mcsv.net include:mktomail.com
  include:spf.protection.outlook.com ~all"
Received-SPF: None (esa2.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa2.microchip.iphmx.com;
  envelope-from="Tristram.Ha@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: zpWlrr/LAzjO4unoCeeA9rptwCvcMKkjSSBUOju6ttgwYCRfnLiLFLI0qWMTW2QsVcxhrw35bH
 G9IzKMa8Q2otw5X+oU/vrIv7tOhn2vvhdScFVdhWJmyqdJZuZVC2h6ivS5cernHofc1CxXq7lw
 URCckNHLebi0VfYZY3qMvk2/FJYJ9+/unNv0H+OEsOn+s9uz1WfCFFwpLgaSZESJa1HtQUR6HW
 oPRxnCViWHcUvhUl8zsutXksUE7WymR36lDoW05dPij5rfJAQuKj2i5vXbrBpweSo4fEWXIVDY
 qio=
From:   <Tristram.Ha@microchip.com>
To:     <Razvan.Stefanescu@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <Razvan.Stefanescu@microchip.com>, <Woojung.Huh@microchip.com>,
        <vivien.didelot@gmail.com>, <UNGLinuxDriver@microchip.com>,
        <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>
Subject: RE: [PATCH 4/4] net: dsa: microchip: avoid hard-codded port count
Thread-Topic: [PATCH 4/4] net: dsa: microchip: avoid hard-codded port count
Thread-Index: AQHVXLpYAiqtkBHu40WEfk7DWY00bqcPeo1g
Date:   Tue, 27 Aug 2019 21:03:27 +0000
Message-ID: <MN2PR11MB3678CF331310105FA5916A56ECA00@MN2PR11MB3678.namprd11.prod.outlook.com>
References: <20190827093110.14957-1-razvan.stefanescu@microchip.com>
 <20190827093110.14957-5-razvan.stefanescu@microchip.com>
In-Reply-To: <20190827093110.14957-5-razvan.stefanescu@microchip.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 41ee7c34-dac7-4e8d-0cee-08d72b3201f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2019 21:03:27.5905
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EZ/TbV/i6YZfY+ZV8LQBhMHlE1w7qgPc5gNCBAe47gpT0Q/+w/ZVe0jCooE6nWvKZNKJlZdYUUzFzLqbCE0ZsPEsxB2+T5NNb9LorW9m1eE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4271
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 4/4] net: dsa: microchip: avoid hard-codded port count
>=20
> Use port_cnt value to disable interrupts on switch reset.
>=20
> Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com>
> ---
>  drivers/net/dsa/microchip/ksz9477.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/dsa/microchip/ksz9477.c
> b/drivers/net/dsa/microchip/ksz9477.c
> index 187be42de5f1..54fc05595d48 100644
> --- a/drivers/net/dsa/microchip/ksz9477.c
> +++ b/drivers/net/dsa/microchip/ksz9477.c
> @@ -213,7 +213,7 @@ static int ksz9477_reset_switch(struct ksz_device
> *dev)
>=20
>  	/* disable interrupts */
>  	ksz_write32(dev, REG_SW_INT_MASK__4, SWITCH_INT_MASK);
> -	ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F);
> +	ksz_write32(dev, REG_SW_PORT_INT_MASK__4, dev->port_cnt);
>  	ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32);
>=20
>  	/* set broadcast storm protection 10% rate */

The register value is a portmap, so using port_cnt may be wrong.

The chip is a 7-port switch.  There is a 6-port variant, but it is okay to =
write 0x7F.

There is also a 3-port variant which uses a different design.  It is a bit =
of stretch to use 0x7F on it.

It is more a code readability or correctness than incorrect hardware operat=
ion.