Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp48114ybl; Tue, 27 Aug 2019 15:34:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqycvGe9zZQ7aiLta+62r6/PIQu1GMsAm6QniOFT1ENTpdrnyYMa2lIAVKQzeMn4hRYSfrXr X-Received: by 2002:a63:d210:: with SMTP id a16mr675015pgg.77.1566945248607; Tue, 27 Aug 2019 15:34:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566945248; cv=none; d=google.com; s=arc-20160816; b=V2yt73ylqBUnA0Ho6qMAnQ0KHsKxYu/M/9dVC5xPSFcSJAGW9OuhdXL5FqZ/0g6bHd 9N4fINePpmhSLVIvjBocSyS6LtPIlp3z1htNpuOcy8BCA54As+3uxRJGJzmfZ0ExIRdw 5KFKMBAuVRvdVaDKVWC24zcSZawgzb9yE6UWloBXQlWg/ieD0mGgdgV2fmNpP+ck9dbO AuiY9xSHt4yFnQbHm4Hh1dT0lwg1NBXu3apqesUZ8Iq9M5/vLik3fbsp6lYVndV7U75k hhjkx5PYazOqrmnORyiwdyohYyhrIDz+L5URfO0nZpIKxDQbr5UdEMkvPqhXGKkBTDw0 vQKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QKsCTljOqs7nsSso98gRzgi3GBXaradXx02XiTOTxVE=; b=RUAk1YwPd525LCBsS0HEgciojaxfM1ZBChB4n8FSAQubMK3OLQefzPHl7q5Sj/Zqpi PwB+MzAqzxxN0oPp57x0BVqv8QwVCQ4RNt1+oVdOCinr5pLcQdMdaz8zwZuD/urp78iQ 08A0Psg0GXfIyjt3Td7pnhdoqv10cGT/Td0Xo9ObX4B4NDxfQGyFOngXo9H1WFaFWSAN fxCmygSmi/uuTuVL//eXpGIR2nJ42NJ9Y4J5L+NaGXfdR9meVgQycxckG91aTwd+3jaR SWNKAKkI6TB2P3ID0z2QcxwF4hKIeXCQ3XwlAzC5JB7JB2TjDtwp7ALZE9oiHAlsa7tl 4+KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iZn1gGeI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9si539983pgb.478.2019.08.27.15.33.48; Tue, 27 Aug 2019 15:34:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iZn1gGeI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbfH0Wc7 (ORCPT + 99 others); Tue, 27 Aug 2019 18:32:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:59908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfH0Wc5 (ORCPT ); Tue, 27 Aug 2019 18:32:57 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D726120856; Tue, 27 Aug 2019 22:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566945176; bh=1+QNJKUgz+gea1zCCXAK/Hc/T4SGAhK43TGzjR48Lmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iZn1gGeISV7sMLyJAWPA3zeSgGFzMulVtOlCichsCyw2q3fdgawfyEsHjr4KL65bz wCm7gNW2nm5lFa3R90WX//Grb6qYufDlmR7iFbjWqtbOy7Cpn7x3nErLKRZxDcbq/o yCwTXt4Awd8wYq48Pu5CdmDCAOnwdhW8w0TQDmvc= Date: Tue, 27 Aug 2019 17:32:54 -0500 From: Bjorn Helgaas To: Denis Efremov Cc: Lukas Wunner , sathyanarayanan kuppuswamy , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] Simplify PCIe hotplug indicator control Message-ID: <20190827223254.GC9987@google.com> References: <20190819160643.27998-1-efremov@linux.com> <2f4c857e-a7cc-58da-8be5-cba581c56d9f@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f4c857e-a7cc-58da-8be5-cba581c56d9f@linux.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 20, 2019 at 03:16:43PM +0300, Denis Efremov wrote: > On 8/19/19 7:06 PM, Denis Efremov wrote: > > PCIe defines two optional hotplug indicators: a Power indicator and an > > Attention indicator. Both are controlled by the same register, and each > > can be on, off or blinking. The current interfaces > > (pciehp_green_led_{on,off,blink}() and pciehp_set_attention_status()) are > > non-uniform and require two register writes in many cases where we could > > do one. > > > > This patchset introduces the new function pciehp_set_indicators(). It > > allows one to set two indicators with a single register write. All > > calls to previous interfaces (pciehp_green_led_* and > > pciehp_set_attention_status()) are replaced with a new one. Thus, > > the amount of duplicated code for setting indicators is reduced. > > > > Changes in v3: > > - Changed pciehp_set_indicators() to work with existing > > PCI_EXP_SLTCTL_* macros > > - Reworked the inputs validation in pciehp_set_indicators() > > - Removed pciehp_set_attention_status() and pciehp_green_led_*() > > completely > > > > Denis Efremov (4): > > PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators > > PCI: pciehp: Switch LED indicators with a single write > > PCI: pciehp: Remove pciehp_set_attention_status() > > PCI: pciehp: Remove pciehp_green_led_{on,off,blink}() > > Lukas, Sathyanarayanan, sorry that I've dropped most of yours "Reviewed-by". > The changes in the last 2 patches were significant. Anybody want to review these?