Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp65392ybl; Tue, 27 Aug 2019 15:56:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzz7ZcbeSmc/Fc1zy+kORi5/IFuQOO3iDEa2KFFPAKiuPt/nk63KXlqWhiUOukRALuVXIWB X-Received: by 2002:a62:35c6:: with SMTP id c189mr1079081pfa.96.1566946576299; Tue, 27 Aug 2019 15:56:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566946576; cv=none; d=google.com; s=arc-20160816; b=gnNYmRtvqO7APCyMgE17kYpW8E/roTLQ4wvyAj5eoY2zcPa0KIVOhYeko6pCo39mfT 6nnLyV3stbRR+WibVcLc/5ZegnYQGUNDITRWkMcPiquFm0V1fFtpcRvqR0mC4x/VuHbB 1ogen/ww9ddBCCl4YyzXdy0I/p9aXamAvNjmuirxuHql73ol7hBISudneriDcgAvFzPR Gf9bOsxBhzmNqsP/UU0PJS0N6inV3V55qjUWd4EMnhKiZg62BywVSkjSOuWOxzyYR0t3 qIq9Zd+mVJG1CvorTsmGKgtYd8q2zcz1PyD1uEVnfqPgoB0/1qwGdReGozGEZMNmuf7A g9OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=uPKfTOZVYJJ882tAuaN14+T/czhhQlhCp5jn51VVryo=; b=YlaxSstp3hTLubnskWVJKvbv15tWNLurYr1me+5jDBlfKH8mT3xUaaZTZSpxRBIyi/ WF/MeoAjJzATc1vTwaZ87llqt1tTjO1K9BZNs9j1FJ4R3wYYfcmf5IUQ8ssLRaQcV8Hb CxNqYV25VJZqaGxtNpGjFLVPGB4Wm0Qo8xjrmC8HI0p4mUCNLLRlKxbMKO6kceZ3ByGo xHwdPP34HhI0zKoLCnwe7vGzj0HWrBA2IClBT72FHP4bMTC1gtCQPzGIGumRB2NFmUbM 0lDmGLkWK5MGi1spoS883xBlsOnoi6WvZo/ptOXaIIKTp9HlA38zX0KltRLdOoPVnxVd BmfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si341648pjz.58.2019.08.27.15.56.00; Tue, 27 Aug 2019 15:56:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbfH0Wxz (ORCPT + 99 others); Tue, 27 Aug 2019 18:53:55 -0400 Received: from mga05.intel.com ([192.55.52.43]:54664 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbfH0Wxz (ORCPT ); Tue, 27 Aug 2019 18:53:55 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 15:53:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,439,1559545200"; d="scan'208";a="181840162" Received: from skuppusw-desk.jf.intel.com (HELO skuppusw-desk.amr.corp.intel.com) ([10.54.74.33]) by fmsmga007.fm.intel.com with ESMTP; 27 Aug 2019 15:53:54 -0700 Date: Tue, 27 Aug 2019 15:50:58 -0700 From: Kuppuswamy Sathyanarayanan To: Bjorn Helgaas Cc: Denis Efremov , Lukas Wunner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] Simplify PCIe hotplug indicator control Message-ID: <20190827225058.GG28404@skuppusw-desk.amr.corp.intel.com> Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com References: <20190819160643.27998-1-efremov@linux.com> <2f4c857e-a7cc-58da-8be5-cba581c56d9f@linux.com> <20190827223254.GC9987@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190827223254.GC9987@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 27, 2019 at 05:32:54PM -0500, Bjorn Helgaas wrote: > On Tue, Aug 20, 2019 at 03:16:43PM +0300, Denis Efremov wrote: > > On 8/19/19 7:06 PM, Denis Efremov wrote: > > > PCIe defines two optional hotplug indicators: a Power indicator and an > > > Attention indicator. Both are controlled by the same register, and each > > > can be on, off or blinking. The current interfaces > > > (pciehp_green_led_{on,off,blink}() and pciehp_set_attention_status()) are > > > non-uniform and require two register writes in many cases where we could > > > do one. > > > > > > This patchset introduces the new function pciehp_set_indicators(). It > > > allows one to set two indicators with a single register write. All > > > calls to previous interfaces (pciehp_green_led_* and > > > pciehp_set_attention_status()) are replaced with a new one. Thus, > > > the amount of duplicated code for setting indicators is reduced. > > > > > > Changes in v3: > > > - Changed pciehp_set_indicators() to work with existing > > > PCI_EXP_SLTCTL_* macros > > > - Reworked the inputs validation in pciehp_set_indicators() > > > - Removed pciehp_set_attention_status() and pciehp_green_led_*() > > > completely > > > > > > Denis Efremov (4): > > > PCI: pciehp: Add pciehp_set_indicators() to jointly set LED indicators > > > PCI: pciehp: Switch LED indicators with a single write > > > PCI: pciehp: Remove pciehp_set_attention_status() > > > PCI: pciehp: Remove pciehp_green_led_{on,off,blink}() > > > > Lukas, Sathyanarayanan, sorry that I've dropped most of yours "Reviewed-by". > > The changes in the last 2 patches were significant. > > Anybody want to review these? Except for one nitpick in [PATCH v3 1/4], rest seems fine to me. -- -- Sathyanarayanan Kuppuswamy Linux kernel developer