Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp81094ybl; Tue, 27 Aug 2019 16:12:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwdlplU2r1l5+HVZX+HmDFmWfv5dNiKFPAkwdRHNdJoeNLmVFUYykYdU9TN/o7RMPsnGC0C X-Received: by 2002:a17:90a:e38e:: with SMTP id b14mr1151703pjz.125.1566947563484; Tue, 27 Aug 2019 16:12:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566947563; cv=none; d=google.com; s=arc-20160816; b=lWZUDmdfdE8wHbpKmfq+hS14q8phbHkYTOVwv1GImj6VVzLEIQbFPaqMdgE63Bi5Sc 10246mwnPm/NHrielVbuqSTjAYUv7Z5jrfhCpA9mASEYgkM95lMAZzb2qdjUhOhxR4ME N5sCQtlTRM7OuLF6fMgs/xZIPcE97ywv+4UQ4WqyaMHqnwGu+/Dcmo1lQSENH5B/kXQE 7C4c8dzSAftDZDaEp/kDGwsz4jzBax442V8iW3Eu09EfzmxN3glPUKQVERG5O1zW4DeL jXpsHYksmAtDyvrdIr/5K4PpiW6YPOWDtm594wrsMN9Qdgnckuw2kZDY5WSmIZIaw5v+ rsKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bMb3Jn8bRoOdPBaaSzBdnIXFGBxk2nOrd7/6FNV+Zt4=; b=KEol/OSXt3jGjf0UrYsuegOWHtTE6VgGq+PbATv/V7H2fz8T9qmmqmlgod1nT8KnId LGzNuxlW11bZkj9eh0H4PnKMa49hg4kOn6XJBumyu/QlUBIpY1ut+53d3n/n54YP7dMJ tnAwvPk0J4oMNrVD9kThW5k2RbVYySRPRgKqaiX55qLBeu654ZbvIdNibbtGGX70Nn6T NxSt40stp57S/sIe/Q3gkKkEPHfGF7mFhw2QFb9WYK7JCqAcwxno2tkONHm7zY3yba33 1MB7m544xOtt2ewsSBwG7r+1pbqlNF4sYyO7u4a3DyjcqMp+4ADR3o+2yOuDzl7TeVwq FERw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZRFwTS1r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19si382195pju.92.2019.08.27.16.12.28; Tue, 27 Aug 2019 16:12:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZRFwTS1r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbfH0XLf (ORCPT + 99 others); Tue, 27 Aug 2019 19:11:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:41598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbfH0XLf (ORCPT ); Tue, 27 Aug 2019 19:11:35 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EECF20856; Tue, 27 Aug 2019 23:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566947494; bh=aNlA/MApouOcwf72/8GMSwuzsBqyO6Sp9x6HCpSXgGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZRFwTS1rqTxwj2gvps8jYXhfiuL5Eq3hUd/q4PyouqcIke/YpvR0yEqCnHJpG0oBG q+uh2ZEibfyAH/G5ndZQGkinr8VnwC95MliB678A5+UIXUovp7a4j0ytcyqog3dgIl 8jeD5gpDNVsUfsxolJbYrmZuu7z9XbuEg9x+Ts0Y= Date: Tue, 27 Aug 2019 18:11:33 -0500 From: Bjorn Helgaas To: Krzysztof Wilczynski Cc: Matthias Brugger , Ryder Lee , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] PCI: mediatek: Remove surplus return from a void function Message-ID: <20190827231133.GG9987@google.com> References: <20190825221039.6977-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190825221039.6977-1-kw@linux.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 26, 2019 at 12:10:39AM +0200, Krzysztof Wilczynski wrote: > Remove unnecessary empty return statement at the > end of a void function mtk_pcie_intr_handler() in > the drivers/pci/controller/pcie-mediatek.c. > > The surplus return statement was added as part of > the work in commit 42fe2f91b4eb ("PCI: mediatek: > Implement chained IRQ handling setup"). > > Signed-off-by: Krzysztof Wilczynski I squashed this together with the other patch doing the same thing. If it causes any conflict with Lorenzo's branches, I'll resolve it when merging. > --- > drivers/pci/controller/pcie-mediatek.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c > index 3eaa7081ab2a..626a7c352dfd 100644 > --- a/drivers/pci/controller/pcie-mediatek.c > +++ b/drivers/pci/controller/pcie-mediatek.c > @@ -635,8 +635,6 @@ static void mtk_pcie_intr_handler(struct irq_desc *desc) > } > > chained_irq_exit(irqchip, desc); > - > - return; > } > > static int mtk_pcie_setup_irq(struct mtk_pcie_port *port, > -- > 2.22.1 >