Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp215373ybl; Tue, 27 Aug 2019 18:54:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqxuAW5d/8JMkUZaMM7NX5D5G1rcDOH2aJ3bYoy/CXJe0Jifu970J7lkVdEas+smGSaM4a9N X-Received: by 2002:a17:90a:358a:: with SMTP id r10mr1819238pjb.30.1566957278644; Tue, 27 Aug 2019 18:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566957278; cv=none; d=google.com; s=arc-20160816; b=OfyUUqMy7CXYdiZDG32z2Z5TWne7Ymb6DKHDzKUYzqSIc/ifgQXASZPjvKkUq8tgmy HWxq7EnszTV133iMv05jdcYs0VuJ/k3PF/M/fd99DnxB5ZTgNWFnqdjvQ3nZvXrU0hkO Z7DSi+2fejfYoEjBnLgTGpL3eQXDq7OZuHOmGiLG4fgViRxiB1pphguxngC844Xojzgx WHm1/csaQv9ySDv1/sygifUXJvUgXOm4z5B36Drlii8yKQJU6WCRY4bJiIX5t1EFIpTf hL6/jL88j4mkSZ94RhYJE+wM9AJ/UtdPtnDTUdo3BU4mTLvnadB7yjTrgo9SlA04p4xc eMsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :authenticated-by; bh=idPy1luC6LvEyYlxITjhgVJtuF9p8RHkn9gdvIQn+TM=; b=tG31m15K6tZW2/AYBoiHGyJ1gDeu/PIhbQUDbBxwt6iv1q7RbxkkwEPBu2P9jXZHXP 25cYoNzYTEBIRq1JH7PPXNvXgVwiDXdhKemAxxCqXbvWkCs0PfyJnlZkFVrNIapd28cg 12vY6s6sBIm/f5hI3+j8c1z7x9WVZ9kMf8q+7Dvhk8OrAKV2/sckvXz4WESGLKomIJ/0 3hCNxm2Duv/lNxukXtyMCMaRaMjJ7O9XKWW6UZaLtjcDsxdBHI6hCG+pYZ5VjX9DK50F mguuLv992GAgGLNdOfkX3GN9PSsMNmW8hOWfDESIBMIawVQ5uOgdjEL2POoPCnCMMUoH CUUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 97si693313pld.39.2019.08.27.18.54.23; Tue, 27 Aug 2019 18:54:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbfH1Bwz (ORCPT + 99 others); Tue, 27 Aug 2019 21:52:55 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:58451 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfH1Bwz (ORCPT ); Tue, 27 Aug 2019 21:52:55 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID x7S1qr8v023139, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTITCASV01.realtek.com.tw[172.21.6.18]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id x7S1qr8v023139 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 28 Aug 2019 09:52:53 +0800 Received: from fc30.localdomain (172.21.177.138) by RTITCASV01.realtek.com.tw (172.21.6.18) with Microsoft SMTP Server id 14.3.468.0; Wed, 28 Aug 2019 09:52:52 +0800 From: Hayes Wang To: CC: , , Hayes Wang Subject: [PATCH net v3 2/2] r8152: remove calling netif_napi_del Date: Wed, 28 Aug 2019 09:51:42 +0800 Message-ID: <1394712342-15778-322-Taiwan-albertk@realtek.com> X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <1394712342-15778-320-Taiwan-albertk@realtek.com> References: <1394712342-15778-314-Taiwan-albertk@realtek.com> <1394712342-15778-320-Taiwan-albertk@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.177.138] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unnecessary use of netif_napi_del. This also avoids to call napi_disable() after netif_napi_del(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index ad3abe26b51b..04137ac373b0 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -5352,7 +5352,6 @@ static int rtl8152_probe(struct usb_interface *intf, return 0; out1: - netif_napi_del(&tp->napi); usb_set_intfdata(intf, NULL); out: free_netdev(netdev); @@ -5367,7 +5366,6 @@ static void rtl8152_disconnect(struct usb_interface *intf) if (tp) { rtl_set_unplug(tp); - netif_napi_del(&tp->napi); unregister_netdev(tp->netdev); cancel_delayed_work_sync(&tp->hw_phy_work); tp->rtl_ops.unload(tp); -- 2.21.0