Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp306493ybl; Tue, 27 Aug 2019 20:56:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxz4BsNkuOgDBBLsVIg6EKMiz4UyyNiatTWerg4BOyv2DIqpYxJOqem4eSKgJljUXUtwmzt X-Received: by 2002:a17:90a:3847:: with SMTP id l7mr2025705pjf.99.1566964568439; Tue, 27 Aug 2019 20:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566964568; cv=none; d=google.com; s=arc-20160816; b=D/CIfOJmKgwn3qStmkwGUFJ6GKJr4JMbdiCMKcuCPYww/0yKW7UJU8o+wvx7DXk4ZC 3BZTMDkJDuwau+LY7e5xnmiK9/DSmPggfiton7/VM10aRPFsGGbKQE3zV+LSXb5Ikpz4 VxeRXCAdsw1298SjfIbM663mtpidXAfxnzUUx7jcSJAH72xZg0DZaEoMh/49PwMALilG Vk38TUAXV1nfCMTnDhRaLuk0grl9Efbza+Ns3qSGi5RDuz66DURzVnfypCPW/9bWCcuy EnS8+0mZH/SGF5Gw2uZzWLFpIpldbhpzQJHWGQHayU6ZP7oRPRCdwMkMuTSI+YU5WnXB r8DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Y9181Itz3jIauqOELXX6WInlwQHr+dm37ugRC+ucshM=; b=qhn+SwZqh1Ly5kqsm6E3FgI/vnkYIE595w8fuyYlXJqY9qq5aULpxDsWRTQLk1l+pn fEPNyGq4XLQuwlBZUzVAgwr4z5JPbt4GC7l7atrFvGpBgd1/5/A1Mjjxd6Y7DhO0uw8M fxw3+Vyt9bCYShB+pmkP5WZjRswmyTU5moagZe5Aga92v74ij8sV0ycZHq6KpoKt6XlU QDiEHP+f2zAgKuHtpFmzwwv0hxtdhDgr++U8ep34MJQGW0CFHyFMGlyhmrhkszXlhJhW vsd/OktYaRQpHAHAbwdzQZb4Hm5XJndSSKt5SXRCZu4A2tGP5exLjUIjgFz5W6sWcjXx s0uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=TjQXccpZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g124si1323714pfb.197.2019.08.27.20.55.52; Tue, 27 Aug 2019 20:56:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=TjQXccpZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbfH1DzB (ORCPT + 99 others); Tue, 27 Aug 2019 23:55:01 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46746 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbfH1DzA (ORCPT ); Tue, 27 Aug 2019 23:55:00 -0400 Received: by mail-pf1-f195.google.com with SMTP id q139so745124pfc.13 for ; Tue, 27 Aug 2019 20:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y9181Itz3jIauqOELXX6WInlwQHr+dm37ugRC+ucshM=; b=TjQXccpZVKZ1sffAXO/DsPyDsK+AdFu9vdXcGvo9YuHGjpeHZlNiTOqwGfSPmYezm8 l9Ajufq1E8hHy8CbTnQ2anykStPYMn7aF2ga3wEwW/IN1412J6cvxPr1DCxzzre7bLtx yS+d1Zh8I5PLqcOSKW5u/cce0sblzCDq2saTXTtJySLWpDmPv4on2rEXv33NS+3gHECZ /SIke6FZhTib1ascyJl3ItKGFoiCXn+zjg79QsgbWTNJQuWIrANzjeE+aU6JHsMPNJ9y IyyyJ8KkIDEJn10TuxcBtjTkEygENGwIvTRAXT18w5KFl4l7fKuf377AwEnhJljA6BBF crrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Y9181Itz3jIauqOELXX6WInlwQHr+dm37ugRC+ucshM=; b=siN5npVuCWBW+6QxgMwGy+1FDvKTwMbAMyNIkgn2GpPWMpJF0mUhEQMnrNtB59rJa/ gWxRc8K8/yA0aTZz0JJxIpHksnSbO1dVhKKDyWJiHRcPogCXfCuDU1kSQAu5Q1AfoH3u n6WZMUYvxiljI5o2yAEvYgpY2aGiVWzvlNCIZ8Wye1v6WuDhrYrDn+jVa3GRv06IcgVa p9iynH00eV+aDrpOqteJ8yImvAV70919imm2qGzpAzr1O9xiekBISIu1XgwE4+OEaOfR nUG4fM11kjOdqB+DGpBYPUkqS3a3r15ZTk8+cJn5n8cT2roxA1HjMOg0Ov75eTx59zFq bYuw== X-Gm-Message-State: APjAAAWYvIg3QhCfW50Lym5Q4s+VOrFt3xu5UTX8Fje/kXH4D/I+h+h0 VlGbnwtP4cXSBmjnJHmNisKnTMe2pRJfBQ== X-Received: by 2002:a17:90a:ac02:: with SMTP id o2mr2160177pjq.134.1566964499671; Tue, 27 Aug 2019 20:54:59 -0700 (PDT) Received: from localhost ([61.120.150.70]) by smtp.gmail.com with ESMTPSA id y188sm891408pfb.115.2019.08.27.20.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2019 20:54:59 -0700 (PDT) From: Fam Zheng To: linux-kernel@vger.kernel.org Cc: axboe@kernel.dk, paolo.valente@linaro.org, fam@euphon.net, duanxiongchun@bytedance.com, cgroups@vger.kernel.org, zhangjiachen.jc@bytedance.com, tj@kernel.org, linux-block@vger.kernel.org Subject: [PATCH v3 0/3] Implement BFQ per-device weight interface Date: Wed, 28 Aug 2019 11:54:50 +0800 Message-Id: <20190828035453.18129-1-zhengfeiran@bytedance.com> X-Mailer: git-send-email 2.22.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v3: Pick up rev-by and ack-by from Paolo and Tejun. Add commit message to patch 3. (Revision starting from v2 since v1 was used off-list) Hi Paolo and others, This adds to BFQ the missing per-device weight interfaces: blkio.bfq.weight_device on legacy and io.bfq.weight on unified. The implementation pretty closely resembles what we had in CFQ and the parsing code is basically reused. Tests ===== Using two cgroups and three block devices, having weights setup as: Cgroup test1 test2 ============================================ default 100 500 sda 500 100 sdb default default sdc 200 200 cgroup v1 runs -------------- sda.test1.out: READ: bw=913MiB/s sda.test2.out: READ: bw=183MiB/s sdb.test1.out: READ: bw=213MiB/s sdb.test2.out: READ: bw=1054MiB/s sdc.test1.out: READ: bw=650MiB/s sdc.test2.out: READ: bw=650MiB/s cgroup v2 runs -------------- sda.test1.out: READ: bw=915MiB/s sda.test2.out: READ: bw=184MiB/s sdb.test1.out: READ: bw=216MiB/s sdb.test2.out: READ: bw=1069MiB/s sdc.test1.out: READ: bw=621MiB/s sdc.test2.out: READ: bw=622MiB/s Fam Zheng (3): bfq: Fix the missing barrier in __bfq_entity_update_weight_prio bfq: Extract bfq_group_set_weight from bfq_io_set_weight_legacy bfq: Add per-device weight block/bfq-cgroup.c | 151 +++++++++++++++++++++++++++++++++----------- block/bfq-iosched.h | 3 + block/bfq-wf2q.c | 2 + 3 files changed, 119 insertions(+), 37 deletions(-) -- 2.22.1