Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp315857ybl; Tue, 27 Aug 2019 21:08:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwE9TqsJcrQNnLqrAH8Ixx4MJSWZMNSHLQHKMsbO4nVLwSqQTfJzS62j+h0yZ0zavrGTbhz X-Received: by 2002:a17:902:f217:: with SMTP id gn23mr2295229plb.21.1566965286635; Tue, 27 Aug 2019 21:08:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1566965286; cv=pass; d=google.com; s=arc-20160816; b=0u2g7gD3p2NhaKqhkcs4sr598UdU2vTtyhNhGQObSF8Ln16j+YDDPXUl+gQZVm/YC8 t3lwtsH9DZrHLor79qXhJpYvDZ+e3SpxnYO18bqzK3FtWRnQ5dqYIajtT3qjbZ9Ui7Zy qyLcFZXNkxvrTNhhntdoRPBvlEpLXnG0iTbEckCSPL1XCRbupMGEiIEiYw/gftPTN8Qn I2a2c9FXORVbH+gvvKHmntbPk3iY4vjs9DNdyVpRsJaHw/CRA5m2QwHYewa5vcU98g2u uB3VYdHg0N/Bx0xLZzc5fHRxk4L1keA5dCmHS7qN66gEw1f5hDwwr5v21/2mt5sEneK7 i9Yw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kZZ0SaUSYboCypvlsV1KXUwzNEviRw5SwLxgGnE8zzY=; b=SDbQyDpzMq9fvWX0idZk78K+r+o9a7Q7XRWjxRHQmuohIb01ZS1zg8+YNyUY3oV7xx oMEdatilJ89ou9vKPTixH9GRsLUhdcbymri5mN5XBjHraB4HLDJflm+bGif38FdP6+sG jwMp8hTEd6M3y2Qmr/cZlkkTENPQLpn8SyCJmNU3qlzX5grEER2KdB1b6YN9vlchaW7A 9VYC0JOpZzMmSUqMQnqgpC+IsJw0UyFHiaJPy1hL7SkpczcGLYHwj/9yyT9i5+6SENMw oBRYyC3LvUgUumJrmp+VBxHZyFlXO13GO6iYoavB1AF2Wl3kW62nug+onWkpZNEEF9ia VR+w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@euphon.net header.s=zoho header.b=gKntHUbp; arc=pass (i=1 spf=pass spfdomain=euphon.net dkim=pass dkdomain=euphon.net dmarc=pass fromdomain=euphon.net>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s5si1302329pfe.166.2019.08.27.21.07.44; Tue, 27 Aug 2019 21:08:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@euphon.net header.s=zoho header.b=gKntHUbp; arc=pass (i=1 spf=pass spfdomain=euphon.net dkim=pass dkdomain=euphon.net dmarc=pass fromdomain=euphon.net>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725862AbfH1EGo (ORCPT + 99 others); Wed, 28 Aug 2019 00:06:44 -0400 Received: from sender3-op-o12.zoho.com.cn ([124.251.121.243]:17868 "EHLO sender3-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbfH1EGo (ORCPT ); Wed, 28 Aug 2019 00:06:44 -0400 X-Greylist: delayed 916 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Aug 2019 00:06:38 EDT ARC-Seal: i=1; a=rsa-sha256; t=1566964261; cv=none; d=zoho.com.cn; s=zohoarc; b=nC0x4IFtr5oUkqo7CJopOuSOhRR5Uj5vv7ozu9uG51mRfJHG04y/d8q19F3JJjvyFIue4GIq6lCYQdVAC4rQDOUAOs8nhMo2nupo3oq/oSKfPKH0TE3Q9cmmU6JOBsaNWtmXKDRBvOWpssbX8X8LyzrYX+IDRTO3ZLCPFLGx92k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1566964261; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=kZZ0SaUSYboCypvlsV1KXUwzNEviRw5SwLxgGnE8zzY=; b=RZWvI+EBuMXc7SdAQBjrfAPV51T1la8dCfa1BgIvCmhQBFM8sIesVFfnVa7Ay/lPCraO//X5XhYfZ/MCYGyYWwRg1bNYk9OyEg1p6JVbuBrl3YopBQLnNSys54inM3FcV/GwWY4abp/58f+eYSlW+RgdThRFIu95xftdh7wunuM= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=euphon.net; spf=pass smtp.mailfrom=fam@euphon.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1566964261; s=zoho; d=euphon.net; i=fam@euphon.net; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=522; bh=kZZ0SaUSYboCypvlsV1KXUwzNEviRw5SwLxgGnE8zzY=; b=gKntHUbpwtEPWYsG8RAFSvgvTifHJiZkg0vZjQvPumRN9CB0yaXDLVlxxcTjfXxU ZsYBpyud35mPITI8gubkdPsc6N8m82VpRlujPxbqsV6jFCGarVssE8zSEnomCZmJ2gE M0vRNjeXrf8TtvD1IZdzdga5MoM4tn2JwiI/IadU= Received: from localhost (120.52.147.46 [120.52.147.46]) by mx.zoho.com.cn with SMTPS id 1566964259915588.9970437337977; Wed, 28 Aug 2019 11:50:59 +0800 (CST) Date: Wed, 28 Aug 2019 11:50:55 +0800 From: Fam Zheng To: Jens Axboe Cc: Paolo Valente , Tejun Heo , Fam Zheng , linux-kernel , duanxiongchun@bytedance.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, zhangjiachen.jc@bytedance.com Subject: Re: [PATCH v2 3/3] bfq: Add per-device weight Message-ID: <20190828035055.GA16893@magic> References: <20190805063807.9494-1-zhengfeiran@bytedance.com> <20190805063807.9494-4-zhengfeiran@bytedance.com> <20190821154402.GI2263813@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-ZohoCNMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08/26 07:59, Jens Axboe wrote: > On 8/26/19 12:36 AM, Paolo Valente wrote: > > Hi Jens, > > do you think this series could now be queued for 5.4? > > The most glaring oversight in this series, is that the meat of it, > patch #3, doesn't even have a commit message. The cover letter > essentially looks like it should have been the commit message for > that patch. > > Please resend with acks/reviews collected, and ensure that all > patches have a reasonable commit message. Will do. Thanks! Fam