Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp459374ybl; Wed, 28 Aug 2019 00:04:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/Fyuqk5FRw2HAwuwmYOTNq+iRcFgDEtK/o7svxCxUSgabtd+xiVaotdEQqF4rpXyImQDf X-Received: by 2002:a63:5402:: with SMTP id i2mr2149356pgb.414.1566975845835; Wed, 28 Aug 2019 00:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566975845; cv=none; d=google.com; s=arc-20160816; b=GwC4TeJ9XLz2NOB4+GW5OrUZzVuuK1crVb+Z2LjevJaf2wN59Uk1Q+sQHlNGUVRX/C MUba6Z91fvqCOR1B7zRkA0HAMW08RYNdXoBOAzuZCecUvs6ba2BpGD9YaDtIj+AKXh53 6/WBp+2bvUMz5puvob47v7feLV1R1YB1FAkVNyChL8jaIGMUJujhyQS5Rdv/Sxmxtysv yIIOAZHMPVUsJTeMe0OZzHTsNimqWO9R7o2h8KfJ3WhzH3y2RkJn1s74ea0q06kM+3uM jseQDw/kfUT7huUSXdwLpPFVP5fP+oSsHV/xW3S2RSMIJCLam1BkqTyzVnIvs9Jfmu0x HbFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=CNTqnEUSV26YqYL1HIaDpWu8yDzdo1k1PLwXsw/zxF8=; b=VxC43dgU7AnyZG5OPFKsQt1fk94HSUn6xhrZmHZakPQg87G+cJ0hcRqImzQdHjX8a4 wPCymaoDv+oRRJsWd2PkOa1xXAeAORZR3VE+jLp/kJSQ66u7AnvPa2YlQsJi60wpYf4G dES6zuYk6CswZVoOXbZvzOY5d2BEp9C0jygiA/u88tfkF01BJkNcUqvuPcADBwxLZ3Qw lNxtSfCh9oA7wovEvlddYj+uJY4DAfR+P7x29xrwTo4/LyTB70+JBluRkuDcHgiwk60L +cEz7J0o4CTKcQz12dkcx2eOZ6ukvSFdJ9q5oF0ARBsK7sowXa9/CpGK2fLrepsLtZHi xd+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f131si1436948pgc.265.2019.08.28.00.03.48; Wed, 28 Aug 2019 00:04:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbfH1HBm (ORCPT + 99 others); Wed, 28 Aug 2019 03:01:42 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:56767 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbfH1HBm (ORCPT ); Wed, 28 Aug 2019 03:01:42 -0400 Received: from windsurf.home (atoulouse-659-1-185-116.w90-30.abo.wanadoo.fr [90.30.228.116]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 3B35E200004; Wed, 28 Aug 2019 07:01:40 +0000 (UTC) Date: Wed, 28 Aug 2019 09:01:39 +0200 From: Thomas Petazzoni To: Bjorn Helgaas Cc: Krzysztof Wilczynski , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c Message-ID: <20190828090139.713b047f@windsurf.home> In-Reply-To: <20190827233017.GK9987@google.com> References: <20190826151436.4672-1-kw@linux.com> <20190827233017.GK9987@google.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, 27 Aug 2019 18:30:17 -0500 Bjorn Helgaas wrote: > [+cc Thomas] > > On Mon, Aug 26, 2019 at 05:14:36PM +0200, Krzysztof Wilczynski wrote: > > Move the static keyword to the front of declarations of > > pci_regs_behavior and pcie_cap_regs_behavior, and resolve > > compiler warning that can be seen when building with > > warnings enabled (W=1). > > It would be useful to include the compiler warning in the commit log. > > I notice there are a few similar occurrences elsewhere in the tree: > > arch/csky/kernel/perf_event.c:const static struct of_device_id csky_pmu_of_device_ids[] = { > arch/nds32/kernel/perf_event_cpu.c:const static struct of_device_id cpu_pmu_of_device_ids[] = { > drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = { > drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct msm_dsi_host_cfg_ops msm_dsi_6g_host_ops = { > drivers/gpu/drm/msm/dsi/dsi_cfg.c:const static struct msm_dsi_host_cfg_ops msm_dsi_6g_v2_host_ops = { > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:const static struct wiphy_iftype_ext_capab he_iftypes_ext_capa[] = { > fs/unicode/utf8-selftest.c:const static struct { > fs/unicode/utf8-selftest.c:const static struct { > > Those should probably be fixed, too (but in separate patches since > other maintainers would take them). > > > Signed-off-by: Krzysztof Wilczynski Acked-by: Thomas Petazzoni Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com