Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp485599ybl; Wed, 28 Aug 2019 00:34:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqwiEBvXfeUbyZR86WAvcDReYl+Ac8i9pYGmoljmBwRetGDTD2wh0l/o4/JHlFqKlgyJfKLU X-Received: by 2002:a17:90a:342d:: with SMTP id o42mr2907167pjb.27.1566977681786; Wed, 28 Aug 2019 00:34:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566977681; cv=none; d=google.com; s=arc-20160816; b=HzRDBiMQDKoPaHCw7DoQ6RdHb+zR6efjhD3N22k5znG7dEACQa/q2GvtZZbtJ5hz6r tgO1F49viNOCKObWuqKieifsuDkdIACnIeG9CCKZ+lCY3HgS8eceqnQWbcIdVukLphPk uVRzxQAFUd/fLV4lWQBW4eWYPRupCl/nj0xDTg/mhAdRSobvVmfhDA+POIi4+SKX+6ig ozEUuL7ZGD6e3hV73KiKdSjxzrh6VwetOdGi2KAgbJM8g6O9kSOJ8+I+45ThwY9bPrXd 7aVuqz0nuSMa5SdlNKZ5+lyFw/CHhI0WoG9ofeAbfEq7i401y5pxyu5AVunRvsI57SJu pYJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=NfLQvLEN/4SUIg24wd6k61cmwl9/5gsSQNSZs//BCak=; b=XprGJAWEdGikkHNZfuPnFLmewR6FZ6D4M4vam1C87cGSKlI1UYy1lANQeMzGBugBuS hLTlLWj04wmSB3EJ5RaAmHaS/72FKj5jYGNa8e3LSCQP3Q7Tg1Vp7x9vcJgD+M4ggLks Ck6Bag7s4m9Zp7gP7XOZ5Ov2U9y2/nhVuVjXPt4mcXl89lQXA7tlTeEEZJDQsVXwkcnA oBJQWA5B4l9ht3T6Hoid0NUqgbAsIe4yC6gNPq87nmvstmI+F4mKBhC/nDvQuwRPEVK9 vrNWRCgvXRCbLaxZ6KI9SkZc8nt78velGTP0/Uo5oKWPOxaceLP2veUVtF5OvT+ox/dE qmfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b="PB/byqaJ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i24si1493381pgh.224.2019.08.28.00.34.24; Wed, 28 Aug 2019 00:34:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b="PB/byqaJ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfH1HdD (ORCPT + 99 others); Wed, 28 Aug 2019 03:33:03 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:36915 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbfH1HdC (ORCPT ); Wed, 28 Aug 2019 03:33:02 -0400 Received: by mail-io1-f66.google.com with SMTP id q12so3405543iog.4 for ; Wed, 28 Aug 2019 00:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NfLQvLEN/4SUIg24wd6k61cmwl9/5gsSQNSZs//BCak=; b=PB/byqaJIzgXNpaKr0qKZqv+zcI4c1KjyuogKO7hLrB97+Zr+EVPM5gHnEVACggvzH YqmL2PNOSF4YBF/nIFviD/kKRvFeu4KUO8GrSvfRxYt/lhWFiYTK0GVTchFl3N9Z6Sr2 bVJKDeuQ23rxZaL/KVQETgb/we8cEClXdiIwBicotlyJ1nDmDCjIk3J9/ok7pFulyeWP oyPMRucL6LMGFiTymfnqEWhPnthDy/2LabhScB8aoBlvipVBPHFuOcnsLNJWumcbmj88 yXZO+1D1ikWjRK5B420Pn+LS+uQ8WHMeFllsxQwq4J3a3lEIeiIdAxMrux2R/F2KTHhs 7aew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NfLQvLEN/4SUIg24wd6k61cmwl9/5gsSQNSZs//BCak=; b=mS5yhRWExs5Nli9MrmjBMEAceq4Jh5QkGlLFhx0I0kK5xrIHeymVQyuLKexdLemEqi THwJCpYFBfljJj4pe7zNXjcqVZQHAbWq68I/s0xHusf7r5AQ+FwhT/64mQ4mNZDbYIbo YdiPry2mtJhTkbSa7ESg2b8ZdH8WXMVsYo+RjTrTS3JimVKsVD+gBjO2lUq2wAVChHD8 mQzPS2Y3Ad4mKLxjgTj+CcxvaX9rmU22F1jOEidziifIoNrNwHKsp8er9X3p4CfgjgbJ f1VyoW2bycejwXH8r0zFogwhTx6tpQd5Zlyo+5bcKeRMfI7r/Kbxo4Gwz4fy4yhF67R8 vAPA== X-Gm-Message-State: APjAAAVLybeJzvtE9nTcoilibWo452aQ2kPJbE/c3jTFctyQkAk8GUCu lKpVBM7QGXj5oZhY4F3RU7G5EFbNVff5oGWGPUEMsg== X-Received: by 2002:a6b:901:: with SMTP id t1mr2978915ioi.6.1566977581776; Wed, 28 Aug 2019 00:33:01 -0700 (PDT) MIME-Version: 1.0 References: <20190724082508.27617-1-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 28 Aug 2019 09:32:50 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] backlight: gpio: simplify the driver To: Yoshinori Sato , Rich Felker Cc: linux-sh@vger.kernel.org, Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Bartlomiej Zolnierkiewicz , Jingoo Han , Andy Shevchenko , Daniel Thompson , Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pt., 16 sie 2019 o 17:48 Bartosz Golaszewski napisa=C5=82(a= ): > > czw., 8 sie 2019 o 10:17 Bartosz Golaszewski napisa=C5=82= (a): > > > > =C5=9Br., 24 lip 2019 o 10:25 Bartosz Golaszewski napis= a=C5=82(a): > > > > > > From: Bartosz Golaszewski > > > > > > While working on my other series related to gpio-backlight[1] I notic= ed > > > that we could simplify the driver if we made the only user of platfor= m > > > data use GPIO lookups and device properties. This series tries to do > > > that. > > > > > > The first patch adds all necessary data structures to ecovec24. Patch > > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patc= hes > > > 3-4/7 remove unused platform data fields. Last three patches contain > > > additional improvements for the GPIO backlight driver while we're alr= eady > > > modifying it. > > > > > > I don't have access to this HW but hopefully this works. Only compile > > > tested. > > > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > > > v1 -> v2: > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from = Andy > > > - added additional two patches with minor improvements > > > > > > v2 -> v3: > > > - in patch 7/7: used initializers to set values for pdata and dev loc= al vars > > > > > > Bartosz Golaszewski (7): > > > sh: ecovec24: add additional properties to the backlight device > > > backlight: gpio: simplify the platform data handling > > > sh: ecovec24: don't set unused fields in platform data > > > backlight: gpio: remove unused fields from platform data > > > backlight: gpio: remove dev from struct gpio_backlight > > > backlight: gpio: remove def_value from struct gpio_backlight > > > backlight: gpio: use a helper variable for &pdev->dev > > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > > drivers/video/backlight/gpio_backlight.c | 82 +++++-------------= -- > > > include/linux/platform_data/gpio_backlight.h | 3 - > > > 3 files changed, 44 insertions(+), 74 deletions(-) > > > > > > -- > > > 2.21.0 > > > > > > > Hi Rich, Yoshinori, > > > > can you ack the sh patches in this series? > > > > Bart > > Ping. Hi, any chance of getting this reviewed for sh? Bart