Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp496360ybl;
        Wed, 28 Aug 2019 00:47:35 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzFGsAQoHc2ckoLsbP4IQw9zMqPgBRSkf8EQ+OCGZdBU/Eemdtdwa74l4DgCsm82k8aNcUL
X-Received: by 2002:a63:f941:: with SMTP id q1mr2315465pgk.350.1566978455066;
        Wed, 28 Aug 2019 00:47:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1566978455; cv=none;
        d=google.com; s=arc-20160816;
        b=syBLkQ0qV/F33Xqm0gc2658h5NUk3BUaUC/hmekgR6j0+kg0Vl7oddrQkinAzgJLEA
         qS4TfWYwzhFUc9NaEUcAWuL0+kNboxIWEDiQ6+xUVIjjIwEM1I6LJxLQIrpBau8zzlML
         onqqLRGFJqx7twOSCMgc++/3lrq/CD5aOD5bpu16AZ7Y3IntOjiI6RnKbCNY1GICsX9/
         KA8m9cL/+qk/ltqnZkrIvJW+PsOgLxjk19VstZ3q7+W9+akSmu95v6JMCsQ+aJxEYyjz
         vWMMnxyVfGAxEoDK9efGu57OBv9SMoVhlGV1wxFM/KTUroQh4PFMxAM9c0pb00JcGPZ7
         OZxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=gqkmpot9s6gPML1W2+U08e8kxWH1kqOpgIslvJ6ETaY=;
        b=ktsyZApeDzDciHcZuHxWi6TTOvuDLBO1w0i33CXR5KdhwOChEwJivENkCmMX6dLI45
         g/zuQafJOQ++FqShWL2JB5oBk8sg9AheSYUvYijiww3ajm1OprGEeL5DBnHclkF0yFsc
         xsm90O4aCT/ucYJfZkPNQcmaU5fHArmL4kGcgg+ipW3wswNWEskhlE8GJGQRoyEoQdRn
         EXDqECoqxsRxyBrGNnOfTJxNicUp9s6q8Zj7W8FiER5Et3cNVTXRM7bn2Jv/BskyOFkq
         LMm/cGy1pkrDjm0yBwvzsU8iGvQbIzMZKLwLYRqEbGEh/tkzRWNTdgsT+kjv/xcJLDSa
         E91Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=dhNnulrZ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id c22si1311510plz.361.2019.08.28.00.47.19;
        Wed, 28 Aug 2019 00:47:35 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=dhNnulrZ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726529AbfH1Hpk (ORCPT <rfc822;radocaj.bane@gmail.com>
        + 99 others); Wed, 28 Aug 2019 03:45:40 -0400
Received: from mail-io1-f65.google.com ([209.85.166.65]:43977 "EHLO
        mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726497AbfH1Hpk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 28 Aug 2019 03:45:40 -0400
Received: by mail-io1-f65.google.com with SMTP id 18so3966394ioe.10
        for <linux-kernel@vger.kernel.org>; Wed, 28 Aug 2019 00:45:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=szeredi.hu; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=gqkmpot9s6gPML1W2+U08e8kxWH1kqOpgIslvJ6ETaY=;
        b=dhNnulrZXhgiY7H6M+oJdiiIwYTeim61SHJlStKeam/O6Txv6bzIsCPGf1aTvCiGGC
         TX4oGm3mf/6F7uOsTWqquRw/W1VoA3P0uDRu7tmP2WSvzGWA/XKlTEvFiY+1asbMoW5T
         GOEa9uhLbKi979xcEOROpziFYXdhp8Wq1Mgow=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=gqkmpot9s6gPML1W2+U08e8kxWH1kqOpgIslvJ6ETaY=;
        b=EGQBRJ0JiHDfgk/f348D/H/NgqOkKNcEDZc8uslYsZRss3WoN+ZmYTm5pf4tBSVtpC
         tp8RZ/jTnlvZvlfGfJDCBViz4YUdSeJVO099zHHRWU0CdHlSpAB/+7ta2/WvtK21zHRw
         UfSX9grKVLUp0h9fS7Sk6Op+gH4lrt8vsF0kkMkV9KJE3J3Uy4PovgKta8ZlHmzLnGAU
         O5sPqQPq2Mzy+k2PZX6/TgnepZDOVyOTqQO/pZ66lJsEQjYd3PCNfyYDxlhRhGeB/RfD
         MEN6+UD2yE9lt+ULPlBGbOhxWEuJ9FGEpBr5q/buXEB1BGDzrhyZzI0LYUg/SPlsMSNz
         k/0w==
X-Gm-Message-State: APjAAAUgQPpuPyLha5VYjNNdFsEMyHNaDR/ZjzEBGGpK2RWJxEvcBmB2
        BtDntn+C0S0g1NBOOoRcBUnd3cOnoSCxusN9SJmXhQ==
X-Received: by 2002:a6b:6f17:: with SMTP id k23mr2169967ioc.25.1566978339324;
 Wed, 28 Aug 2019 00:45:39 -0700 (PDT)
MIME-Version: 1.0
References: <20190821173742.24574-1-vgoyal@redhat.com> <20190821173742.24574-3-vgoyal@redhat.com>
In-Reply-To: <20190821173742.24574-3-vgoyal@redhat.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Wed, 28 Aug 2019 09:45:28 +0200
Message-ID: <CAJfpegu41FYEBfniEBPtujgLW4nC+w6_6VG2EmNi=kC8ZeNFtA@mail.gmail.com>
Subject: Re: [PATCH 02/13] fuse: Use default_file_splice_read for direct IO
To:     Vivek Goyal <vgoyal@redhat.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        Miklos Szeredi <mszeredi@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> From: Miklos Szeredi <mszeredi@redhat.com>

Nice patch, except I have no idea why I did this.  Splice with
FOPEN_DIRECT_IO  seems to work fine without it.

Anyway, I'll just drop this, unless someone has an idea why it is
actually needed.

Thanks,
Miklos