Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964971AbVLSU7Q (ORCPT ); Mon, 19 Dec 2005 15:59:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964973AbVLSU7P (ORCPT ); Mon, 19 Dec 2005 15:59:15 -0500 Received: from canuck.infradead.org ([205.233.218.70]:52612 "EHLO canuck.infradead.org") by vger.kernel.org with ESMTP id S964971AbVLSU7O (ORCPT ); Mon, 19 Dec 2005 15:59:14 -0500 Subject: Re: [patch 04/15] Generic Mutex Subsystem, add-atomic-call-func-x86_64.patch From: David Woodhouse To: Zwane Mwaikambo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , Arjan van de Ven , Steven Rostedt , Alan Cox , Christoph Hellwig , Andi Kleen , David Howells , Alexander Viro , Oleg Nesterov , Paul Jackson In-Reply-To: References: <20051219013507.GE27658@elte.hu> Content-Type: text/plain Date: Mon, 19 Dec 2005 20:58:52 +0000 Message-Id: <1135025932.4760.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 511 Lines: 15 On Mon, 2005-12-19 at 09:49 -0800, Zwane Mwaikambo wrote: > Hi Ingo, > Doesn't this corrupt caller saved registers? Looks like it. I _really_ don't like calling functions from inline asm. It's not nice. Can't we use atomic_dec_return() for this? -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/