Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp542763ybl; Wed, 28 Aug 2019 01:38:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5dQ4/sWHDmdQU0KyaWlW8FH+slK6rD7tpKvoCbm7hU4WO0rpty/me1RBHYgtEQO3d1ywq X-Received: by 2002:a17:90b:f03:: with SMTP id br3mr3058522pjb.67.1566981488240; Wed, 28 Aug 2019 01:38:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566981488; cv=none; d=google.com; s=arc-20160816; b=YKo36BF8xO2u+F88w+L2C3UXRAHp7mw/HO6SR/zggZidUabDmHMpg0PT1teHK7grD0 YjfLWNVuwTTgbaFmzV+Mtyjy2S0t5lFHBo3IjJdj1ykyQdEn+TP104+FGpiU/fa13mrQ FPU3LSFLLAYW+3L4cCsLhsyfTLTkEbUxrTKLkXkHuOeorK0yNyQVyZ03L11sxMkbgKOL 2shTAb7LW1H3Dr/7wR5zH37czr5bhV1VzoPXKxb+wqgvfgl8/5/MOUMo9VGuubZ3Ip2x vENogTbsp+Fu7p3OW2sLwOk6zqorx99UXI8tOVlgSaipIQAFOry9bciG1u0BzZVmWsby m7Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=1SJ5siSRH/K6sLUhK0BcuHju3SWG5xZg5n09qWPFPCs=; b=Zb7kK+u+4v0DrD0VPbUjr2ZlVLwAifSimlf5FYPITWeEBbItmgwoIEhPqBUjrQMG35 Wq9l588pd6dMKfCb94dFZd7t9HVGtANPvkJAeX7mcW+DOrKwnyCbcDF9effief3hH9fr jrZSWYpCMF8yLJqxU5OucfqZU0wis4YQvDm3jS20eVai9gjXxXLgGL/0Mr8zHOvSfLgR CckPEStKvDxI+XtYi3xhED0ifq0XEyTlT/Z9yEQTHF2tmVxfNDeYhIvpHQN0M95My+r6 TzBa/teFQ3yEiJR7EmjnQglnOBr4hqPvMIWQFDxtJyrvu8swB7v0hFMy53bjcRLUkpB9 z+vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r16si1567813pgh.385.2019.08.28.01.37.52; Wed, 28 Aug 2019 01:38:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbfH1IhA convert rfc822-to-8bit (ORCPT + 99 others); Wed, 28 Aug 2019 04:37:00 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:34014 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfH1Ig7 (ORCPT ); Wed, 28 Aug 2019 04:36:59 -0400 Received: by mail-ot1-f67.google.com with SMTP id c7so1992378otp.1; Wed, 28 Aug 2019 01:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2Erove1KI2K6GKd3UFaZlGI+A1u6CspqOGbjftwYs2o=; b=RsOVHUV2rRGqeecVWFLG9J8HlcIjMgja8ncvY9XZYMOmqj2KbuMsTXW6ref0ZZpP8y O2sS5+di2RzdaHXQYtEIPQb5ok7KmnTxE3WKc4YceBZgbDRxCwsqoq0gCMFk2+jnnuzf l1HryWSif65yXT4d8xZATRsz/zGG6fWJOtq2S+VUBcWK8qh9ev9g/5dBjeChYh7nWdAx xFWy3iKBPVB2c73orPP7ivNKWHm4Ts4fH4rZY8D1D5vcT/uJbFuGmAisv3rbUaUmtWUR 9d+C2SVBB6T3NfoMRVg4YmMWEx3YAsmlz3VNuX/ishcTDSlSWXSRGyu9lYshArLxZVa8 g01Q== X-Gm-Message-State: APjAAAVE0IS7InGjjN4TWjbhmOlxt6SEVZurGt01g+nMsCroWmPz4IbA 1dj4tqQ5L0OwnGwsQLqPLQCAmPTAcBrYmb/QZig= X-Received: by 2002:a9d:2cc:: with SMTP id 70mr2261989otl.145.1566981418736; Wed, 28 Aug 2019 01:36:58 -0700 (PDT) MIME-Version: 1.0 References: <20190724082508.27617-1-brgl@bgdev.pl> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 28 Aug 2019 10:36:47 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] backlight: gpio: simplify the driver To: Bartosz Golaszewski Cc: Yoshinori Sato , Rich Felker , Linux-sh list , Linux Kernel Mailing List , DRI Development , Linux Fbdev development list , Bartosz Golaszewski , Lee Jones , Bartlomiej Zolnierkiewicz , Jingoo Han , Andy Shevchenko , Daniel Thompson , Linus Walleij , Jacopo Mondi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC the pour soul with the ecovec board. On Wed, Aug 28, 2019 at 9:33 AM Bartosz Golaszewski wrote: > pt., 16 sie 2019 o 17:48 Bartosz Golaszewski napisał(a): > > czw., 8 sie 2019 o 10:17 Bartosz Golaszewski napisał(a): > > > śr., 24 lip 2019 o 10:25 Bartosz Golaszewski napisał(a): > > > > From: Bartosz Golaszewski > > > > > > > > While working on my other series related to gpio-backlight[1] I noticed > > > > that we could simplify the driver if we made the only user of platform > > > > data use GPIO lookups and device properties. This series tries to do > > > > that. > > > > > > > > The first patch adds all necessary data structures to ecovec24. Patch > > > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patches > > > > 3-4/7 remove unused platform data fields. Last three patches contain > > > > additional improvements for the GPIO backlight driver while we're already > > > > modifying it. > > > > > > > > I don't have access to this HW but hopefully this works. Only compile > > > > tested. > > > > > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > > > > > v1 -> v2: > > > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy > > > > - added additional two patches with minor improvements > > > > > > > > v2 -> v3: > > > > - in patch 7/7: used initializers to set values for pdata and dev local vars > > > > > > > > Bartosz Golaszewski (7): > > > > sh: ecovec24: add additional properties to the backlight device > > > > backlight: gpio: simplify the platform data handling > > > > sh: ecovec24: don't set unused fields in platform data > > > > backlight: gpio: remove unused fields from platform data > > > > backlight: gpio: remove dev from struct gpio_backlight > > > > backlight: gpio: remove def_value from struct gpio_backlight > > > > backlight: gpio: use a helper variable for &pdev->dev > > > > > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > > > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > > > > include/linux/platform_data/gpio_backlight.h | 3 - > > > > 3 files changed, 44 insertions(+), 74 deletions(-) > > > > > > > > -- > > > > 2.21.0 > > > > > > > > > > Hi Rich, Yoshinori, > > > > > > can you ack the sh patches in this series? > > > > > > Bart > > > > Ping. > > Hi, > > any chance of getting this reviewed for sh? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds