Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp550815ybl; Wed, 28 Aug 2019 01:47:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzl7C9t/zGVCTkabdhQcmrUGuxrNMc3wKT53A5Y+VmnqJQI8RbOi/TCs3t0D2fwRmlfc8vM X-Received: by 2002:a63:3fc9:: with SMTP id m192mr2495832pga.429.1566982028534; Wed, 28 Aug 2019 01:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566982028; cv=none; d=google.com; s=arc-20160816; b=TTezVo7sPMOWORPdkCvhU34R1Voi7TtU2IylDGIDSMJbzDbW3r1q472/mR+EsSM/vo sYzSLNd865T+cmpxVoQKUeIpCr6aWjlPvlMDE6JrZmhxiOeYuyClsKGkrMcRRVU+88oD 6+B2RtAbpBju35FbB+e3PdV99+12g3yNQ27nN5+b6hLvxS79Fh0CXsOfpWz40WWIwadX TLxzIQxR3D80ISiFjI8P0yPSMTWHqAWR5rj4QPAgOrl8X2mk8OBX5tV9uMqirk+m1UPm U9svClEdxA0kl5NM0H2ypAAPbJ8k79ibW9AWZ8h0YOUG0jNicW3cdWYAPdlyjH4B2K0q QjbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=SYNMMq01znmSNj5G0W+PjKmwx9zN78KMh0tsuO4IhcY=; b=uQmfeFSZQPleFtCZ40686mZc1l7Zs+TTMJqWaE3tRxB07JZ0KMbWa9j/EdnzgcZr5j 3c4beRFBHH0UY51PAzEgjWD4MwNyMqUSX2sPJVSeI5oHBUS+JHbMA6YhMrok3xYAx5D4 VPeh5UtBZPnXsqBrzUsT24I4w1qbU7Hli46MsK1zyyio8mm0XOcSudzkaBV43rlbU5sT dZTY72KXMiY6hbPCX05EOY7AF90Ogm7uU20YRX9CsaL7b3+QZAMkDMMXgHp4o8FMTRDL BlP56hCSWB+FS1u7KbKd4Z8LNmUa1IDMCdOH6VM88QHz4Aj61OuBVqHEG4d8fYUlZy9B nzdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si1840699pfd.165.2019.08.28.01.46.52; Wed, 28 Aug 2019 01:47:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfH1Ip4 convert rfc822-to-8bit (ORCPT + 99 others); Wed, 28 Aug 2019 04:45:56 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:35245 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfH1Ip4 (ORCPT ); Wed, 28 Aug 2019 04:45:56 -0400 Received: by mail-ot1-f65.google.com with SMTP id 100so2011748otn.2; Wed, 28 Aug 2019 01:45:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jCxOMA9aKz6SC3UYzcS/O/Ome5CiEdeSa8P16zSjLyw=; b=mtVHIfLz2MYDqKv0z90pu/NAxxsgLVfBebaj1h8GhPpQgKlrIlsg8u8mUkghB++9fI oLpjzcJRRMJoVtnSGMP/RPDDBfgNOvBeFjshTz5xysC07a4jM+ar64+qL296DyRNRixz VZ/jstryf8mbnGy6rTiR95G4PylRZmca3c8dC9Mp8cqs3xg7Yf9gXSgX5j7xINpRPe0G rrmHviLz1RW/VgsOVOExvP/CZcdMgFChLEkLlxTSC1/uQ4giWB3cDCMfKAWPkGTHP8xa eyGP7GwdjfLiBYfTa/tRkcI/bSUj8wAGAxkjb9/6tBks6NzWM7Wf9NW2Qu+GHMz16yMa 1hhw== X-Gm-Message-State: APjAAAUeU1eWcnyuWHx4caEqL9izF/CcxyzK13zSVq2qdwv24nYzyRkN HoNKcGSDkK1TaZzZe8av1ufPhVukX0zYYIctdlI= X-Received: by 2002:a05:6830:154:: with SMTP id j20mr2381058otp.266.1566981954882; Wed, 28 Aug 2019 01:45:54 -0700 (PDT) MIME-Version: 1.0 References: <1564643196-7797-1-git-send-email-wanpengli@tencent.com> <7b1e3025-f513-7068-32ac-4830d67b65ac@intel.com> <20190803202058.GA9316@amt.cnet> <20190826204045.GA24697@amt.cnet> In-Reply-To: From: "Rafael J. Wysocki" Date: Wed, 28 Aug 2019 10:45:44 +0200 Message-ID: Subject: Re: [PATCH] cpuidle-haltpoll: Enable kvm guest polling when dedicated physical CPUs are available To: Wanpeng Li Cc: Marcelo Tosatti , Paolo Bonzini , "Rafael J. Wysocki" , LKML , kvm , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Linux PM , "Michael S. Tsirkin" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 10:34 AM Wanpeng Li wrote: > > On Tue, 27 Aug 2019 at 08:43, Wanpeng Li wrote: > > > > Cc Michael S. Tsirkin, > > On Tue, 27 Aug 2019 at 04:42, Marcelo Tosatti wrote: > > > > > > On Tue, Aug 13, 2019 at 08:55:29AM +0800, Wanpeng Li wrote: > > > > On Sun, 4 Aug 2019 at 04:21, Marcelo Tosatti wrote: > > > > > > > > > > On Thu, Aug 01, 2019 at 06:54:49PM +0200, Paolo Bonzini wrote: > > > > > > On 01/08/19 18:51, Rafael J. Wysocki wrote: > > > > > > > On 8/1/2019 9:06 AM, Wanpeng Li wrote: > > > > > > >> From: Wanpeng Li > > > > > > >> > > > > > > >> The downside of guest side polling is that polling is performed even > > > > > > >> with other runnable tasks in the host. However, even if poll in kvm > > > > > > >> can aware whether or not other runnable tasks in the same pCPU, it > > > > > > >> can still incur extra overhead in over-subscribe scenario. Now we can > > > > > > >> just enable guest polling when dedicated pCPUs are available. > > > > > > >> > > > > > > >> Cc: Rafael J. Wysocki > > > > > > >> Cc: Paolo Bonzini > > > > > > >> Cc: Radim Krčmář > > > > > > >> Cc: Marcelo Tosatti > > > > > > >> Signed-off-by: Wanpeng Li > > > > > > > > > > > > > > Paolo, Marcelo, any comments? > > > > > > > > > > > > Yes, it's a good idea. > > > > > > > > > > > > Acked-by: Paolo Bonzini > > Hi Marcelo, > > If you don't have more concern, I guess Rafael can apply this patch > now since the merge window is not too far. I will likely queue it up later today and it will go to linux-next early next week. Thanks!