Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp640188ybl; Wed, 28 Aug 2019 03:12:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8IM1FpYwabRsAJrNBLMhfpyQ6Z1rxONEGUskQAqrmsO8U5Ct7e4WxbMN76/cXig7zuyJm X-Received: by 2002:a63:30c6:: with SMTP id w189mr2662056pgw.398.1566987141722; Wed, 28 Aug 2019 03:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566987141; cv=none; d=google.com; s=arc-20160816; b=i3yVDrHjv0gpyBHEa25x2UsJIK/Qhw+1xqjEwgSgokilOaBQB8qJ3il7vZ/BMiWTcB /prU7GP1i8KYzdrmbJFUG7fM1dWJ8QMmSZayJvD5FW1ghSFt1E7LAlnOZMFOJroRG8qG PjTS7Ge4f7V7J1wKViQF6yt6oUctnh5zreT4X16VGbhetopSEIYcGfiYCsJSLVsL87fK 3ZAYSlCpxs1tv11Qvpx8/HvjnllKaGhWkx//1255VdNmy/oXHE9lgIJz2ThcLGoCsrdw nSAF8x7eUEyzpcOwKFp/KS1MqFkLqVCVV/y/qJ1f0SoLBu5H3ia/y2EJBHVpK4r/in0m vgVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=CEWB1z8G/mWdWNbjbEQklZekZBjN4/ngP8AwBbnnqvk=; b=qsQk+oeoEMsDntNaSa1NaO0JHZfS2OYdR0ikwxJrECtm1cHFTnJK4jI+yajslKO1lX VsAgndCjFJ19dJtl1B59xGzitbSXpsZbVcI3l17hGCVyloV0zy20OmktJPUtlLW7zarp bA/Ckbb+nRlx1Wo5vyUfY7tpmcXnjhOew909s1i+x+i2CjKxL8MEwsCvRa0IVuTFavyl mPoYhGMW/6f/3IGMKJ5nc1syFF0Mvwusijvq7ESRyDcWPdNkLcJL9w/cvxcWPpp/2oEH X53/ZWiUOY7StuJa+6EV4jUt3hY9IqAMWBquOZ6MRTbhwUHF0J0RJVJkLOEwT3w7WEuJ L4yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si1864905pgh.359.2019.08.28.03.12.05; Wed, 28 Aug 2019 03:12:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbfH1KKD (ORCPT + 99 others); Wed, 28 Aug 2019 06:10:03 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46912 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbfH1KKD (ORCPT ); Wed, 28 Aug 2019 06:10:03 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 2392928A204 Subject: Re: [PATCH] arm/arm64: defconfig: Update configs to use the new CROS_EC options To: Arnd Bergmann , Bjorn Andersson Cc: SoC Team , Gwendal Grignou , Benson Leung , Linux Kernel Mailing List , Guenter Roeck , kernel@collabora.com, Lee Jones , Krzysztof Kozlowski , Linus Walleij , "open list:TEGRA ARCHITECTURE SUPPORT" , Marcin Juszkiewicz , Will Deacon , Catalin Marinas , Geert Uytterhoeven , Leonard Crestez , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Olof Johansson , Chanwoo Choi , Dinh Nguyen , Miquel Raynal , Linux ARM , Daniel Lezcano , Kukjin Kim , Thierry Reding , Jonathan Hunter , Sudeep Holla , Jagan Teki , Fabrice Gasnier , Daniel Mack , Russell King , Shawn Guo , Simon Horman , Marek Szyprowski , Yannick Fertr? , Robert Jarzmik , Alexandre Torgue , Tony Lindgren , Anson Huang , Maxime Ripard References: <20190827154851.10486-1-enric.balletbo@collabora.com> <20190827161045.GC26807@tuxbook-pro> From: Enric Balletbo i Serra Message-ID: <2db6cde1-9e7f-8b1c-f2e4-80bdd2478d28@collabora.com> Date: Wed, 28 Aug 2019 12:09:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, Arnd, On 27/8/19 18:12, Arnd Bergmann wrote: > On Tue, Aug 27, 2019 at 6:08 PM Bjorn Andersson > wrote: >> >> On Tue 27 Aug 08:48 PDT 2019, Enric Balletbo i Serra wrote: >> >>> Recently we refactored the CrOS EC drivers moving part of the code from >>> the MFD subsystem to the platform chrome subsystem. During this change >>> we needed to rename some config options, so, update the defconfigs >>> accordingly. >>> >>> Signed-off-by: Enric Balletbo i Serra >>> Acked-by: Krzysztof Kozlowski >>> Reviewed-by: Gwendal Grignou >>> Tested-by: Gwendal Grignou >> >> Can we make the entries in the generic arm64 defconfig modules? > > Good idea. > > Actually I would prefer to have all of them as modules for consistency, > if at all possible. > It is very common boot Chromebooks from an USB device, the EC needs to be built-in in order to boot from these devices, otherwise you should use an initramfs. I'd like to avoid forcing people to build an initramfs just to boot from these devices if possible, in fact, my usual workflow is without initramfs, and knowing that with the default defconfig just should boot helps a lot sometimes. Note that, it's not the case for EC subdevices, these are already build as modules. BTW, Lee asked if this patch should be squashed with the patches that really renames the config options to help bisect ability, I don't have a hard opinion as I don't usually run the config option between bisection steps, so please let me know what do you prefer and I'll respin the patches ASAP if that's the case. Thanks, Enric > Arnd >