Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp643334ybl; Wed, 28 Aug 2019 03:15:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkeACVOJvRXhrzwSCoK8zjSYc/VQtNIcCRnPPULCfxs2P07/tR3pxfwllhpLFc+EtoryHB X-Received: by 2002:a17:90a:9f09:: with SMTP id n9mr3481835pjp.72.1566987302998; Wed, 28 Aug 2019 03:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566987302; cv=none; d=google.com; s=arc-20160816; b=hDok7gpRpzkgXzC+Flb+uHjFhSDTvFCuj94eiDdstMwmkDGKDw6UCnSvZH2Db/d+fv VlcTeedGf693v5OSzJBlVA4cAl6fj9yEuaA2tF/KHuFmIUB5FHW8vOtnZRRObT9wy8wX geep096OFRn0E5czD1W7I8WVzmbRhAwLmxcxaHJeYyxAvADOr/PKGo0d7c8ou4D2QN2D PhW8ltz2cCaUZugpyQwd5LvyCA8+1wHzfEEMtxZ7i5TG4uDgq12L+Nun8CqKx0TXcERd roX3hCwAs8UHUf7ZR1stMfK9jWkGkFAHwwRc5gq50VzcFrLs5EGcoQxSEY64TNp+hPN1 U0qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6Hcdm4CpIqKt7py/aqpOB6jyd7ntLB//7FnB38ZJF1U=; b=RO/2wzPyBAfuP26fYMoAxhwSJzrF2xIx/ob4W/w0MdDrj8zwNSGRK3pkZQcUfUiY7z WPQ30IAFEIENO/Kb6mR7W5Vj1r4iSzn+e7xhCe/EJdVc+0WNLKmjqoKMDIUZptOLop/y z43uic/5jS5WKjoC4EZWREmbkxMAsQE4BCSvPscntWP2BmYQ+CH3pAOZBKevJjksfmlJ Lbk6keNtwUIHpsvmInxywXYrHA+xbIjCp4ypTIy0MCF0e8bVLisukfO8EVJGuEX95s+u Xr72TZ+sb1Bw2afrSQ0axJjMDekxJWjz4RjlSVmIEqNgaQoAIWUhPUbGMlrxxWWfyA0w mwDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="N/n52wcJ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si1585888plw.278.2019.08.28.03.14.46; Wed, 28 Aug 2019 03:15:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="N/n52wcJ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbfH1KNl (ORCPT + 99 others); Wed, 28 Aug 2019 06:13:41 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:45530 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbfH1KNk (ORCPT ); Wed, 28 Aug 2019 06:13:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Hcdm4CpIqKt7py/aqpOB6jyd7ntLB//7FnB38ZJF1U=; b=N/n52wcJOLKSBwVrVhui/AseL stM3Olw+r2+yVWBBA6cP309MUYzht7vs60CNyvxjA7dpPAdC5b5wShwKcgoyh6rmEr7TsVOtb2NHE Wc/sUh4gsQQxQoP0QjpdajDbNv5/fxzIOVVG9365Esa8JuDQSu95Mk/1ltHrvl7R/sNRQ=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i2uxL-0003ZT-8c; Wed, 28 Aug 2019 10:13:35 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 81EAA2742A55; Wed, 28 Aug 2019 11:13:34 +0100 (BST) Date: Wed, 28 Aug 2019 11:13:34 +0100 From: Mark Brown To: Jisheng Zhang Cc: Liam Girdwood , Rob Herring , Mark Rutland , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 2/8] regulator: add support for SY8824C regulator Message-ID: <20190828101334.GB4298@sirena.co.uk> References: <20190827163252.4982af95@xhacker.debian> <20190827163418.1a32fc48@xhacker.debian> <20190827194437.GO23391@sirena.co.uk> <20190828112705.5e683693@xhacker.debian> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX" Content-Disposition: inline In-Reply-To: <20190828112705.5e683693@xhacker.debian> X-Cookie: Oatmeal raisin. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IiVenqGWf+H9Y6IX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 28, 2019 at 03:38:29AM +0000, Jisheng Zhang wrote: > On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote: > >=20 > > Please send a patch which updates the entire comment block to be > > C++ style so it looks consistent. > Do you mean update the following style > A: >=20 > // SPDX-License-Identifier: GPL-2.0 > /* > * SY8824C regulator driver > * ... > as B: > // SPDX-License-Identifier: GPL-2.0 > // SY8824C regulator driver > // ... > I'm not sure which style is correct. But I see B is commonly used > in lots .c source files in other dirs, such as kernel/ mm/ etc. Yes, please - update to style B. --IiVenqGWf+H9Y6IX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1mU80ACgkQJNaLcl1U h9DQbAf9Etbge3YinPdjAxIYYWtuPv6r2hsxMHOm1iKbI1gItlt6aNtFLLilT4kk pv2lx+YEFNZXPP/cuwzsgtKEfMkPEM4KDsz85mY+3v8y350N+RiVIX1nUirnDEYs mWaLoK6D+DrKAPgDgH23zcNH6KoTKNYIPpUfdVQT/jiSXUWXRFDQnsko0e/zb2sw cJjadPq1V8qjMFaR+xAOh/sT+LLKseWgIYgxWBXgKSj/in8Bbpk09Fy+rONS6/D7 5QRfNaUshg+L7SPK+TRfIs39VNnpuGQI3FqzHyzoht4uApVVmbozKx3KOy7SBks1 72cq7+eqDXUZFMnI5nToM26kFj/K9w== =/Kyl -----END PGP SIGNATURE----- --IiVenqGWf+H9Y6IX--