Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 28 Aug 2019 12:59:45 +0200
From:   Krzysztof Wilczynski <kswilczynski@gmail.com>
Subject: Re: [PATCH] x86/PCI: Add missing log facility and move to use pr_
 macros in pcbios.c
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Krzysztof Wilczynski <kw@linux.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <1566989985.26704.2@gmail.com>
In-Reply-To: <20190827224725.GD9987@google.com>
References: <20190825182557.23260-1-kw@linux.com>
        <20190827224725.GD9987@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Bjorn,

Thank you for the feedback.
[...]
>>  Make the log facility used to print warnings to be KERN_WARNING
>>  explicitly, rather than rely on the current (or default) value
>>  of the MESSAGE_LOGLEVEL_DEFAULT set in Kconfig.  This will make
>>  all the warnings in the arch/x86/pci/pcbios.c to be printed
>>  consistently at the same log facility.
> 
> This is slightly confusing.  There are only two messages that didn't
> supply a log level, so the avoidance of MESSAGE_LOGLEVEL_DEFAULT
> applies to those.

Good point.  I will update both the wording and the explanation so that
it would be more accurate and make a whole lot more sense.

[...]
> Might be worth doing this as well:
> 
>   #define pr_fmt(fmt) "PCI: " fmt
> 
> and removing the "PCI: " prefix from the messages.  This would change
> the "bios32_service" output slightly, but I think the change would be
> a good one.

Will do. The v2 have all the improvements. Thank you!

Krzysztof