Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp712554ybl; Wed, 28 Aug 2019 04:20:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFX14Zd5avB1o7WiuyOkXcn2U/NQDmRwc4XtTn/bJSdmW+taQ/mVMrUfygKeyQR/j1kxGr X-Received: by 2002:a17:90a:30e6:: with SMTP id h93mr3613815pjb.37.1566991216456; Wed, 28 Aug 2019 04:20:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566991216; cv=none; d=google.com; s=arc-20160816; b=lBVzK3aI86rqZDVHw5R9hQisz9rC+VXD6aL866vEk0w9QFE4+Bv9NHqe3CBZnpGEB9 l2vYlTkb54d7af/yk92JdZa9X8dJxHZ3w/m7nSMMc1dSygW8NYQKKHlhpsC3TVH38ivb MKeM4FLIt3HBDzRO5sdpdV9JMtTZnQ2wzVwFTDzcO/51Gje/a3/5djUi21Zh9/PyCMWx /MBpNPnAhj6BGlH9XVsXmYAD/nP9Ueg0+RbdG8MwDZhUGLRFNMNzTQZpVzc+CkLEoXW+ yDzHAps6zZg6DfOClp8+/VqIopsJ63sHRMU+XsibxBCoqqob6SNVIRQa6fznDdkzzuVy Hoyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:message-id :date:subject:cc:to:from; bh=XJmw8rJIYl8ASZgjnRhhbtz8wWn60Bv7q4Vqx5l9vik=; b=g8YIeN+qnQOnSh8tvkaIyF4B5jZZzYVSOL5qezPJ9x1uvfz6WpR1ey4eXq1b5GFg1z Y7IjKilpG9xn7VscUNf27PCbBNC6soXmD05MYPuwKtL98YPDpiTlTAyBUkbvb8deEg5g XPysCo4DqzjJCu0fXMKWtDjMLgOGkjv6Qtxni+i34fdAcnMJrUrKI7+YkfCDlwUwiaxo q3emtNQU0S1jv3vG/Jc1Ztuosk3UmsN03mMyJH36Z6YgZp7vZjzgvp59FlpttH7yOH7t xTNFfjP4riUCHICfXgWzLRGwMF1g0oY9m8Idm+wnG0LKLUxMhWewouij6le9t+x0iok3 h7gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="er8Hs2X/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13si1914335pgt.285.2019.08.28.04.20.00; Wed, 28 Aug 2019 04:20:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="er8Hs2X/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbfH1LTJ (ORCPT + 99 others); Wed, 28 Aug 2019 07:19:09 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:10624 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfH1LTJ (ORCPT ); Wed, 28 Aug 2019 07:19:09 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 28 Aug 2019 04:19:10 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 28 Aug 2019 04:19:08 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 28 Aug 2019 04:19:08 -0700 Received: from HQMAIL110.nvidia.com (172.18.146.15) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 28 Aug 2019 11:19:07 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by hqmail110.nvidia.com (172.18.146.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 28 Aug 2019 11:19:07 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 28 Aug 2019 11:19:07 +0000 Received: from nkristam-ubuntu.nvidia.com (Not Verified[10.19.65.118]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Wed, 28 Aug 2019 04:19:07 -0700 From: Nagarjuna Kristam To: , , CC: , , "Nagarjuna Kristam" Subject: [PATCH] soc/tegra: fuse: Add clock error check in tegra_fuse_readl Date: Wed, 28 Aug 2019 16:48:49 +0530 Message-ID: <1566991129-13479-1-git-send-email-nkristam@nvidia.com> X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1566991150; bh=XJmw8rJIYl8ASZgjnRhhbtz8wWn60Bv7q4Vqx5l9vik=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=er8Hs2X/Ea925DFQeeGgKXHWc2hQ+7tN34pibn62S9m1lEbzGT1LCNgrueNPHh0O+ B+InccAVUj9xf6eoT+PTZPnYbOEL7TkRAHmsKTrrEYt+vNnaQZ17S7jYGH5I1s/+TR QjOf9PPzgctp5Rx/QxFTxDzW29S8eaWKz9zdyBlvrPO2r+feuTFPCjbmFWAPrs4Mxe PDfIyOQ+/gwCaIVX9C092S52COr9VQ3uin3qPQlMfEputbs3ieR9J1Hwbh65FU7KWe nUrkwVanq61oyfQ5GcT62MkzBZ/Subw6TWOOnImokdxCsFaxWh03XwjalkJAHNQh5E YjPeJTcqZxNYQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tegra fuse clock handle is retrieved in tegra_fuse_probe(). tegra_fuse_readl() is exported symbol, which can be called from drivers at any time. tegra_fuse_readl() enables fuse clock and reads corresponding fuse register offset. Calling tegra_fuse_readl() before tegra_fuse_probe(), will cause data abort. Add DEFER_PROBE error check for fuse clock in tegra_fuse_readl(), to avoid enabling of fuse clock, before clock is available. Signed-off-by: Nagarjuna Kristam --- drivers/soc/tegra/fuse/fuse-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/fuse-tegra.c index 3eb44e6..21b39b7 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -186,7 +186,7 @@ u32 __init tegra_fuse_read_early(unsigned int offset) int tegra_fuse_readl(unsigned long offset, u32 *value) { - if (!fuse->read) + if (!fuse->read || (PTR_ERR(fuse->clk) == -EPROBE_DEFER)) return -EPROBE_DEFER; *value = fuse->read(fuse, offset); -- 2.7.4