Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190827064629.90214-1-david@protonic.nl> <CAMpxmJV2XC+CK1SfJnH2YuaD2Gh=fiBQY+WPbjnqkvxGW6ZH_w@mail.gmail.com>
 <CAMpxmJXQ=M9PeMFBf70aE5Jgg3c6P2=4QF5CxWpenh+2WXLhnA@mail.gmail.com> <20190828131330.6a28e5cc@erd988>
In-Reply-To: <20190828131330.6a28e5cc@erd988>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 28 Aug 2019 14:16:58 +0200
Message-ID: <CAMpxmJUrvu9f_+-3epZ4iafZ-t0YUAA8E3_Xangc_dBiiCc20A@mail.gmail.com>
Subject: Re: [PATCH 1/2] gpio: gpio-pca953x.c: Correct type of reg_direction
To:     David Jander <david@protonic.nl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C5=9Br., 28 sie 2019 o 13:13 David Jander <david@protonic.nl> napisa=C5=82=
(a):
>
> On Wed, 28 Aug 2019 12:56:28 +0200
> Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote:
>
> > =C5=9Br., 28 sie 2019 o 10:38 Bartosz Golaszewski
> > <bgolaszewski@baylibre.com> napisa=C5=82(a):
> > >
> > > wt., 27 sie 2019 o 08:46 David Jander <david@protonic.nl> napisa=C5=
=82(a):
> > > >
> > > > The type of reg_direction needs to match the type of the regmap, wh=
ich is
> > > > u8.
> > > >
> > > > Signed-off-by: David Jander <david@protonic.nl>
> > > > ---
> > > >  drivers/gpio/gpio-pca953x.c | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953=
x.c
> > > > index 378b206d2dc9..30072a570bc2 100644
> > > > --- a/drivers/gpio/gpio-pca953x.c
> > > > +++ b/drivers/gpio/gpio-pca953x.c
> > > > @@ -604,7 +604,7 @@ static void pca953x_irq_bus_sync_unlock(struct =
irq_data *d)
> > > >         u8 new_irqs;
> > > >         int level, i;
> > > >         u8 invert_irq_mask[MAX_BANK];
> > > > -       int reg_direction[MAX_BANK];
> > > > +       u8 reg_direction[MAX_BANK];
> > > >
> > > >         regmap_bulk_read(chip->regmap, chip->regs->direction, reg_d=
irection,
> > > >                          NBANK(chip));
> > > > @@ -679,7 +679,7 @@ static bool pca953x_irq_pending(struct pca953x_=
chip *chip, u8 *pending)
> > > >         bool pending_seen =3D false;
> > > >         bool trigger_seen =3D false;
> > > >         u8 trigger[MAX_BANK];
> > > > -       int reg_direction[MAX_BANK];
> > > > +       u8 reg_direction[MAX_BANK];
> > > >         int ret, i;
> > > >
> > > >         if (chip->driver_data & PCA_PCAL) {
> > > > @@ -768,7 +768,7 @@ static int pca953x_irq_setup(struct pca953x_chi=
p *chip,
> > > >  {
> > > >         struct i2c_client *client =3D chip->client;
> > > >         struct irq_chip *irq_chip =3D &chip->irq_chip;
> > > > -       int reg_direction[MAX_BANK];
> > > > +       u8 reg_direction[MAX_BANK];
> > > >         int ret, i;
> > > >
> > > >         if (!client->irq)
> > > > --
> > > > 2.19.1
> > > >
> > >
> > > Applied for v5.4.
> >
> > Actually the second patch depends on the first one, so moved it over to=
 fixes.
>
> Btw, they are both bugfixes, IMHO it would be valuable to have them in 5.=
3rc
> if possible... there is some severe breakage there right now.
>
> Best regards,
>
> --
> David Jander
>

Yes, that's why I said I moved it to fixes.

Bart