Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp818224ybl; Wed, 28 Aug 2019 05:53:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqydBE88PJjcUlBW5/xKNoOGK7D3y30rJR80f4odtXwH0Pc3Bb82+65PZ1h9pPNg01t5EGQq X-Received: by 2002:a17:902:720a:: with SMTP id ba10mr3929000plb.231.1566996828517; Wed, 28 Aug 2019 05:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566996828; cv=none; d=google.com; s=arc-20160816; b=LTUXi8fbAM/9e4dzXuOVK64+GA7Gznmcpo89nWVywKJ6joHymlZ7k0UrOzngvH6Iyw qNUc6lEmGu9D5Ij19uRLT6wzUr+IWgD4tvmUA/sPFIqmc803P0eRyD04Kq2QiQHedfHQ jtZeihvrrD/e/TvclHixnMnDL+qa+gQe7YDm1lidlIYHbbc7QcCRWuHIY1zbuXbUI00k 6Uyxq0Pl/JSJOwhoo0fLvq11ZEuSb7Qmo9HCM6xIbqgasRS8HH9/YDGbv7C8meSi06FX AsFRitDqf/X80Vip76VEN9UGhs6Q8mCxPFY9b4ERH08Vv9PvNxZYjkwHw8KQ6ob+HKEU nA6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=XVqiZEbVUqIzK5hY9HIE+w9Yw4YCnwVUWn8KQwWEJ/o=; b=L3XU8Zvh8W6yOluvs3bqSzWJVWkz1HcwIN1U7NAEkdB4pRrVa0XaYJHsdZtSr/hSsN ih6Y6HQPYMVcYV/Oh+A5x9yKcaJ5jnVB0oinBy1Qd4J5pwt6gZujLrsjBF/JfUlhOMDJ 1VQ0b06wGKc4ds9OcsAAT6CGkZNlcZ7nSw8+tAf6gqvEzn/SviO5TnoiAXh6gulbvLeO wx9jHqrY2uSsevzxmDBdC4bSaPhzkxZ3BxxGoTkvEVBcNVgEqihoiAFPUUX0ia4hyzVC E+1kl8SCuf4/dJ2EQpDI7BS9uMMylMlNGSh9jHw+6cyBSsbb7Xx8eazTMvXvK1GEawo5 nZtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="j/ZkTZmH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z20si1806018plo.159.2019.08.28.05.53.32; Wed, 28 Aug 2019 05:53:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="j/ZkTZmH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbfH1Mwo (ORCPT + 99 others); Wed, 28 Aug 2019 08:52:44 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43302 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfH1Mwn (ORCPT ); Wed, 28 Aug 2019 08:52:43 -0400 Received: by mail-lf1-f68.google.com with SMTP id q27so2054094lfo.10 for ; Wed, 28 Aug 2019 05:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XVqiZEbVUqIzK5hY9HIE+w9Yw4YCnwVUWn8KQwWEJ/o=; b=j/ZkTZmHKtb+C6yykay6Lk89TOZ2nUMHdfIDdtlO3/glkjnfikIYS28NL2SG8TTJgs zaFgS4RwSSejdCGrhsS4ul+I8b6oSeCtpK4UBcERRoeQn1cs6AYlz+EbRcAN+fD38Vwi uNGYpuHx5n5iVdfhs38LAFPqeS9CaugquJL9Up1fPrU1vDd5RVAH2Sz0oKDHDqMQ3UU4 r5KZS01C8wSJUawPbF/GeSys7s02FLBfU70H6f0Rz0LziJuBQNUyKBIppFqFqCPi4/XB xv2nnTa6+37DxCcKyOOhHTeKyCepv77Atwv/mavdOHSUq9IIS6QjbQwDuqf5bIbFCIl6 is4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XVqiZEbVUqIzK5hY9HIE+w9Yw4YCnwVUWn8KQwWEJ/o=; b=V1Pp2mupwTuKN1DGROW6sPC1aJLcccUX+F/CKtarQRBD2gNvK7wSmGvkLpjt2ZqbCj mE5Kjp8jbW5caq1t/vJq05ZJSX3/vjsFUCGGo+F+6eYKK6fYC6a9fGawPG2LK8rEf638 ncODZ9HSfSgJX6EbKFow9gmjL/GRfCuRVLwQ7Aet4nR0L6+w8ANfT+57vizXFig4qiYZ t5ZcDnyNC7+aCXAQmYyeO+bgxZ1HrniWsqcdPR9FM+c8rdUaUWOxPsbNyOcxY3IOYB8M CZW7g6doXDjVQXFBn4djhHBXMyRESF2IFG6E7LAMmWaZTZ9rfZqXZx5aUF15PbKZtjO1 ia0w== X-Gm-Message-State: APjAAAWXeVDlG7LghtHSx06OTNRXDNg5qDM1183ydlPp7FomRh9AR5uX /dQhrnUgBAK/cOtu4gkxcHaJ+Wl/TARI63oFLZUBmw== X-Received: by 2002:ac2:5c11:: with SMTP id r17mr1699777lfp.61.1566996761734; Wed, 28 Aug 2019 05:52:41 -0700 (PDT) MIME-Version: 1.0 References: <20190825150558.15173-1-alejandro.gonzalez.correo@gmail.com> In-Reply-To: <20190825150558.15173-1-alejandro.gonzalez.correo@gmail.com> From: Linus Walleij Date: Wed, 28 Aug 2019 14:52:30 +0200 Message-ID: Subject: Re: [PATCH] mmc: sunxi: fix unusuable eMMC on some H6 boards by disabling DDR To: =?UTF-8?Q?Alejandro_Gonz=C3=A1lez?= Cc: Ulf Hansson , Maxime Ripard , Chen-Yu Tsai , Greg KH , Thomas Gleixner , linux-mmc , Linux ARM , "linux-kernel@vger.kernel.org" , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 25, 2019 at 5:06 PM Alejandro Gonz=C3=A1lez wrote: > Jernej Skrabec compared the BSP driver with this > driver, and found that the BSP driver configures pinctrl to operate at > 1.8 V when entering DDR mode (although 3.3 V operation is supported), whi= le > the mainline kernel lacks any mechanism to switch voltages dynamically. (...) > the kernel lacks the required > dynamic pinctrl control for now This is not a pin control thing, the I/O voltage level is usually controlled by a regulator called VCCQ, if the selection of the voltage rails is inside the pin control registers, see the solution in drivers/pinctrl/sh-pfc/pfc-sh73a0.c where we simply provide a regulator from inside the pinctrl driver to make things easy for the MMC core. Do this thing! If you don't have time to fix it up properly right now I would slap in a big FIXME in the code so people know this needs to be fixed properly. Yours, Linus Walleij