Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp881416ybl; Wed, 28 Aug 2019 06:42:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzq5avFpxtOn0hPBgyz3JSFNQaTFxYoBhJdU+NSFYuGHtJDnPFzsGsbcH0N2jgWEAvGHfzt X-Received: by 2002:a17:90a:de0f:: with SMTP id m15mr4385551pjv.18.1566999765295; Wed, 28 Aug 2019 06:42:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566999765; cv=none; d=google.com; s=arc-20160816; b=lFk/XKmR3WLbfPWVKxVVRBkgxuayyN5WxswyC94hB4RInuUGplPYcDF+KYgAFUywOi 8EsUuNbRwJyMmwg0V612PlpP4pI9a9+C1jWiuYGIDFl3cpOtMAXNsorBDmC9UkQ+2kJ6 tuxcAJz6wBm6AGCLg5VLisYlKoaxdZc0pRK0ZkGUcoDMPjuV8Vt2tAYIxwGs+1aKxNqm an4oszKseqoOD2WHW3vzgaLttC0aEHCvvKlvy4rbn7JRa1mT5aLOnl/oL1GF4+Y1+1Zy NlJrwuhu/vXiTzQP/oQEiTr0lDoER3Br2IMl1QJplAHnyuLskH6wKCO7yHCJi6lHp+Ij ryvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=fXrm6MVvpZt5LXFe7946B94kIviP6HgTCq9XdgMyaIk=; b=uiYljI8DSmvs8TLsB7bXGnXlctCEPfr0EjTqMacrTYobY7Elfy5ietnzvp2vLMmNdF i1ce45XHVWGJTj3Ea7i1eOBMLH3e81mdpE96hIvVfMeP/xT1VnbIp4yvQcOK8Xl3zNkO a6Eyrf6hP0KEYBifIqDOMw3xvUFEUHQtw25pMVrLRGU3YdKEaedzyGs2Vbf5AXpnHlU1 H0FxMMLQWMKyQ4aQ3UgvEaeLQDSQ4Yoh4kRYds/lEjhGAqTuegqQct6Cr4eJU/yeIyCz zpNwvRqA72QXfFDhYtRg9WUX1BikncYORBfUG/4V/pfYm4NAkJwqNpuz/YEhAEFo3H6d A20Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si1939904plt.13.2019.08.28.06.42.28; Wed, 28 Aug 2019 06:42:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726909AbfH1Nja convert rfc822-to-8bit (ORCPT + 99 others); Wed, 28 Aug 2019 09:39:30 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53103 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbfH1Nja (ORCPT ); Wed, 28 Aug 2019 09:39:30 -0400 X-Originating-IP: 90.30.228.116 Received: from windsurf.home (atoulouse-659-1-185-116.w90-30.abo.wanadoo.fr [90.30.228.116]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id E361220009; Wed, 28 Aug 2019 13:39:27 +0000 (UTC) Date: Wed, 28 Aug 2019 15:39:26 +0200 From: Thomas Petazzoni To: Krzysztof Wilczynski Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c Message-ID: <20190828153926.1d8d9d7b@windsurf.home> In-Reply-To: <20190828131733.5817-1-kw@linux.com> References: <20190826151436.4672-1-kw@linux.com> <20190828131733.5817-1-kw@linux.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, 28 Aug 2019 15:17:33 +0200 Krzysztof Wilczynski wrote: > Move the static keyword to the front of declarations of > pci_regs_behavior and pcie_cap_regs_behavior, and resolve > the following compiler warning that can be seen when > building with warnings enabled (W=1): > > drivers/pci/pci-bridge-emul.c:41:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] > const static struct pci_bridge_reg_behavior pci_regs_behavior[] = { > ^ > drivers/pci/pci-bridge-emul.c:176:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] > const static struct pci_bridge_reg_behavior pcie_cap_regs_behavior[] = { > ^ > > Signed-off-by: Krzysztof Wilczynski Acked-by: Thomas Petazzoni Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com