Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp953211ybl; Wed, 28 Aug 2019 07:39:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDjI8AKJwj+ai7raFQFkT6iKcMrEyqAVSOlxtQkqUd7gUV7o3z+XPX1G2HRI1O+o3V+EcB X-Received: by 2002:a62:1a45:: with SMTP id a66mr5212939pfa.142.1567003155066; Wed, 28 Aug 2019 07:39:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567003155; cv=none; d=google.com; s=arc-20160816; b=f2Q3QymlshxLul3FbcU4+HbcRaVjI0osDjkZCG0zgtJF6Qfm1eQxOD9Dm+DAih3z3m spNcrZmrqzDADVM51MCibGFxPpIvNJXij7KuYs3ey6eNBql/IKqD5d5NvYwvJKaOY1MG gwbqj9ZVJLa1ygjtkorJkIhwFWBXWFmgbiuTs2pyS6rMPpboxrYKWgSQhoedgmTJ+PCi xIQK6uYfRFq1z7ZgYLPRSMVdrJWStWuHFm4M05SaMBYPfYlKS5T6qKlJbCVT7yrHMLP+ A1eSZe3ah8Jqoaa6WA+MfhMr3fpfCjHALdXO1vJQU73KydrRbUJW9RPNLI6vrfq3mWaq 4fnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=FA8+13cQRg8kfRTiJt5DH1v2pvWPDM1dgj2y3yppfoQ=; b=y9+QgRgiiVW1D3dXDj0E2P/CJUFUY00J5hR5TCZEpt9jZVWr6tmbpeZf53IU/lb28j xQNAXreZaRFvlwYIuHq42VA4rY9l1InW6AmvpsDVzrKjOYAH+ypT7pPsqYffAckM+8w5 McpPgH014mgl5AfJRwokUtTZq4myFWOoSsNPLHveyMOVylV/9oIh2Yt7459qPHjUmV8A Aj2jTxcftNzlz1UpQxSOkSYB2/jMuTUzKD/0IfY0a+3tSsgZTJLXB5YhjsBHEKub9P6+ T6I6vle8GiLszqnuC38IgJg1UEmhCufx+RYR1mQUgQsdDPvIesXebTSfmt/hjj8QhV8f 2CVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si2057701plo.298.2019.08.28.07.38.59; Wed, 28 Aug 2019 07:39:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfH1OiA (ORCPT + 99 others); Wed, 28 Aug 2019 10:38:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:52820 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726315AbfH1OiA (ORCPT ); Wed, 28 Aug 2019 10:38:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1DBC8ABED; Wed, 28 Aug 2019 14:37:59 +0000 (UTC) Date: Wed, 28 Aug 2019 16:37:57 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexander Viro , "Dmitry V. Levin" , Thomas Gleixner , Steven Rostedt , Max Filippov , Firoz Khan , Nicholas Piggin , Hari Bathini , Joel Stanley , Andrew Donnellan , Breno Leitao , "Eric W. Biederman" , Allison Randal , Michael Neuling , Andrew Morton , David Hildenbrand , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Disable compat cruft on ppc64le v2 Message-ID: <20190828163757.123e0eba@naga> In-Reply-To: References: X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Aug 2019 13:08:48 +0000 Christophe Leroy wrote: > On 08/28/2019 10:30 AM, Michal Suchanek wrote: > > With endian switch disabled by default the ppc64le compat supports > > ppc32le only which is something next to nobody has binaries for. > > > > Less code means less bugs so drop the compat stuff. > > > > I am not particularly sure about the best way to resolve the llseek > > situation. I don't see anything in the syscal tables making it > > 32bit-only so I suppose it should be available on 64bit as well. > > > > This is tested on ppc64le top of > > Really ? Really. It boots with the unused variable. It might depend on some config options or gcc features if unused variables are fatal. Thanks Michal