Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp955303ybl; Wed, 28 Aug 2019 07:41:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkdEgYjfU9llPTbplbfrvEe5NLi9H2sTCoQiuo0XdbTN9vRyc6wchtcw4zRFYmSg+mxeTz X-Received: by 2002:aa7:81c1:: with SMTP id c1mr4931918pfn.78.1567003262249; Wed, 28 Aug 2019 07:41:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567003262; cv=none; d=google.com; s=arc-20160816; b=QbQTbjQA4RbCbjvfl7yTQVDR+AnZHVdsdrI8AJ9qi9OyEtEZRo6KEhA8AzYB+p8a+e 0uisnYICg5K3cgmQIV6MY1Tse4xLwsdCjwTCnKDIOi5Jh5JV+FTiNsd0eEtH9Z0+9M+w fo5KZ6d2SUI0OP3GBz1tTKwKG6PBE+5joUlDLTwHnflP5Kx0UKhke97m2gWAMszkIvuw QISQwtuwMxEC6OcjL5N1BVKwx+xG+8gCm7QxRnJOMaxdxUMJcjUW2ViQQ6zB7J3Xj6v0 EtywsYlTXydlYf3QUjYP7D52I/qsni5x76hwe1rZOwLcOwOosP93E5Dt6mpnGgCgfIgs TuAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=rnUcnRNxRPDGJZHh++1R5IpPU40w9o2KwMfVhfGlUQs=; b=cai4NknOYYoj8Anad+KnEOMG02tvNtrnunnrtNj9rHGlpbiOfcdZaWleBeztIuBfB+ RxXCD8a9h2n7vS9WDMbTuwGOX+Iy7PGmplPCOhmdfMCKZeg13gTpH1feY1Nq4sZpA/sz d+UFdzQHjUoStyfoDBQMujfSykgok47Pe9lZataiLuP3CEGDAmhkkIIxSgWy1J4uuNS7 RQbNSklYfxtdWC0wfN0dM1x/o/xtEjdLEXVea4EScQ64d5dHQXHugIOJJqolfy0kFMVJ AqfgCPNI27miXc+Tn+GzWgF1uQ+7W6tlaH7bMR8IxFplCPAJXrUZDOXdITbix/jgbtpk Itgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30si2052519plb.256.2019.08.28.07.40.45; Wed, 28 Aug 2019 07:41:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726583AbfH1Ojx (ORCPT + 99 others); Wed, 28 Aug 2019 10:39:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34520 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfH1Ojx (ORCPT ); Wed, 28 Aug 2019 10:39:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47863111A3D2; Wed, 28 Aug 2019 14:39:52 +0000 (UTC) Received: from amt.cnet (ovpn-112-8.gru2.redhat.com [10.97.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB330601AC; Wed, 28 Aug 2019 14:39:49 +0000 (UTC) Received: from amt.cnet (localhost [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 039CE105139; Wed, 28 Aug 2019 11:39:23 -0300 (BRT) Received: (from marcelo@localhost) by amt.cnet (8.14.7/8.14.7/Submit) id x7SEdJ7Q013745; Wed, 28 Aug 2019 11:39:19 -0300 Date: Wed, 28 Aug 2019 11:39:18 -0300 From: Marcelo Tosatti To: "Rafael J. Wysocki" Cc: Wanpeng Li , Paolo Bonzini , "Rafael J. Wysocki" , LKML , kvm , Radim =?utf-8?B?S3LEjW3DocWZ?= , Linux PM , "Michael S. Tsirkin" Subject: Re: [PATCH] cpuidle-haltpoll: Enable kvm guest polling when dedicated physical CPUs are available Message-ID: <20190828143916.GA13725@amt.cnet> References: <1564643196-7797-1-git-send-email-wanpengli@tencent.com> <7b1e3025-f513-7068-32ac-4830d67b65ac@intel.com> <20190803202058.GA9316@amt.cnet> <20190826204045.GA24697@amt.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 28 Aug 2019 14:39:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 10:45:44AM +0200, Rafael J. Wysocki wrote: > On Wed, Aug 28, 2019 at 10:34 AM Wanpeng Li wrote: > > > > On Tue, 27 Aug 2019 at 08:43, Wanpeng Li wrote: > > > > > > Cc Michael S. Tsirkin, > > > On Tue, 27 Aug 2019 at 04:42, Marcelo Tosatti wrote: > > > > > > > > On Tue, Aug 13, 2019 at 08:55:29AM +0800, Wanpeng Li wrote: > > > > > On Sun, 4 Aug 2019 at 04:21, Marcelo Tosatti wrote: > > > > > > > > > > > > On Thu, Aug 01, 2019 at 06:54:49PM +0200, Paolo Bonzini wrote: > > > > > > > On 01/08/19 18:51, Rafael J. Wysocki wrote: > > > > > > > > On 8/1/2019 9:06 AM, Wanpeng Li wrote: > > > > > > > >> From: Wanpeng Li > > > > > > > >> > > > > > > > >> The downside of guest side polling is that polling is performed even > > > > > > > >> with other runnable tasks in the host. However, even if poll in kvm > > > > > > > >> can aware whether or not other runnable tasks in the same pCPU, it > > > > > > > >> can still incur extra overhead in over-subscribe scenario. Now we can > > > > > > > >> just enable guest polling when dedicated pCPUs are available. > > > > > > > >> > > > > > > > >> Cc: Rafael J. Wysocki > > > > > > > >> Cc: Paolo Bonzini > > > > > > > >> Cc: Radim Krčmář > > > > > > > >> Cc: Marcelo Tosatti > > > > > > > >> Signed-off-by: Wanpeng Li > > > > > > > > > > > > > > > > Paolo, Marcelo, any comments? > > > > > > > > > > > > > > Yes, it's a good idea. > > > > > > > > > > > > > > Acked-by: Paolo Bonzini > > > > Hi Marcelo, > > > > If you don't have more concern, I guess Rafael can apply this patch > > now since the merge window is not too far. > > I will likely queue it up later today and it will go to linux-next > early next week. > > Thanks! NACK patch. Just don't load the haltpoll driver.