Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>
Subject: Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end
 exports
Thread-Topic: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end
 exports
Thread-Index: AQHVXavZqxXcfLyzmkeft6WFMi/zb6cQobAA
Date:   Wed, 28 Aug 2019 14:40:25 +0000
Message-ID: <20190828144020.GI914@mellanox.com>
References: <20190828142109.29012-1-hch@lst.de>
In-Reply-To: <20190828142109.29012-1-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [142.167.216.168]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e9b0e95d-f896-4947-ddcd-08d72bc5a9b6
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB5246;
x-ms-traffictypediagnostic: VI1PR05MB5246:
x-microsoft-antispam-prvs: <VI1PR05MB524688DFE20EED13B8873181CFA30@VI1PR05MB5246.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 014304E855
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(199004)(189003)(4326008)(446003)(486006)(476003)(6506007)(2616005)(11346002)(4744005)(6486002)(8936002)(6512007)(99286004)(81166006)(102836004)(186003)(26005)(6436002)(2906002)(386003)(316002)(66066001)(52116002)(5660300002)(81156014)(8676002)(478600001)(14454004)(305945005)(66446008)(64756008)(6116002)(54906003)(66556008)(66946007)(7736002)(229853002)(256004)(1076003)(6916009)(71190400001)(71200400001)(53936002)(76176011)(33656002)(25786009)(36756003)(3846002)(66476007)(6246003)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5246;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: eyNg4HLZ52LGAV0ouvh0lK+YUWuSz+vviASvTi6u4tyfRkS+6crc8iuHsljQ85TIlyyZ2x67UYnb4k+XdopeWbFkEGkqXgOxvsB9Ufc3q8V7xdpca3PlD6/O920ZuL6nACpYjRxCQm83QoQnJaFhYvi2wIIK3EFtmYaDp//b5swB1lHKRzPNPhhd5XyietoaGNUcXcHgTVPfMZPGkV0tuVkq35Ott32oLpI0CEOx5UX34FoNrTC/uwQhZTCWcjLJ4uJ47JyvTE5jMk4KsnY7SSfjYn0GceWcrR2sZl/5shBSBlp4SF42RVQygjf/urBmGf9mEDLHswSEXIGb5+3geGwoHkAO7U6h1M+QmZIuGFAXt/pP/na4omnpj/TmXi9wqlfwgOXy8wjq6nBLEAebiO4wJVpCMiRA7rzg6QhPGLk=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C1EA082325B7104A864499B49ABCE3F5@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9b0e95d-f896-4947-ddcd-08d72bc5a9b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2019 14:40:25.3928
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: paxkgAgF/TdQvDco2/uuuH66Km0esr3MC2D1DEP+cnOd7FeoGG30D6ipyiwCCcAe4NujhpWsU5QDviXZjvfESw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5246
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 28, 2019 at 04:21:09PM +0200, Christoph Hellwig wrote:
> Bo modular code uses these, which makes a lot of sense given the
> wrappers around them are only called by core mm code.

/Bo/No/

> Also remove the recently added __mmu_notifier_invalidate_range_start_map
> export for which the same applies.
>=20
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>  mm/mmu_notifier.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
> index 690f1ea639d5..240f4e14d42e 100644
> +++ b/mm/mmu_notifier.c
> @@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
>  struct lockdep_map __mmu_notifier_invalidate_range_start_map =3D {
>  	.name =3D "mmu_notifier_invalidate_range_start"
>  };
> -EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
>  #endif

I inlined this hunk into Daniel's patch from yesterday

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Applied to hmm.git..

What about:

EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);

elixir suggest this is not called outside mm/ either?

Jason