Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1050500ybl; Wed, 28 Aug 2019 08:58:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8wqNMDc783cTTpuWnZ4FOn+QEDC1HeB8vTSEXFWWYbU27msOsxo9aa0oJz1njKjwxYVUv X-Received: by 2002:a63:60a:: with SMTP id 10mr4019743pgg.381.1567007887749; Wed, 28 Aug 2019 08:58:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567007887; cv=none; d=google.com; s=arc-20160816; b=A3fG1nsQFIh7OUvbzQRiwssz1zTA0zWWG/PgFkmHJC6RDUyBpMdf7lO2JURev3jtW+ qQ9G1/RfiNoWbd5mG8E9LhyeTnP/8a5T8RSYGoP7AWX6OshY67hyVzgn9zfsC+O/pSdI QmGmI00331gXp2hChLwtysehJfMvbOefXMBJ1TfGdLXKA6UOZBdHgepekZa/M4QYeZ3y TL43bhDCeG+7sfhoFH5j8JmdolSEwhwicbCcwpUM+TBldvaqiCSlmHr0hcCpH2pyqjLo MCVfx813wyYvdEGCrlfBrc3aq/K64i4MBX/gQU0Af0Dgfg0kyFRzKOpIkSWkNzBVRbGo mVlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=VuzzaQ1pwy7g4qsUbgMwsQmX88DPQdeglUU6DWjqQrM=; b=eyxiFoMCJFjwzqpDSkMzrJST3CeRzw9FSTWkl7xeGRgMNXLavF/8htCkStKYx4iMU/ JF5qUbT0ktethvpfrtOkxfXJ4RXbyxnlgsWfJ3VR6CSTpfVoX7fRibDFAmgmALdq62r0 9iVyUoff6NWRlGfaFyy+Dme14lYrTrtnq7N0WnpmwjY9l/9yEy4ZPkPxJDu0gDwfthOa UkAoe1GjTGaH1IdZGPwfRWsNh39MRbS4q5n5x4PHj5e35eGrFPHPa4Rj0a8liB69WH3H cx/uFXmnicCsIoeRmG388TL3Mbh0tNyjL0Yd4j6cIKwwHKmYt85hKD+Ss1YcE5gYWfNg QJag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si2159065plt.296.2019.08.28.08.57.50; Wed, 28 Aug 2019 08:58:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfH1PzZ (ORCPT + 99 others); Wed, 28 Aug 2019 11:55:25 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:18766 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726513AbfH1PzY (ORCPT ); Wed, 28 Aug 2019 11:55:24 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7SFqPgs127386 for ; Wed, 28 Aug 2019 11:55:23 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2unu52mgrs-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 28 Aug 2019 11:55:23 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Aug 2019 16:55:21 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 28 Aug 2019 16:55:19 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7SFsuJp38339040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Aug 2019 15:54:56 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19B194C040; Wed, 28 Aug 2019 15:55:18 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB5384C04E; Wed, 28 Aug 2019 15:55:16 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.129.156]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 28 Aug 2019 15:55:16 +0000 (GMT) Subject: Re: [PATCH v1] sefltest/ima: support appended signatures (modsig) From: Mimi Zohar To: shuah , linux-integrity@vger.kernel.org Cc: Thiago Jung Bauermann , Petr Vorel , Jessica Yu , Dave Young , linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Wed, 28 Aug 2019 11:55:16 -0400 In-Reply-To: <4a9f9cd3-c550-98e4-1513-14ef161c34c2@kernel.org> References: <1567005240-12912-1-git-send-email-zohar@linux.ibm.com> <4a9f9cd3-c550-98e4-1513-14ef161c34c2@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19082815-0008-0000-0000-0000030E4D8A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19082815-0009-0000-0000-00004A2C8E74 Message-Id: <1567007716.6115.59.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-28_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=933 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908280161 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-08-28 at 09:53 -0600, shuah wrote: > On 8/28/19 9:14 AM, Mimi Zohar wrote: > > In addition to the PE/COFF and IMA xattr signatures, the kexec kernel > > image can be signed with an appended signature, using the same > > scripts/sign-file tool that is used to sign kernel modules. > > > > This patch adds support for detecting a kernel image signed with an > > appended signature and updates the existing test messages > > appropriately. > > > > Reviewed-by: Petr Vorel > > Signed-off-by: Mimi Zohar > > --- > > Thanks Mimi. This commit log looks good. My Ack for the patch > to go through the IMA tree. > > Acked-by: Shuah Khan Thanks! Mimi