Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1087589ybl; Wed, 28 Aug 2019 09:26:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqz26KfZbXxO+j1nj/7/JanK9C0yYEtOx63QYBtiT33OxStYCFB2G2QVyEj+H5hbaefIG1I2 X-Received: by 2002:aa7:9907:: with SMTP id z7mr5486568pff.13.1567009587082; Wed, 28 Aug 2019 09:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567009587; cv=none; d=google.com; s=arc-20160816; b=eAqbbC4L7tYStyzkVduqbjuearq3LZUeyLFEz+/QM7meDFm1rwYpmvogpTPiyDOvc6 okTMpGkcAC2xFZ8BKjtrLGmiGaZvwLvLNa3tx/o06RYljRYx+7q4gClDEEIzNbyxzCo6 +ybnulFKGSPwwJOeiqPalBVUH/CcX5uSu1qgJmsHhVDjJWz9VGW7W/1fftllzcpZQUcm FXpr6BpE8ShlHuBN4mCpwEHG/bxfy7Q5UbuXzvF2z56W8GEV2JAJoHgRTD+qPvnXMcII gxO6SaAOkQs3cK48Wwku07HkSX4UDPAu3T+3Z7aBKUDsSwuc9RilIgx/bKqyMm+fbKYG wPxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=u1lLimGMYhfmCL3MKSeS32GLZr2shj1mXSQdp3B8730=; b=dH+jK7rAVUUmX9qe6jH+NIxxLpm569McegRxrJ+1m6jt5UD+RpohXbEy8c7/MwS0ec uHlQWyuxfGCzhAoMSrFpM8NdSwtfXu+cRqikszdBDXeTAjnu5q+k1As1zchYVTGCmEpG I/w7w5nRxK5pyCbor6Vpk2y6CUVXErxsYDjbwvkB0QJhjQcxNIZCYqjs2NLtVcTTvpHu q9NiEp2MhyyiEruj6FC0oQpueLAD4ExzBQFGm7tGg1vOxaJGhHxUnfEIoVEhOKDROIRy 0uwtOl+hYQ45w4sUsFlaLTr9XIMuF9Ml9usM0jA11SXgmW3Xm/GZJY9o3Kd3DncEYFpY 5lNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ofSVl+bl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si2203496pjv.24.2019.08.28.09.26.10; Wed, 28 Aug 2019 09:26:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ofSVl+bl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfH1QYh (ORCPT + 99 others); Wed, 28 Aug 2019 12:24:37 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:42676 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbfH1QYh (ORCPT ); Wed, 28 Aug 2019 12:24:37 -0400 Received: by mail-io1-f67.google.com with SMTP id e20so683486iob.9 for ; Wed, 28 Aug 2019 09:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u1lLimGMYhfmCL3MKSeS32GLZr2shj1mXSQdp3B8730=; b=ofSVl+blw2/4lc/BpfotBwPm68T0GUBhYn2TVoo6BIKVGtOfIrFEKZK+pVGkY/id/v ApBscizv0pvB/os00gahz9wmDuYhvyhgHdpHtTjg67O3SsZexQvBNjhYQQzNP5vqzl+Y dk47lAClDeZDmUPm5Oko6rc1i+IwiSHtE4hewoKm2dLTdAqfmSQSqhNgpAHrzX9Ce/it dn3fDMrFnlrzDR6odgC13+w31g9sVRAqL2FBT+aLM0r99ae4Au+q1ulsCQRbYF4MV4vD RkLlQbA3fthbHRtpaUIa+qSgrs1ltTsqUvMO4hb5xa6gnrMdBYsgBkuKY9P2VQ6Uq7rI T2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u1lLimGMYhfmCL3MKSeS32GLZr2shj1mXSQdp3B8730=; b=mZgEiCNLFlvjOqMXvoGmEOoLx6ro9/cW7Nue4wc+Kng0Vg4ZC9LI4973JDgrZJsCIz Q1izey4XH/ybx/sije7i+r4BMH6LhfDUF6iygk3l9f+t1hBtJE1Ou8nWGCInUZOG9cGv gy8jUNiuJWgSJErCQ6kldsSiKS7R+9v4euc0MVEJP+YDEFzikcoZFQq9vsBAen15ENzd WFeIZWG2XSXjsTQy1zNZy9QfgW1EE64q137LAAB4IwukH9tQC4JO/HhL1+QWiHOwL5QO w7Wws2bdRe/sUOCy6OebkeUnQNX0QsY0PS60XHg/irZ6lk+RH6YjfstdWgSPgjUcpQ9A eWyg== X-Gm-Message-State: APjAAAVsmQ9WdkGD4lhFd4OsaJ5guP7hkNK8/8uDT+W6XTueMrfqf1bD wlm+VK6TPRS8m/pu9bXDJLK7mFpmfJGHKjFPtRUGQQ== X-Received: by 2002:a5d:8f9a:: with SMTP id l26mr1849026iol.26.1567009475969; Wed, 28 Aug 2019 09:24:35 -0700 (PDT) MIME-Version: 1.0 References: <20190828075905.24744-1-vkuznets@redhat.com> <20190828075905.24744-3-vkuznets@redhat.com> In-Reply-To: <20190828075905.24744-3-vkuznets@redhat.com> From: Jim Mattson Date: Wed, 28 Aug 2019 09:24:23 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] KVM: x86: announce KVM_CAP_HYPERV_ENLIGHTENED_VMCS support only when it is available To: Vitaly Kuznetsov Cc: kvm list , LKML , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Sean Christopherson , Roman Kagan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 12:59 AM Vitaly Kuznetsov wrote: > > It was discovered that after commit 65efa61dc0d5 ("selftests: kvm: provide > common function to enable eVMCS") hyperv_cpuid selftest is failing on AMD. > The reason is that the commit changed _vcpu_ioctl() to vcpu_ioctl() in the > test and this one can't fail. > > Instead of fixing the test is seems to make more sense to not announce > KVM_CAP_HYPERV_ENLIGHTENED_VMCS support if it is definitely missing > (on svm and in case kvm_intel.nested=0). > > Signed-off-by: Vitaly Kuznetsov Reviewed-by: Jim Mattson