Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   Ayan Halder <Ayan.Halder@arm.com>
To:     "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
CC:     Liviu Dudau <Liviu.Dudau@arm.com>,
        Brian Starkey <Brian.Starkey@arm.com>,
        "malidp@foss.arm.com" <malidp@foss.arm.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>, Mihail Atanassov <Mihail.Atanassov@arm.com>
Subject: Re: [PATCH v2] drm/komeda: Reordered the komeda's de-init functions
Thread-Topic: [PATCH v2] drm/komeda: Reordered the komeda's de-init functions
Thread-Index: AQHVXbFOPtkOyMBO7Em37TZu77ub2acQt18AgAAbGAA=
Date:   Wed, 28 Aug 2019 17:35:04 +0000
Message-ID: <20190828173504.GA21758@arm.com>
References: <20190828145945.15904-1-ayan.halder@arm.com>
 <20190828155806.GA7020@jamwan02-TSP300>
In-Reply-To: <20190828155806.GA7020@jamwan02-TSP300>
Accept-Language: en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Ayan.Halder@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [217.140.106.54]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: da2da4e3-a49b-4dc5-49f0-08d72bde1885
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM0PR08MB5044;
X-MS-TrafficTypeDiagnostic: AM0PR08MB5044:|VE1PR08MB4958:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <VE1PR08MB4958ABDDC99DE843E472C48BE4A30@VE1PR08MB4958.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:480;OLM:480;
x-forefront-prvs: 014304E855
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(199004)(189003)(478600001)(2906002)(4326008)(1076003)(8936002)(14444005)(186003)(256004)(102836004)(6486002)(476003)(6512007)(44832011)(66066001)(76176011)(5024004)(305945005)(446003)(6246003)(37006003)(8676002)(66556008)(26005)(66446008)(6116002)(64756008)(66476007)(6436002)(66946007)(316002)(14454004)(71200400001)(25786009)(52116002)(54906003)(7736002)(81156014)(33656002)(81166006)(71190400001)(86362001)(486006)(6862004)(3846002)(6506007)(5660300002)(2616005)(99286004)(11346002)(6636002)(229853002)(386003)(53936002)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB5044;H:AM0PR08MB5345.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: x2Rip5b0M2bNurK6+zyh9o5kUlrC6B0HyNE+5n1jdXZ0d1lOmWGlw1atYs1ncrImYf2hQzK72uFbt22Ji8HMRUq6zEF6PhuKjK7HCwmWpJDQmNk1dk5QLN8JbDx4fzqBR74XrxwNx4GB1zaAYopnvdNc4dcCUk/B9nOTfrbu5KJ7hF4dD0jUcUJWcpQsakImmDBbZeeYvZHge0Jsjf0u/xQsj8EGWw6ivy/aN4jIQ8om7eIgILyDuZSb3D10cbQfJIVDOyFm0mR8LNB3Ry8Jnua2CWkYhrVBXdHZXX/uhPmmMy7mi3gTlT+xGo1gxZaws0tdkfQfeKGq069wwYWhCelZwQ21JmNa27yIDXUImwKi+5pRUr0po/ysPWq8hxWyRr3p+5uU1EPvlRhWb8NAmJ3NbdmTKrvzGVx0d53tQKE=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <96B089E83AC54C42A5115C3580979B48@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5044
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Ayan.Halder@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(376002)(136003)(396003)(346002)(39860400002)(2980300002)(199004)(189003)(26005)(478600001)(5024004)(102836004)(14444005)(386003)(76176011)(186003)(229853002)(50466002)(66066001)(47776003)(86362001)(6506007)(26826003)(99286004)(81166006)(37006003)(81156014)(6636002)(305945005)(8936002)(3846002)(97756001)(6862004)(70586007)(8676002)(1076003)(6486002)(25786009)(8746002)(6116002)(2616005)(476003)(22756006)(14454004)(126002)(23726003)(63370400001)(63350400001)(36756003)(486006)(336012)(36906005)(7736002)(5660300002)(316002)(46406003)(76130400001)(2906002)(70206006)(33656002)(4326008)(356004)(446003)(11346002)(54906003)(6246003)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4958;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 4949fa36-80ca-49cc-bbcc-08d72bde0ffc
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB4958;
NoDisclaimer: True
X-Forefront-PRVS: 014304E855
X-Microsoft-Antispam-Message-Info: vBoF1lYXIDTiyp/Xjw1/UcHB5QT6YgePPi6xDFINSrvKMMNOO6njv76xfvHSRxtCBqvO96FMfCOkWP6JNVPzdF1LGM9yTygs8cMyBLF23ThASMs3nYEx4OpOzDBAUVfhBBrlIHTEeT8U3i5331b2qII8NFNm4WrXKqWLXO51LJj6KSL17ohgHMHGv8PPVsFysw0d7CVTrvErrK+bk7Ig4muGgRH0ESQxYlyxT/kN4XS+huLX8Y5t4foaREAgoq6XmiLXxP3su3hRRrNNDx/kpwcY1s6wXijr4Az5v5LvMWKUvrP9n+x7Y2w2sEBpJbQtf5yE1IXznjz1AmnlAuZRKSP+t2eeOf38zmArf08E6dhXxKDv++/em8rG7eKWZkp6HZjXdtgv6XmVxWlCw2rNWLyDHe9Uik/jXduXmGrMIZQ=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2019 17:35:18.8685
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: da2da4e3-a49b-4dc5-49f0-08d72bde1885
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4958
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 28, 2019 at 03:58:12PM +0000, james qian wang (Arm Technology C=
hina) wrote:
> On Wed, Aug 28, 2019 at 03:00:19PM +0000, Ayan Halder wrote:
> > From: Ayan Halder <Ayan.Halder@arm.com>
> >=20
> > The de-init routine should be doing the following in order:-
> > 1. Unregister the drm device
> > 2. Shut down the crtcs - failing to do this might cause a connector lea=
kage
> > See the 'commit 109c4d18e574 ("drm/arm/malidp: Ensure that the crtcs ar=
e
> > shutdown before removing any encoder/connector")'
> > 3. Disable the interrupts
> > 4. Unbind the components
> > 5. Free up DRM mode_config info
> >=20
> > Changes from v1:-
> > 1. Re-ordered the header files inclusion
> > 2. Rebased on top of the latest drm-misc-fixes
> >=20
> > Signed-off-by: Ayan Kumar Halder <ayan.halder@arm.com>
> > Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>
>=20
> Looks good to me.
>=20
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.=
com>
>
Pushed to drm-misc-fixes - 6978bce054247e4cfccdf689ce263e076499f905
=20
> > ---
> >  .../gpu/drm/arm/display/komeda/komeda_kms.c   | 23 ++++++++++++-------
> >  1 file changed, 15 insertions(+), 8 deletions(-)
> >=20
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_kms.c
> > index 1f0e3f4e8d74..69d9e26c60c8 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> > @@ -14,8 +14,8 @@
> >  #include <drm/drm_gem_cma_helper.h>
> >  #include <drm/drm_gem_framebuffer_helper.h>
> >  #include <drm/drm_irq.h>
> > -#include <drm/drm_vblank.h>
> >  #include <drm/drm_probe_helper.h>
> > +#include <drm/drm_vblank.h>
> > =20
> >  #include "komeda_dev.h"
> >  #include "komeda_framebuffer.h"
> > @@ -306,11 +306,11 @@ struct komeda_kms_dev *komeda_kms_attach(struct k=
omeda_dev *mdev)
> >  			       komeda_kms_irq_handler, IRQF_SHARED,
> >  			       drm->driver->name, drm);
> >  	if (err)
> > -		goto cleanup_mode_config;
> > +		goto free_component_binding;
> > =20
> >  	err =3D mdev->funcs->enable_irq(mdev);
> >  	if (err)
> > -		goto cleanup_mode_config;
> > +		goto free_component_binding;
> > =20
> >  	drm->irq_enabled =3D true;
> > =20
> > @@ -318,15 +318,21 @@ struct komeda_kms_dev *komeda_kms_attach(struct k=
omeda_dev *mdev)
> > =20
> >  	err =3D drm_dev_register(drm, 0);
> >  	if (err)
> > -		goto cleanup_mode_config;
> > +		goto free_interrupts;
> > =20
> >  	return kms;
> > =20
> > -cleanup_mode_config:
> > +free_interrupts:
> >  	drm_kms_helper_poll_fini(drm);
> >  	drm->irq_enabled =3D false;
> > +	mdev->funcs->disable_irq(mdev);
> > +free_component_binding:
> > +	component_unbind_all(mdev->dev, drm);
> > +cleanup_mode_config:
> >  	drm_mode_config_cleanup(drm);
> >  	komeda_kms_cleanup_private_objs(kms);
> > +	drm->dev_private =3D NULL;
> > +	drm_dev_put(drm);
> >  free_kms:
> >  	kfree(kms);
> >  	return ERR_PTR(err);
> > @@ -337,13 +343,14 @@ void komeda_kms_detach(struct komeda_kms_dev *kms=
)
> >  	struct drm_device *drm =3D &kms->base;
> >  	struct komeda_dev *mdev =3D drm->dev_private;
> > =20
> > -	drm->irq_enabled =3D false;
> > -	mdev->funcs->disable_irq(mdev);
> >  	drm_dev_unregister(drm);
> >  	drm_kms_helper_poll_fini(drm);
> > +	drm_atomic_helper_shutdown(drm);
> > +	drm->irq_enabled =3D false;
> > +	mdev->funcs->disable_irq(mdev);
> >  	component_unbind_all(mdev->dev, drm);
> > -	komeda_kms_cleanup_private_objs(kms);
> >  	drm_mode_config_cleanup(drm);
> > +	komeda_kms_cleanup_private_objs(kms);
> >  	drm->dev_private =3D NULL;
> >  	drm_dev_put(drm);
> >  }
> > --=20
> > 2.21.0