Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1197610ybl; Wed, 28 Aug 2019 11:02:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfXawEt2/K7pR76K8KE0SOrx/F8hljlqMG4Kt29h9v9Z9HNu7IFd5SBi7NS3h95SWhNKLF X-Received: by 2002:a63:481c:: with SMTP id v28mr4549098pga.50.1567015355191; Wed, 28 Aug 2019 11:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567015355; cv=none; d=google.com; s=arc-20160816; b=Jp5b+1ULXS84mDe3Pc0IQYE+JG4AL4Iip01XEa8O7ao9Z4FQEssAgAQ7wWNKDtoznE Nb0AWCNUwzPnwcuf1KonKfciqb1PCHnPofCUNP0GJ8B7QYwrnnRevAh7PbHxDBEXbyAM YVNS7gYd54IlfrWB+YNFCYMF1W2RrtbKWBxRVTLHDK4cJoKgTjSlyqltPhtBawoUUMOx QDSsHz1p+YVHnB9I5wIN9TrRtwwnZ2p9kp4zqJwqitwEqKHgT3bwBk/X4zNl/nJbQR5u d7dg/cRWpWT3BSx+bOd3tkHPRuaj1yWLjZnih1smsIiyo8qSbMZiYZ/sleeCDcJZwhab yaEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=v7HDhjAkh2D+zoHXgb0yBCgkw5Uep7LRFSlExOLoyPadFgoAnAZh7pPR17C6hawsov AKg21u47k+KH4UdCF+AbFPZDSnWM7Z0sze27N1SGPsyv9eqEoH7M1/VpNtM8v49CTz9D N0BWJ+LbK+hEgznpm4V2gCmlO04EhNvleBUe4p5YxAqN5rZB9d3UX54hNMIq72AApv/4 FPdhP0zo99mfgT/pnGgCsdMqxx3BTeuffGxSyAcYoVw0Dxlxrlk6+Cy+k2TQyG4ismqU 8E/5oIikIiOWqZPh4TKw3/B5gk3RUExo0m5B4YNm6hdNx9M1w3zrvSkwacQyBx/jPLZE Lv7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ASkY1rUl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si3075419pfn.199.2019.08.28.11.02.16; Wed, 28 Aug 2019 11:02:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ASkY1rUl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbfH1SBN (ORCPT + 99 others); Wed, 28 Aug 2019 14:01:13 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38030 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbfH1SBM (ORCPT ); Wed, 28 Aug 2019 14:01:12 -0400 Received: by mail-pg1-f195.google.com with SMTP id e11so138225pga.5 for ; Wed, 28 Aug 2019 11:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=ASkY1rUlh5uPsHc6yy1UDllwaGq7eHHaqrx9mHH1JQk+Juc6hS4cevD9XTNCDZesbH Mmo9mFrqYcCia1Ti/2PSg9CY+Q8KpxUS8DMx9XHSfqZZ6kXEF39+pefIA2AvUzXJi4+i 2z/Sepk/beKs+aXtnAYFGTpIHKCQHRn848/5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=NZJ+NOsXjDNzVKgUCgMrbJeNY0VIo+H+vrNfbTalPxjtMNm8pduFV0n8badLU4+lFh D4rRcqVuWmrxv8TRSZaYyKzdSt6UEUObziw3cRIpl2zoHyQixL/ZBsJpS4hlTJ60udSv tiBz5hwvsvmw60xQzd2hhS3jevaqdCCHlT63vvZsRDTF17qFzqaVgIDUKwffTcODGDCX yy26ON0lqHMqgqY19HdrGXVNv1Rj20CxFWi/f78rOmCnysxRLv2EpKpQGk1Eb4PArlgT jj3SwT5/ZxsbK3Uf0crPyeAa7H/HBN9zF2e1QM0iWH3RTnVQgFwfV3++yM7l3yUB9rVU QhXA== X-Gm-Message-State: APjAAAWt7xmZOtM7tiDJ9Yz0bJXIevB29wzM99W/JwYvdIUZRl7sOAjB 0L4vs5Pa3HbBdJzLcDSMqw9SZQ== X-Received: by 2002:a17:90a:6581:: with SMTP id k1mr5476919pjj.47.1567015272079; Wed, 28 Aug 2019 11:01:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z4sm3347892pfg.166.2019.08.28.11.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 11:01:11 -0700 (PDT) Date: Wed, 28 Aug 2019 11:01:10 -0700 From: Kees Cook To: Andy Lutomirski Cc: David Abdurachmanov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Oleg Nesterov , Will Drewry , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , David Abdurachmanov , Thomas Gleixner , Allison Randal , Alexios Zavras , Anup Patel , Vincent Chen , Alan Kao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, me@carlosedp.com Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER Message-ID: <201908281100.D78277FD@keescook> References: <20190822205533.4877-1-david.abdurachmanov@sifive.com> <201908251451.73C6812E8@keescook> <419CB0D1-E51C-49D5-9745-7771C863462F@amacapital.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <419CB0D1-E51C-49D5-9745-7771C863462F@amacapital.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 10:52:05AM -0700, Andy Lutomirski wrote: > > > > On Aug 25, 2019, at 2:59 PM, Kees Cook wrote: > > > >> On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote: > >> This patch was extensively tested on Fedora/RISCV (applied by default on > >> top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc > >> on QEMU and SiFive Unleashed board. > > > > Oops, I see the mention of QEMU here. Where's the best place to find > > instructions on creating a qemu riscv image/environment? > > I don’t suppose one of you riscv folks would like to contribute riscv support to virtme? virtme-run —arch=riscv would be quite nice, and the total patch should be just a couple lines. Unfortunately, it helps a lot to understand the subtleties of booting the architecture to write those couple lines :) As it turns out, this is where I'm stuck. All the instructions I can find are about booting a kernel off a disk image. :( -- Kees Cook