Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1261053ybl; Wed, 28 Aug 2019 11:57:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqCtDLDJAQkUhpKSnR1o+sHcEWY3E3BK49Ebtvw394Gd6D95PU+feVOIa/Q8LYXC4JdsJ/ X-Received: by 2002:a17:902:830c:: with SMTP id bd12mr5917696plb.237.1567018647323; Wed, 28 Aug 2019 11:57:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567018647; cv=none; d=google.com; s=arc-20160816; b=Evbk40Tmc0fFi8ajv93QMKjQcAnubOhz/UmZj5F9NXu0LZENcyb2MR2NtemaXag+IX TevcrMRF1txarsZOxwGPmRdXgATnfqi1pQpE4vOSs72VGKeVFyXlL9Fwds7VsZlg7hWz 19rp2drxVDxDmkqA9ePE/NzI5mDLy0xVLNi9AqwbkRQ3rJp/8WhfB+WMCqemViojKfLy 10qJnJPgJJJnKZvDqHWJv2vJOJD+TWTluwoPTfFrDpRXqPQ+J/0Thk6Sw9+xj+RAij0S evrR5VTu0NnSN9kpzvLjy+Xz0BMT4Gk2G7yostS0mOLZc9g9Xjqbj2THVnH7sU+vkUiU MAJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=x3EkMbvY5M+F0ZgkMKWKuEnvOd5+O3JVELt30UQ3AWI=; b=NSV/5rkxJDhtishLRggJgUi2w1YUXISFkvc2kjWDSD8QRcT3gPxerF5EGDOUlvfXgN jzXYI/XxyZYZqTyBde80b2U9ytIv15Tc4kYtFWnlLRWDyrU3Bpyj2Lt8udYf5H1/nvWt KYrBBUS7xxrarJ0kb7mvJ7UWR4BTiprwWuqlUUFgT7nyuodcS1UsJ/A5Ixn9I25QYlqU CThMbvpQVpzm/hSqXx+WlB2H7u7dYFT8gLcWp66/A2ogR4hXcXL132rNsPrkVE4v8QIy UhXFnMTsl6x4fTX4d7QJtpg/+yKcc4xonGqoGqHM4jRjpndh/kTTZnK7mzpvcLZ/rXux Vxwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=sdeyZstJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q21si2793491pgt.432.2019.08.28.11.57.11; Wed, 28 Aug 2019 11:57:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=sdeyZstJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbfH1Szt (ORCPT + 99 others); Wed, 28 Aug 2019 14:55:49 -0400 Received: from gateway31.websitewelcome.com ([192.185.143.40]:12617 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbfH1Szs (ORCPT ); Wed, 28 Aug 2019 14:55:48 -0400 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 962EC540E19 for ; Wed, 28 Aug 2019 13:55:47 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 336hi97Ld90on336hiv9bw; Wed, 28 Aug 2019 13:55:47 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=x3EkMbvY5M+F0ZgkMKWKuEnvOd5+O3JVELt30UQ3AWI=; b=sdeyZstJ0en07fGkSm+barpXKA forS5aUufqtOOza91wiQ6H1Z+87jwubOLF5b/2nmSVEm0nheOms69+OMJ++wbcwvO2+gtT1z8MKZ0 3GzHMCwQEFvEyBrzQQ4QvgIiyTEYdSK3gMbEJZmar38I+gXEubZtPDzQvnJaUzSHPAeIDMjVXWDWU lLQqbK2ibTDe+drgvVr8yw2ddAgDWAMseqc3Fpfkbk5acxLbolpzUN15peP6GZjZs2Xjj+nquX7Np 9JDk8pkErkBWnVv8U/Nng0fpHplu1SZCh4H7cgsEQAMRcDGSMEDMBTMYluwBa+nZ3M+rtYP50HFYj ZvoWys+Q==; Received: from [189.152.216.116] (port=50314 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1i336h-000dPQ-2m; Wed, 28 Aug 2019 13:55:47 -0500 Subject: Re: [PATCH][next] ima: ima_modsig: Fix use-after-free bug in ima_read_modsig To: Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Thiago Jung Bauermann Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190811235507.GA9587@embeddedor> <1567000215.6115.19.camel@linux.ibm.com> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= mQINBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABtCxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPokCPQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA7kCDQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAYkCJQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: Date: Wed, 28 Aug 2019 13:55:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1567000215.6115.19.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.216.116 X-Source-L: No X-Exim-ID: 1i336h-000dPQ-2m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.152.216.116]:50314 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 48 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/19 8:50 AM, Mimi Zohar wrote: > Hi Gustavo, > > On Sun, 2019-08-11 at 18:55 -0500, Gustavo A. R. Silva wrote: >> hdr is being freed and then dereferenced by accessing hdr->pkcs7_msg >> >> Fix this by copying the value returned by PTR_ERR(hdr->pkcs7_msg) into >> automatic variable err for its safe use after freeing hdr. >> >> Addresses-Coverity-ID: 1485813 ("Read from pointer after free") >> Fixes: 39b07096364a ("ima: Implement support for module-style appended signatures") >> Signed-off-by: Gustavo A. R. Silva > > This bug was reported Julia and addressed by Thiago on 8/7. If you > would like to add your Review/Tested-by, the patch can be found in the > linux-integrity next-queued-testing branch. > I'm glad this is fixed now. :) Yeah, you can add my: Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo